Desktop view:

Mobile view:

Im pretty sure Thanks is wired up not to run on mobile domain via the targets system. Lemme check.

I believe we hid this as we weren't comfortable with using the Thanks extension. cc @alexhollender in case it's something we can partner with the Growth team to fix.

@Jdlrobson let us know if your team ends up working on it.

I can't find the conversation but I remember our rationale being something like: it doesn't seem super useful to be able to thank someone before seeing the diff.

In T230657#5438248, @alexhollender wrote:

I can't find the conversation but I remember our rationale being something like: it doesn't seem super useful to be able to thank someone before seeing the diff.

Wouldn't the same logic apply on desktop though?

In T230657#5513253, @Krenair wrote:

Wouldn't the same logic apply on desktop though?

I guess so.

In T230657#5513506, @Masumrezarock100 wrote:

In T230657#5513253, @Krenair wrote:

Wouldn't the same logic apply on desktop though?

I guess so.

So whether to show it or not should be a decision made by the Thanks extension regardless of platform, not something mobile developers get to choose?

Similarly, is it useful to Undo without seeing the diff?

• Maybe if a user is repeatedly deleting the same sourced material and you see another red "-425" character count again…
• Maybe if you're undoing your own boo-boo.
• Also, a bad Undo can be undone (?) but a mistaken Thank can't be revoked.

If you remove Thank from desktop history page, you're likely to get an outpouring of complaints, of "where did it go?" questions, and of "we weren't consulted" accusations.

Do consider running RFCs before yanking anything from Vector. It might be logical to configure the setting centrally in Thank, rather than per-skin, but it would need to default to the status quo, and be something that each community can opt into.

In T230657#5438248, @alexhollender wrote:

I can't find the conversation but I remember our rationale being something like: it doesn't seem super useful to be able to thank someone before seeing the diff.

I agree. Personally I do think this task should be declined. Showing thanks outside the diff page also makes it a lot easier for people to harass users with multiple thanks. I personally think the desktop view is also broken, but as @Pelagic says, that may involve an RFC and I'm not sure it's that big a problem.

This looks like a decision for the Web-Team-Backlog team. Let the Growth-Team know if you need anything from us.

Per T230657#5438248 maybe we want to decline this and document the decision?

This looks like a decision from the Growth-Team as maintainers of Thanks.

Change 867296 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Show the thanks button on mobile history page

https://gerrit.wikimedia.org/r/867296

Change 867296 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Show the thanks button on mobile special pages

https://gerrit.wikimedia.org/r/867296

@Samwalton9 does moderator tools team want to QA this and sign off on it?

It looks like we don't have official qa bandwidth on this, so I've done some additional checking under more circumstances: the change absolutely works (a functioning thanks button appears), but there are situations where the presentation isn't great on the confirmation step:
on special contributions:

on page history:

This is not an issue with thanks specifically, but rather an issue with the jquery confirmable; I've seen this before, though I can't immediately recall where.

I agree; thanks!