Page MenuHomePhabricator
Create Task
Maniphest T232875

The "ResourceLoaderTestModules" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet
Closed, ResolvedPublic
Actions

Description

Follows-up T126091 / d1666a89fff6.

Deprecated since 1.33, in favour of QUnitTestModule extension attribute.

  • Fix the hooks.txt text to mention the intended replacement (QUnitTestModule).
  • Migrate uses of the deprecated hook in tarballed and WMF-deployed extensions. (search)
    • Cite
    • Citoid
    • CodeMirror
    • Echo
    • Graph
    • GuidedTour
    • MobileFrontend
    • PerformanceInspector
    • QuickSurveys
    • RelatedArticles
    • TemplateData
    • TemplateWizard
    • Thanks
    • Translate
    • UniversalLanguageSelector
    • UploadWizard
    • Wikibase
    • WikibaseLexeme
    • WikidataPageBanner
  • Hard-deprecate (1.36)

Details

SubjectRepoBranchLines +/-
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/Echomaster+15 -41
Hard deprecate ResourceLoaderTestModules hookmediawiki/coremaster+1 -1
Stop using ResourceLoaderTestModules hookmediawiki/extensions/Echomaster+32 -44
Deprecate using ResourceLoaderTestModules, Part Imediawiki/extensions/Wikibasemaster+76 -83
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/Wikibasemaster+20 -44
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/WikibaseLexememaster+62 -169
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/QuickSurveysmaster+29 -49
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/WikidataPageBannermaster+10 -25
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/Translatemaster+12 -21
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/Citemaster+17 -47
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/MobileFrontendmaster+14 -28
resourceloader: Document replacement for the ResourceLoaderTestModules hookmediawiki/coremaster+3 -2
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/PerformanceInspectormaster+10 -12
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/TemplateDatamaster+10 -20
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/Graphmaster+13 -37
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/CodeMirrormaster+12 -26
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/GuidedTourmaster+11 -17
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/Citoidmaster+10 -24
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/TemplateWizardmaster+12 -24
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/RelatedArticlesmaster+13 -40
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/Thanksmaster+13 -34
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/UniversalLanguageSelectormaster+13 -17
Use QUnitTestModule instead of deprecated ResourceLoaderTestModulesmediawiki/extensions/UploadWizardmaster+24 -33
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Krinkle moved this task from Blocker to To deprecate or remove on the MW-1.35-release board.Oct 11 2019, 10:44 PM
DannyS712 claimed this task.Mar 31 2020, 7:52 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 31 2020, 7:52 PM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Mar 31 2020, 7:52 PM
DannyS712 edited projects, added MediaWiki-Core-Hooks; removed MediaWiki-General.Apr 11 2020, 11:03 AM
DannyS712 moved this task from Untriaged to Hook documentation on the MediaWiki-Core-Hooks board.Apr 11 2020, 11:03 AM
DannyS712 removed DannyS712 as the assignee of this task.Apr 21 2020, 12:16 AM
Jdforrester-WMF added a comment.May 11 2020, 6:38 PM

This can't be hard-deprecated until Wikibase is fixed, which is itself blocked on moving that mutli-extension repo to use static extension registration. Joy.

Jdforrester-WMF updated the task description. (Show Details)May 11 2020, 6:42 PM
gerritbot added a comment.May 11 2020, 6:46 PM

Change 595612 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Document what people should use instead of the ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/595612

gerritbot added a project: Patch-For-Review.May 11 2020, 6:46 PM
gerritbot added a comment.May 11 2020, 6:52 PM

Change 595617 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/UploadWizard@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595617

gerritbot added a comment.May 11 2020, 6:56 PM

Change 595618 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/UniversalLanguageSelector@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595618

gerritbot added a comment.May 11 2020, 7:27 PM

Change 595617 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595617

gerritbot added a comment.May 11 2020, 7:37 PM

Change 595624 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Thanks@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595624

gerritbot added a comment.May 11 2020, 7:40 PM

Change 595625 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TemplateWizard@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595625

gerritbot added a comment.May 11 2020, 7:42 PM

Change 595618 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595618

gerritbot added a comment.May 11 2020, 7:43 PM

Change 595626 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TemplateData@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595626

gerritbot added a comment.May 11 2020, 7:47 PM

Change 595628 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/RelatedArticles@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595628

gerritbot added a comment.May 11 2020, 7:49 PM

Change 595630 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/PerformanceInspector@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595630

gerritbot added a comment.May 11 2020, 7:54 PM

Change 595632 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/QuickSurveys@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595632

gerritbot added a comment.May 11 2020, 7:57 PM

Change 595624 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595624

gerritbot added a comment.May 11 2020, 7:59 PM

Change 595633 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/MobileFrontend@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595633

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 11 2020, 8:00 PM
gerritbot added a comment.May 11 2020, 8:01 PM

Change 595626 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595626

gerritbot added a comment.May 11 2020, 8:01 PM

Change 595630 merged by jenkins-bot:
[mediawiki/extensions/PerformanceInspector@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595630

gerritbot added a comment.May 11 2020, 8:02 PM

Change 595635 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/GuidedTour@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595635

gerritbot added a comment.May 11 2020, 8:05 PM

Change 595628 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595628

gerritbot added a comment.May 11 2020, 8:05 PM

Change 595625 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595625

gerritbot added a comment.May 11 2020, 8:05 PM

Change 595636 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Graph@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595636

gerritbot added a comment.May 11 2020, 8:16 PM

Change 595638 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Echo@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595638

gerritbot added a comment.May 11 2020, 8:18 PM

Change 595639 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CodeMirror@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595639

gerritbot added a comment.May 11 2020, 8:20 PM

Change 595643 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Citoid@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595643

gerritbot added a comment.May 11 2020, 8:34 PM

Change 595645 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Cite@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595645

Jdforrester-WMF updated the task description. (Show Details)May 11 2020, 8:38 PM
gerritbot added a comment.May 11 2020, 8:39 PM

Change 595635 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595635

gerritbot added a comment.May 11 2020, 8:39 PM

Change 595633 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595633

gerritbot added a comment.May 11 2020, 8:39 PM

Change 595639 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595639

gerritbot added a comment.May 11 2020, 8:39 PM

Change 595643 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595643

gerritbot added a comment.May 11 2020, 8:45 PM

Change 595636 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595636

Reedy mentioned this in rECEX0b802a901b43: Use QUnitTestModule instead of deprecated ResourceLoaderTestModules.May 11 2020, 8:49 PM
Reedy mentioned this in rEGRA3a49e2642454: Use QUnitTestModule instead of deprecated ResourceLoaderTestModules.
gerritbot added a comment.May 11 2020, 9:23 PM

Change 595645 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595645

gerritbot added a comment.May 11 2020, 9:48 PM

Change 595612 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Document replacement for the ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/595612

Reedy updated the task description. (Show Details)May 11 2020, 10:02 PM
Reedy mentioned this in rEGTO528dd0001bef: Use QUnitTestModule instead of deprecated ResourceLoaderTestModules.May 11 2020, 10:09 PM
Jdforrester-WMF updated the task description. (Show Details)May 12 2020, 12:06 AM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.May 12 2020, 12:21 AM

Change 595733 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Translate@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595733

gerritbot added a comment.May 12 2020, 12:42 AM

Change 595735 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseLexeme@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595735

gerritbot added a comment.May 12 2020, 12:45 AM

Change 595736 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikidataPageBanner@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595736

gerritbot added a comment.May 13 2020, 10:42 AM

Change 595733 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595733

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 13 2020, 11:00 AM
Jdforrester-WMF updated the task description. (Show Details)May 13 2020, 3:25 PM
Aklapper added a comment.May 17 2020, 9:57 PM
In T232875#6126199, @Jdforrester-WMF wrote:

This can't be hard-deprecated until Wikibase is fixed, which is itself blocked on moving that mutli-extension repo to use static extension registration. Joy.

Is there an existing ticket about fixing Wikibase, so this ticket should depend on that one?

Reedy subscribed.May 17 2020, 9:59 PM
In T232875#6143388, @Aklapper wrote:
In T232875#6126199, @Jdforrester-WMF wrote:

This can't be hard-deprecated until Wikibase is fixed, which is itself blocked on moving that mutli-extension repo to use static extension registration. Joy.

Is there an existing ticket about fixing Wikibase, so this ticket should depend on that one?

T88258: Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration

gerritbot added a comment.May 18 2020, 2:41 PM

Change 595736 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595736

gerritbot added a comment.May 18 2020, 2:41 PM

Change 595632 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595632

DannyS712 removed a project: User-DannyS712.Jun 13 2020, 8:34 AM
Legoktm edited projects, added MW-1.36-release; removed MW-1.35-release.Jul 13 2020, 10:15 PM
Legoktm subscribed.

Not going to make 1.35...

Ladsgroup updated the task description. (Show Details)Jul 15 2020, 3:35 PM
gerritbot added a comment.Jul 15 2020, 4:11 PM

Change 595735 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/595735

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 15 2020, 5:00 PM
Ladsgroup updated the task description. (Show Details)Jul 15 2020, 8:46 PM
gerritbot added a comment.Jul 15 2020, 9:07 PM

Change 612952 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/612952

gerritbot added a comment.Jul 16 2020, 10:46 AM

Change 612952 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use QUnitTestModule instead of deprecated ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/612952

gerritbot added a comment.Jul 16 2020, 5:17 PM

Change 613208 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] [WIP] Deprecate using ResourceLoaderTestModules

https://gerrit.wikimedia.org/r/613208

Ladsgroup mentioned this in T258818: Echo doesn't register or run any of its qunit tests.Jul 24 2020, 6:20 PM
gerritbot added a comment.Aug 3 2020, 10:53 AM

Change 618024 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Echo@master] Stop using ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/618024

gerritbot added a comment.Aug 3 2020, 11:32 AM

Change 613208 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Deprecate using ResourceLoaderTestModules, Part I

https://gerrit.wikimedia.org/r/613208

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.3; 2020-08-04); removed MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Aug 3 2020, 12:01 PM
gerritbot added a comment.Aug 3 2020, 12:11 PM

Change 618024 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Stop using ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/618024

Ladsgroup updated the task description. (Show Details)Aug 3 2020, 12:21 PM
Ammarpad added a subtask: T259707: Replace usage of ResourceLoaderTestModules hook in MobileFrontend?.Aug 5 2020, 1:05 PM
Ammarpad claimed this task.Aug 7 2020, 1:13 AM
Ammarpad updated the task description. (Show Details)
Ladsgroup closed subtask T259697: Migrate ResourceLoaderTestModules hook in Wikibase to QUnitTestModule as Resolved.Aug 12 2020, 9:58 AM
Ladsgroup updated the task description. (Show Details)
Ladsgroup subscribed.

Wikibase is now done (with a 200-line Qunit module). The only thing left to call this done is MobileFrontend.

Jdforrester-WMF updated the task description. (Show Details)Aug 12 2020, 10:05 AM
Ladsgroup closed subtask T259707: Replace usage of ResourceLoaderTestModules hook in MobileFrontend? as Resolved.Aug 12 2020, 6:21 PM
Ladsgroup updated the task description. (Show Details)
Ladsgroup updated the task description. (Show Details)Aug 12 2020, 6:32 PM
gerritbot added a comment.Aug 12 2020, 6:39 PM

Change 619819 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Hard deprecate ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/619819

Jdforrester-WMF edited projects, added MW-1.37-release; removed MW-1.36-release.Aug 13 2020, 9:49 AM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.37-release board.
gerritbot added a comment.Aug 13 2020, 10:07 AM

Change 619819 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/619819

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.5; 2020-08-18); removed MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 13 2020, 11:00 AM
Ammarpad closed this task as Resolved.Aug 14 2020, 10:55 AM
Ammarpad reassigned this task from Ammarpad to Ladsgroup.
Ammarpad updated the task description. (Show Details)
Ammarpad subscribed.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 14 2020, 10:56 AM
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Aug 14 2020, 11:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL