Page MenuHomePhabricator
Create Task
Maniphest T232903

The installer should use `.warningbox` for styling warnings, not `.mw-infobox`
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Jdlrobson
Authored By
Volker_E
Sep 13 2019, 11:54 PM
Tags
Referenced Files
F34408993: Screen Shot 2021-04-20 at 4.08.18 PM.png
Apr 20 2021, 11:08 PM
F31952445: Screenshot 2020-07-29 at 01.16.41.png
Jul 29 2020, 12:17 AM
F31952434: Screenshot 2020-07-29 at 01.09.51.png
Jul 29 2020, 12:10 AM
F30325039: image.png
Sep 14 2019, 3:13 AM
F30330344: image.png
Sep 14 2019, 3:13 AM
Subscribers
Aklapper
Freakolowsky
Jdforrester-WMF
Jdlrobson
Jdrewniak
Krinkle
Volker_E
Tokens
"Orange Medal" token, awarded by Krinkle.

Description

.mw-infobox is in use by Html::infoBox by the Web Installer.
It shouldn't receive different color appearance other than one of the standard boxes .warningbox or .messagebox as they are also available in 'shared.css' and are aligned to Design Style Guide.

CurrentProposed
image.png (322×1 px, 42 KB)
image.png (130×1 px, 28 KB)

This has last been touched ~8 years ago.

Dev notes

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Sep 17 2019, 4:47 AM

Change 537244 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Deprecate Html::infoBox

https://gerrit.wikimedia.org/r/537244

gerritbot added a project: Patch-For-Review.Sep 17 2019, 4:47 AM

Change 537245 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] [WIP] Replace infobox usages and extend warningbox and errorbox

https://gerrit.wikimedia.org/r/537245

gerritbot added a comment.Sep 25 2019, 12:44 AM

Change 537245 merged by jenkins-bot:
[mediawiki/core@master] Replace infobox usages and extend successbox, warningbox and errorbox

https://gerrit.wikimedia.org/r/537245

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 25 2019, 1:00 AM
Volker_E updated the task description. (Show Details)Sep 25 2019, 2:47 AM
Krinkle awarded a token.Sep 25 2019, 3:19 AM
Krinkle added a project: MW-1.35-release.Sep 25 2019, 3:25 AM
Krinkle added a project: Technical-Debt (Deprecation process).

Tagging as 1.35 reminder to remove the then-deprecated WebInstaller methods and then-obsolete Html method.

Krinkle moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Sep 25 2019, 3:26 AM
Krinkle moved this task from 2020 | MW 1.35 to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.
gerritbot added a comment.Sep 26 2019, 8:16 PM

Change 537244 merged by jenkins-bot:
[mediawiki/core@master] installer: Deprecate WebInstaller::getInfoBox, getWarningBox and getErrorBox

https://gerrit.wikimedia.org/r/537244

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2019, 9:10 PM
phuedx moved this task from Incoming to Tracking on the Web-Team-Backlog board.Oct 10 2019, 12:55 PM
phuedx edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
Krinkle moved this task from Blocker to To deprecate or remove on the MW-1.35-release board.Nov 6 2019, 12:55 AM
gerritbot added a comment.Jul 14 2020, 10:46 PM

Change 612679 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612679

gerritbot added a project: Patch-For-Review.Jul 14 2020, 10:46 PM
gerritbot added a comment.Jul 14 2020, 11:04 PM

Change 612500 had a related patch set uploaded (by Reedy; owner: Legoktm):
[mediawiki/core@REL1_35] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612500

gerritbot added a comment.Jul 14 2020, 11:04 PM

Change 612501 had a related patch set uploaded (by Reedy; owner: Legoktm):
[mediawiki/core@REL1_34] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612501

gerritbot added a comment.Jul 14 2020, 11:13 PM

Change 612501 merged by jenkins-bot:
[mediawiki/core@REL1_34] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612501

gerritbot added a comment.Jul 14 2020, 11:14 PM

Change 612500 merged by jenkins-bot:
[mediawiki/core@REL1_35] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612500

gerritbot added a comment.Jul 14 2020, 11:15 PM

Change 612679 merged by jenkins-bot:
[mediawiki/core@master] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612679

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2020, 12:10 AM
Krinkle removed a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Jul 29 2020, 12:07 AM
Krinkle updated the task description. (Show Details)
Krinkle added a comment.EditedJul 29 2020, 12:10 AM

I've confirmed that in installer, when asking to restart installation, it uses an element that does not contain mw-infobox:

Screenshot 2020-07-29 at 01.09.51.png (856×2 px, 342 KB)

But.. other parts of the installer, still use it:

Screenshot 2020-07-29 at 01.16.41.png (814×2 px, 329 KB)

gerritbot added a comment.Jul 29 2020, 12:19 AM

Change 616956 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] installer: Remove deprecated getWarningBox() and getErrorBox()

https://gerrit.wikimedia.org/r/616956

gerritbot added a project: Patch-For-Review.Jul 29 2020, 12:19 AM
Krinkle added a comment.Jul 29 2020, 12:19 AM

Untagging from 1.35 blocker as this requires more migration updates first.

Krinkle edited projects, added MW-1.36-release; removed MW-1.35-release.Jul 29 2020, 12:21 AM
Krinkle updated the task description. (Show Details)
gerritbot added a comment.Jul 29 2020, 12:21 AM

Change 616930 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_35] installer: Remove deprecated getWarningBox() and getErrorBox()

https://gerrit.wikimedia.org/r/616930

gerritbot added a comment.Jul 29 2020, 6:33 AM

Change 616956 merged by jenkins-bot:
[mediawiki/core@master] installer: Remove deprecated getWarningBox() and getErrorBox()

https://gerrit.wikimedia.org/r/616956

gerritbot added a comment.Jul 29 2020, 6:49 AM

Change 616930 merged by jenkins-bot:
[mediawiki/core@REL1_35] installer: Remove deprecated getWarningBox() and getErrorBox()

https://gerrit.wikimedia.org/r/616930

ReleaseTaggerBot added projects: MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 29 2020, 7:00 AM
Iniquity mentioned this in T268194: Mark `.mw-infobox` CSS class removal from legacy.less in 1.37.Nov 19 2020, 2:35 AM
Jdlrobson added a subtask: T268078: Hard deprecate Html::infoBox.Nov 19 2020, 4:00 PM
Jdlrobson added a subtask: T268194: Mark `.mw-infobox` CSS class removal from legacy.less in 1.37.
Volker_E updated the task description. (Show Details)Nov 20 2020, 3:55 PM
Volker_E updated the task description. (Show Details)
Jdlrobson closed subtask T268078: Hard deprecate Html::infoBox as Resolved.Nov 21 2020, 8:43 PM
Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.Dec 9 2020, 7:23 PM
Jdlrobson moved this task from Backlog to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.Dec 9 2020, 8:23 PM
Jdlrobson renamed this task from Standardise `.mw-infobox` by relying on `.warningbox` to The installer should use `.warningbox` for styling warnings, not `.mw-infobox`.Dec 10 2020, 7:01 PM
Jdlrobson mentioned this in T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature.Dec 10 2020, 7:15 PM
Volker_E updated the task description. (Show Details)Dec 23 2020, 9:54 PM
Volker_E updated the task description. (Show Details)
Volker_E added a comment.Dec 23 2020, 11:14 PM

Related: T270796: Message boxes classes should carry `mw-`

Jdlrobson closed subtask T268194: Mark `.mw-infobox` CSS class removal from legacy.less in 1.37 as Resolved.Feb 9 2021, 10:44 PM
Jdlrobson added a comment.Feb 9 2021, 10:47 PM

https://codesearch.wmcloud.org/search/?q=mw-infobox&i=nope&files=&excludeFiles=&repos=

Next up: WebInstaller::infoBox should use Html::warningBox

Jdlrobson added a project: good first task.Mar 16 2021, 10:13 PM
hashar unsubscribed.Mar 17 2021, 9:11 AM
gerritbot added a comment.Mar 24 2021, 12:25 AM

Change 674457 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Fix the styling of the installer and deprecate its RL module

https://gerrit.wikimedia.org/r/674457

Jdlrobson triaged this task as Medium priority.Mar 30 2021, 10:48 PM
Jdforrester-WMF subscribed.Apr 10 2021, 10:44 PM

Hey there, should this be moved to 1.37? The cut for 1.36 has happened, and 1.36.0-rc.0 will be cut in a fortnight or so, after which feature changes shouldn't be landed and back-ported.

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog (Tracking).Apr 14 2021, 6:51 PM

1.36 release blocker.

Jdlrobson raised the priority of this task from Medium to High.Apr 14 2021, 10:02 PM
gerritbot added a comment.Apr 14 2021, 10:17 PM

Change 679506 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Installer: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`

https://gerrit.wikimedia.org/r/679506

gerritbot added a comment.Apr 14 2021, 10:21 PM

Change 674457 abandoned by Jdlrobson:

[mediawiki/core@master] Fix the styling of the installer and deprecate its RL module

Reason:

See https://gerrit.wikimedia.org/r/c/mediawiki/core/ /679503

https://gerrit.wikimedia.org/r/674457

Krinkle mentioned this in T280197: Gerritbot turns "+" into space, thus breaking most Gerrit URLs.Apr 14 2021, 11:26 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 14 2021, 11:44 PM
gerritbot added a comment.Apr 19 2021, 1:40 PM

Change 679506 merged by jenkins-bot:

[mediawiki/core@master] Installer: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`

https://gerrit.wikimedia.org/r/679506

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 19 2021, 2:00 PM
Jdforrester-WMF added a comment.Apr 19 2021, 3:40 PM

Is this Resolved if we land it into REL1_36 or is there more to do?

Jdlrobson moved this task from Upcoming to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 19 2021, 3:49 PM
gerritbot added a comment.Apr 19 2021, 4:18 PM

Change 680864 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@REL1_36] Installer: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`

https://gerrit.wikimedia.org/r/680864

gerritbot added a comment.Apr 19 2021, 4:50 PM

Change 680864 merged by jenkins-bot:

[mediawiki/core@REL1_36] Installer: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`

https://gerrit.wikimedia.org/r/680864

ReleaseTaggerBot edited projects, added MW-1.36-notes; removed MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Apr 19 2021, 5:00 PM
Jdlrobson claimed this task.Apr 19 2021, 5:29 PM
gerritbot added a comment.Apr 20 2021, 12:29 AM

Change 679507 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Installer: Simplify stylesheet

https://gerrit.wikimedia.org/r/679507

Jdlrobson removed Jdlrobson as the assignee of this task.Apr 20 2021, 12:29 AM
Jdlrobson assigned this task to Jdrewniak.
Jdlrobson moved this task from Ready for Signoff to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

If Jan can review the last patch I think we're good to call this done!

Jdlrobson removed Jdrewniak as the assignee of this task.Apr 20 2021, 5:04 PM
Jdlrobson added a subscriber: Jdrewniak.
LGoto assigned this task to Jdrewniak.Apr 20 2021, 5:08 PM
ovasileva set the point value for this task to 5.Apr 20 2021, 5:24 PM
ovasileva removed the point value for this task.
Jdlrobson updated the task description. (Show Details)Apr 20 2021, 5:30 PM
ovasileva set the point value for this task to 2.Apr 20 2021, 5:33 PM
gerritbot added a comment.Apr 20 2021, 9:40 PM

Change 679507 merged by jenkins-bot:

[mediawiki/core@master] Installer: Simplify stylesheet

https://gerrit.wikimedia.org/r/679507

gerritbot added a comment.Apr 20 2021, 9:42 PM

Change 681373 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@REL1_36] Installer: Simplify stylesheet

https://gerrit.wikimedia.org/r/681373

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 20 2021, 9:42 PM
gerritbot added a comment.Apr 20 2021, 9:54 PM

Change 681373 merged by jenkins-bot:

[mediawiki/core@REL1_36] Installer: Simplify stylesheet

https://gerrit.wikimedia.org/r/681373

Jdlrobson closed this task as Resolved.Apr 20 2021, 11:07 PM
Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)

@Volker_E have broken out the acceptance criteria

[] Remove all extra visual properties aside of pure box layout properties
[] Replace outdated PNG icon with current standard icon and consider SVG

This doesn't look like it blocks 1.36 and looks like it can be done in a follow up.

Screenshot of the installer with new warningbox on the feature branch:

Screen Shot 2021-04-20 at 4.08.18 PM.png (1×2 px, 543 KB)

Volker_E removed a project: Patch-For-Review.Jun 26 2021, 9:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits