Page MenuHomePhabricator

The installer should use `.warningbox` for styling warnings, not `.mw-infobox`
Closed, ResolvedPublic2 Estimated Story Points

Description

.mw-infobox is in use by Html::infoBox by the Web Installer.
It shouldn't receive different color appearance other than one of the standard boxes .warningbox or .messagebox as they are also available in 'shared.css' and are aligned to Design Style Guide.

CurrentProposed

This has last been touched ~8 years ago.

Dev notes

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Given we now have .messagebox and .warningbox, if the shared.css style is applied to the installer pages, I see no reason for not using them. So the later option I guess, migrate to the new standard and deprecate the barely used and dated method that nobody uses anyway.

The process for deprecation is https://www.mediawiki.org/wiki/Deprecation_policy

We should get the change in soon since MediaWiki 1.34 is about to be cut (though we can still do a backport).

Change 537244 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Deprecate Html::infoBox

https://gerrit.wikimedia.org/r/537244

Change 537245 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] [WIP] Replace infobox usages and extend warningbox and errorbox

https://gerrit.wikimedia.org/r/537245

Change 537245 merged by jenkins-bot:
[mediawiki/core@master] Replace infobox usages and extend successbox, warningbox and errorbox

https://gerrit.wikimedia.org/r/537245

Tagging as 1.35 reminder to remove the then-deprecated WebInstaller methods and then-obsolete Html method.

Change 537244 merged by jenkins-bot:
[mediawiki/core@master] installer: Deprecate WebInstaller::getInfoBox, getWarningBox and getErrorBox

https://gerrit.wikimedia.org/r/537244

Change 612679 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612679

Change 612500 had a related patch set uploaded (by Reedy; owner: Legoktm):
[mediawiki/core@REL1_35] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612500

Change 612501 had a related patch set uploaded (by Reedy; owner: Legoktm):
[mediawiki/core@REL1_34] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612501

Change 612501 merged by jenkins-bot:
[mediawiki/core@REL1_34] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612501

Change 612500 merged by jenkins-bot:
[mediawiki/core@REL1_35] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612500

Change 612679 merged by jenkins-bot:
[mediawiki/core@master] installer: Undeprecate WebInstaller::getInfoBox(), still used

https://gerrit.wikimedia.org/r/612679

I've confirmed that in installer, when asking to restart installation, it uses an element that does not contain mw-infobox:

But.. other parts of the installer, still use it:

Change 616956 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] installer: Remove deprecated getWarningBox() and getErrorBox()

https://gerrit.wikimedia.org/r/616956

Untagging from 1.35 blocker as this requires more migration updates first.

Change 616930 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_35] installer: Remove deprecated getWarningBox() and getErrorBox()

https://gerrit.wikimedia.org/r/616930

Change 616956 merged by jenkins-bot:
[mediawiki/core@master] installer: Remove deprecated getWarningBox() and getErrorBox()

https://gerrit.wikimedia.org/r/616956

Change 616930 merged by jenkins-bot:
[mediawiki/core@REL1_35] installer: Remove deprecated getWarningBox() and getErrorBox()

https://gerrit.wikimedia.org/r/616930

Volker_E updated the task description. (Show Details)
Jdlrobson renamed this task from Standardise `.mw-infobox` by relying on `.warningbox` to The installer should use `.warningbox` for styling warnings, not `.mw-infobox`.Dec 10 2020, 7:01 PM
Volker_E updated the task description. (Show Details)

Change 674457 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Fix the styling of the installer and deprecate its RL module

https://gerrit.wikimedia.org/r/674457

Jdlrobson triaged this task as Medium priority.Mar 30 2021, 10:48 PM

Hey there, should this be moved to 1.37? The cut for 1.36 has happened, and 1.36.0-rc.0 will be cut in a fortnight or so, after which feature changes shouldn't be landed and back-ported.

Jdlrobson raised the priority of this task from Medium to High.Wed, Apr 14, 10:02 PM

Change 679506 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Installer: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`

https://gerrit.wikimedia.org/r/679506

Change 674457 abandoned by Jdlrobson:

[mediawiki/core@master] Fix the styling of the installer and deprecate its RL module

Reason:

See https://gerrit.wikimedia.org/r/c/mediawiki/core/ /679503

https://gerrit.wikimedia.org/r/674457

Change 679506 merged by jenkins-bot:

[mediawiki/core@master] Installer: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`

https://gerrit.wikimedia.org/r/679506

Is this Resolved if we land it into REL1_36 or is there more to do?

Change 680864 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@REL1_36] Installer: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`

https://gerrit.wikimedia.org/r/680864

Change 680864 merged by jenkins-bot:

[mediawiki/core@REL1_36] Installer: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`

https://gerrit.wikimedia.org/r/680864

Change 679507 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Installer: Simplify stylesheet

https://gerrit.wikimedia.org/r/679507

Jdlrobson assigned this task to Jdrewniak.

If Jan can review the last patch I think we're good to call this done!

Jdlrobson added a subscriber: Jdrewniak.
ovasileva set the point value for this task to 5.Tue, Apr 20, 5:24 PM
ovasileva removed the point value for this task.
ovasileva set the point value for this task to 2.Tue, Apr 20, 5:33 PM

Change 679507 merged by jenkins-bot:

[mediawiki/core@master] Installer: Simplify stylesheet

https://gerrit.wikimedia.org/r/679507

Change 681373 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@REL1_36] Installer: Simplify stylesheet

https://gerrit.wikimedia.org/r/681373

Change 681373 merged by jenkins-bot:

[mediawiki/core@REL1_36] Installer: Simplify stylesheet

https://gerrit.wikimedia.org/r/681373

Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)

@Volker_E have broken out the acceptance criteria

[] Remove all extra visual properties aside of pure box layout properties
[] Replace outdated PNG icon with current standard icon and consider SVG

This doesn't look like it blocks 1.36 and looks like it can be done in a follow up.

Screenshot of the installer with new warningbox on the feature branch: