Exiting an image displayed via mediaviewer on wikipedia takes you back one site in browser history instead of taking you to base article
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bremys
	Oct 26 2019, 9:50 AM

Description

I have produced the bug with both Firefox and Chrome on my laptop.

Go to any website which is not Wikipedia, for example https://www.google.com
Go then directly to an image in Wikipedia, for example https://en.wikipedia.org/wiki/Lone_Wolf_and_Cub#/media/File:Lone_Wolf_manga.jpg
Close the image, either by ESC button or by pressing the X button.

Actual Results: It takes you back to the last website in browsing history, https://www.google.com on my example.
Expected Results: It should have taken to the base article which the image is from, https://en.wikipedia.org/wiki/Lone_Wolf_and_Cub on my example.

Details

Subject	Repo	Branch	Lines +/-
Router handling code should be centralized into mmv.bootstrap	mediawiki/extensions/MultimediaViewer	wmf/1.41.0-wmf.7	+76 -73
Router handling code should be centralized into mmv.bootstrap	mediawiki/extensions/MultimediaViewer	master	+76 -73
Save history position before opening MMV; remove need to restore scroll position; replace javascript-positioning with static css; cleanup html and css.	mediawiki/extensions/MultimediaViewer	master	+819 -679

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid	Goal	None	T257087 Demian's 2020 MediaViewer cleanup and bugfixes (tracking)
		Resolved		Jdlrobson	T236591 Exiting an image displayed via mediaviewer on wikipedia takes you back one site in browser history instead of taking you to base article

Event Timeline

Bremys created this task.Oct 26 2019, 9:50 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2019, 9:50 AM

Reedy added a project: MediaViewer.Oct 26 2019, 10:00 AM

Aklapper renamed this task from Exiting an image on wikipedia takes you back one site in history instead of returning to base article to Exiting an image on wikipedia takes you back one site in browser history instead of taking you to base article.Oct 26 2019, 10:42 AM

Peachey88 renamed this task from Exiting an image on wikipedia takes you back one site in browser history instead of taking you to base article to Exiting an image displayed via mediawiki on wikipedia takes you back one site in browser history instead of taking you to base article.Oct 26 2019, 10:52 AM

Peachey88 renamed this task from Exiting an image displayed via mediawiki on wikipedia takes you back one site in browser history instead of taking you to base article to Exiting an image displayed via mediaviewer on wikipedia takes you back one site in browser history instead of taking you to base article.

Change 560576 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/extensions/MultimediaViewer@master] After closing, browser sometimes scrolls to the top of the page

https://gerrit.wikimedia.org/r/560576

gerritbot added a project: Patch-For-Review.Jan 20 2020, 7:56 AM

Change 560576 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/extensions/MultimediaViewer@master] Save history position before opening MMV; remove need to restore scroll position; replace javascript-positioning with static css; cleanup html and css.

https://gerrit.wikimedia.org/r/560576

• Demian mentioned this in T257087: Demian's 2020 MediaViewer cleanup and bugfixes (tracking).Jul 3 2020, 11:20 PM

Reedy merged a task: T260673: Going directly to a Mediaviewer file URL and closing the file, browser opens previous page in tab, instead of page in the MediaViewer URL.Aug 18 2020, 11:11 AM

Reedy added a subscriber: NemoLePoisson.

• Demian added a parent task: T257087: Demian's 2020 MediaViewer cleanup and bugfixes (tracking).Nov 2 2020, 12:00 AM

• Demian moved this task from Backlog to In Process on the MediaViewer board.Nov 2 2020, 2:24 AM

The submitted patch resolves this bug too.

Test wiki created on Patch Demo by Aron Manning using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/b8b692ed0df0cfb694260dfeb7cfaa3f/w/

[Resetting assignee due to inactive user account]

Aklapper mentioned this in T268451: The media viewer’s close button shows previous page rather than closing the view.Nov 23 2020, 1:41 PM

Esanders merged a task: T268451: The media viewer’s close button shows previous page rather than closing the view.Nov 28 2020, 11:26 AM

Esanders added a subscriber: nclm.

Pcoombe subscribed.Apr 30 2021, 1:32 PM

Test wiki on Patch Demo by Aron Manning using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/b8b692ed0df0cfb694260dfeb7cfaa3f/w/~~

Aklapper moved this task from In Process to Backlog on the MediaViewer board.Mar 16 2022, 11:35 AM

Aklapper triaged this task as Low priority.Jul 14 2022, 9:51 AM

Change 560576 abandoned by Ladsgroup:

[mediawiki/extensions/MultimediaViewer@master] Save history position before opening MMV; remove need to restore scroll position; replace javascript-positioning with static css; cleanup html and css.

Reason:

The author has been banned indef from our tech spaces and the patch has not been touched for really long time.

https://gerrit.wikimedia.org/r/560576

matmarex merged a task: T328504: Hyperlinked image previews have unexpected behaviour when closed.Feb 2 2023, 8:33 PM

matmarex added a subscriber: Rozabbb.

Tgr mentioned this in T241909: Closing mediaviewer can unexpectedly close browser tab.Feb 6 2023, 6:43 PM

From T241909: Closing mediaviewer can unexpectedly close browser tab

In T241909#5775955, @Krinkle wrote:

Yes, consistently reproducible in Firefox (incl Private browsing) and Chrome (incl Incognito mode).

Firefox -> new private browsing window -> paste url in address bar and hit enter -> after it loads press "X" close button of Mediaviewer.

If this doesn't happen for you, perhaps it is specific to the macOS versions of both of these browsers.

In T241909#8590659, @Tgr wrote:

I guess MediaViewer (or the OO.Router functionality it uses) triggers a history back-navigation when it shouldn't. History handling seems quite broken in a number of other small ways too (e.g. if you launch MediaViewer by clicking on an image, and then navigate between images, the back button doesn't behave reasonably).

IOW this seems like a duplicate of T236591, with the previous history entry being chrome://newtab or such.

Krinkle merged a task: T241909: Closing mediaviewer can unexpectedly close browser tab.Feb 8 2023, 7:21 PM

Krinkle awarded a token.

Krinkle added a subscriber: Lectrician1.

TheDJ subscribed.Feb 20 2023, 3:22 PM

LucasWerkmeister awarded a token.Mar 15 2023, 7:24 PM

Pppery removed a project: Patch-For-Review.Apr 9 2023, 7:42 PM

Change 910522 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MultimediaViewer@master] Allow editors to go back from MMV overlay to article

https://gerrit.wikimedia.org/r/910522

gerritbot added a project: Patch-For-Review.Apr 20 2023, 3:51 PM

This was #65 on the community wishlist and we've solved this in MobileFrontend so I've posted a patch (cc @matmarex who hopefully finds it familiar!). MultimediaViewer and MobileFrontend never run at the same time so this change should be safe.

Lectrician1 awarded a token.Apr 21 2023, 10:48 AM

Change 910522 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Router handling code should be centralized into mmv.bootstrap

https://gerrit.wikimedia.org/r/910522

matmarex merged a task: T283982: Clicking X button on Media Viewer does not go back to the article itself when the link is visited with no referer.May 2 2023, 1:16 PM

matmarex added a subscriber: fireattack.

Community-Wishlist-Survey-2023 entry for reference: https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2023/Reading/Return_to_the_article_when_closing_the_MediaViewer

Thanks @Jdlrobson!

Change 914301 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MultimediaViewer@wmf/1.41.0-wmf.7] Router handling code should be centralized into mmv.bootstrap

https://gerrit.wikimedia.org/r/914301

Change 914301 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@wmf/1.41.0-wmf.7] Router handling code should be centralized into mmv.bootstrap

https://gerrit.wikimedia.org/r/914301

Mentioned in SAL (#wikimedia-operations) [2023-05-03T20:43:15Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:914301|Router handling code should be centralized into mmv.bootstrap (T236591)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-03T20:44:46Z] <cjming@deploy1002> cjming and jdlrobson: Backport for [[gerrit:914301|Router handling code should be centralized into mmv.bootstrap (T236591)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-03T20:53:23Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:914301|Router handling code should be centralized into mmv.bootstrap (T236591)]] (duration: 10m 08s)

Thanks for the help on thus one!

I also backported it.

I've added it to Tech News using the wording

When you close an image that is displayed via MediaViewer, it will now return to the wiki page instead of going back in your browser history. This feature request was voted #65 in the 2023 Community Wishlist Survey.

If that is inaccurate, please update it directly.
(Reminder note: Draft wording by those who are familiar with a task, is always appreciated, so that I (or other Tech News editors) don't have to (try to) learn the entire thing in order to summarize it. Thanks!)