Page MenuHomePhabricator

Allow HTMLUsersMultiselectField to set max limit on number of selected items
Closed, ResolvedPublic

Description

This can be done by passing the tagLimit config through to TagMultiselectWidget.

Details

Related Gerrit Patches:

Event Timeline

Change 550737 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Allow HTMLUsersMultiselectField to limit number of selected items

https://gerrit.wikimedia.org/r/550737

Florian closed this task as Resolved.Nov 14 2019, 3:37 AM
dbarratt reopened this task as Open.Nov 14 2019, 3:38 AM
dbarratt moved this task from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
dbarratt added a subscriber: dbarratt.

Re-opening to give opportunity for QA.

dom_walden added a subscriber: dom_walden.

I don't see anything currently that uses HTMLUsersMultiselectField at the moment. I don't think there is anything for me to test until other CheckUser work is complete.

I am going to mark this as done. Testing will be done as part of later work.

I don't see anything currently that uses HTMLUsersMultiselectField at the moment.

I believe this is used on https://test.wikipedia.org/wiki/Special:Preferences in the "Prohibit these users from emailing me" field as well as on https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-echo in the "Do not display notifications from these users" field. I believe these fields are enabled through config (I can figure out the configs if you would like).

I don't see anything currently that uses HTMLUsersMultiselectField at the moment.

I believe this is used on https://test.wikipedia.org/wiki/Special:Preferences in the "Prohibit these users from emailing me" field as well as on https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-echo in the "Do not display notifications from these users" field. I believe these fields are enabled through config (I can figure out the configs if you would like).

Oh, I missed those, thanks! I think I know how to enable them.

Change 550737 merged by jenkins-bot:
[mediawiki/core@master] Allow HTMLUsersMultiselectField to limit number of selected items

https://gerrit.wikimedia.org/r/550737

After applying patch in https://gerrit.wikimedia.org/r/552269, I am now limited to entering 2 users/IPs in the Special:Investigate form. (While writing this thegoodplace doesn't have that patch, so form does not quite behave as it should.)

I briefly retested the "Prohibit these users from emailing me" input in Special:Preferences. In particular, I tested adding lots of usernames to the input just in case we have accidently introduced some sort of default max limit. I could enter over 500 usernames.

dbarratt closed this task as Resolved.Dec 2 2019, 3:37 PM