Page MenuHomePhabricator

Newcomer tasks: topic filters
Open, Needs TriagePublic

Description

In T235042, we implemented a filter where users can choose the type of task they want to do. The following work is similar, but for a filter in which they choose the topics they're interested in.

This filter should contain the exact same content and rules as used in the bottom half of the intro overlay, specified here: T238610: Newcomer tasks: include topics in intro overlay.

The mockups for the filter are in this screen and this screen.

The only exception is that whereas the intro overlay updated the article count based on the default difficulty level settings for user initiating suggested edits, this filter dialog should update the article count based on whichever task types the user has selected at the time they are interacting with the filter.

Details

Related Gerrit Patches:
mediawiki/extensions/GrowthExperiments : masterSuggested Edits: Fix button label from done state
mediawiki/extensions/GrowthExperiments : masterSuggested Edits: Expand filters if below the fold item is checked
mediawiki/extensions/GrowthExperiments : masterSuggested Edits: Add topic filters dialog

Event Timeline

MMiller_WMF moved this task from Inbox to Upcoming Work on the Growth-Team board.
RHo updated the task description. (Show Details)Dec 13 2019, 6:23 PM
MMiller_WMF updated the task description. (Show Details)Dec 13 2019, 11:58 PM

Although this is in Ready for Development, I think it will be easier to do once T238610 and T240512 are wrapped up.

kostajh removed kostajh as the assignee of this task.Thu, Jan 9, 2:07 PM

On second thought, since I can't wrap this up before signing off for the afternoon I'll leave it for @Catrope or @Tgr. If it's still unclaimed tomorrow (or someone wants to start it and hand it off) I can pick it up then.

Catrope removed Catrope as the assignee of this task.Fri, Jan 10, 12:53 AM

Like Kosta I also ran out of time, so I'll put this back in the pool so that either Kosta can pick it up in his morning, or I can pick it up in my morning tomorrow.

kostajh claimed this task.Fri, Jan 10, 11:43 AM

For real this time!

The only exception is that whereas the intro overlay updated the article count based on the default difficulty level settings for user initiating suggested edits, this filter dialog should update the article count based on whichever task types the user has selected at the time they are interacting with the filter.

As I'm looking at this, cognitively, I find it weird that the counter shows 200 articles even when all topics are deselected. The 200 count is correct because it queries by the task types I have selected, but we might want to think about hiding the article counter until the user selects some topics.

Change 563453 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Add topic filters dialog

https://gerrit.wikimedia.org/r/563453

Change 563453 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Add topic filters dialog

https://gerrit.wikimedia.org/r/563453

Change 564000 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Expand filters if below the fold item is checked

https://gerrit.wikimedia.org/r/564000

Change 564007 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Fix button label from done state

https://gerrit.wikimedia.org/r/564007

Change 564000 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Expand filters if below the fold item is checked

https://gerrit.wikimedia.org/r/564000

Change 564007 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Fix button label from done state

https://gerrit.wikimedia.org/r/564007

The only exception is that whereas the intro overlay updated the article count based on the default difficulty level settings for user initiating suggested edits, this filter dialog should update the article count based on whichever task types the user has selected at the time they are interacting with the filter.

As I'm looking at this, cognitively, I find it weird that the counter shows 200 articles even when all topics are deselected. The 200 count is correct because it queries by the task types I have selected, but we might want to think about hiding the article counter until the user selects some topics.

Interesting, to me "200 articles found" when no topic filters have been selected, make sense actually for two reason - first, because there is a difficulty level is always selected and, and ssecondly, by selecting a topic, users narrow the search since there are articles that do not belong to any topic.
For example - the difficulty level: Easy, the option is selected: "Přidání odkazů mezi články", no topics are selected - the number of fetched articles is 41 (cswiki betalabs) Add to the criteria all topics, the number of articles will be 26. However, it'd be great to hear user feedback on whether the filter logic is clear.

Several things to consider

  • On desktop when "show more" is no clicked, the dialog size is smaller than in the mockup

Thanks, @Etonkovidova. Since you filed two of the issues separately, I'm putting this back in Ready for Development to address the middle issue about the size of the dialog. Here it is side-by-side:

mockupbeta

The dialog should be a consistent size, matching the size of the difficulty filter dialog.

kostajh removed kostajh as the assignee of this task.Wed, Jan 15, 11:22 AM

The dialog should be a consistent size, matching the size of the difficulty filter dialog.

That's not trivial to do, if you mean that you want both dialogs to have the same height. Both dialogs need to be able to vary their height depending on the contents, which will vary by language. So we'd need to calculate the necessary height for the difficulty filter dialog before opening the topic filter dialog, and vice versa.

If you want to enforce a minimum height for both, that is doable but at the cost of unnecessary whitespace (as is shown in the mockup). That's a lot easier to do though. Which would you prefer?

@kostajh -- I prefer the minimum height route, which @RHo deliberately included in the mockup. I'm not sure what the minimum height should be, though, so perhaps you can choose. But in general we want it to be something like the default height of the difficulty filter dialog.

Tgr added a comment.Wed, Jan 15, 11:13 PM

Do we really care about the difficulty and topic dialogs being the same size, or is it just that the topic dialog should be tall enough to not change when the user clicks "show more"? That seems a lot easier.

@Tgr -- I talked to another designer, who thinks that this size thing is not actually a big deal. I'll pass this along to design review and @RHo can double-check when she's back.

MMiller_WMF assigned this task to RHo.Fri, Jan 24, 12:00 AM