I think that because of two issues, we have been undercounting successful suggested edits. I detail the two issues below with examples from Vietnamese Wikipedia, which will hopefully help us look into them.
I have been using the connection between the homepagemodule and editattemptstep schemas to count successful suggested edits. Basically, if a se-task-click event in homepagemodule joins to a saveSuccess event in editattemptstep on homepage_pageview_token = editing_session_id, that's a successful suggested edit. I wrote this code before we had the edit tag for "Newcomer task". Now that we have the tag, I am seeing edits in the recent changes feeds of our target wikis that are not showing up in my reporting. Digging into this, it looks like: (a) many edits are not showing up in editattemptstep and (b) the link between the two tables is not always present. This is causing us to undercount in the reporting by a substantial amount.
Maybe these aren't bugs -- maybe they're a difference in how EventLogging does things vs. edit tags, but I think it is important to sort this out so that we can correctly report on the impact of the feature.
For edits that have the "Newcomer task" tag, only some of them are in editattemptstep
When I look at all the edits that have the "Newcomer task" tag in Vietnamese Wikipedia, I see 13 revisions:
select ct_rev_id from change_tag where ct_tag_id = 75 limit 100;
Then when I go to look for those revisions as "saveSuccess" events in editattemptstep, I only see six of them:
select eas.event.revision_id from event.editattemptstep eas where year in (2019,2020) and eas.wiki = 'viwiki' and eas.event.action = 'saveSuccess' and eas.event.revision_id in (57066339,57099167,57163867,57206739,57227444,57227455,57274969,57322195,57322605,57401587,57401627,57426233,57426284) group by eas.event.revision_id;
For edits that are in editattemptstep, not all of them link correctly back to homepagemodule
Taking the same set of six revisions from above, and looking at their editing_session_ids in the editattempstep schema, we can see that two of them (57322195 and 57426284) do not have the 33-character IDs that match to homepage_pageview_tokens in the homepagemodule schema. Instead, they have "classic" 21 character IDs.