Page MenuHomePhabricator

QA VE with new header and collapsible sidebar
Closed, ResolvedPublic

Description

Background

As a part of the desktop improvements project, we would like to ensure that the changes we are making do not cause any bugs to the Visual Editor, in particular in terms of fixed width. This task is to QA VE along with the first two changes we are making.

Acceptance criteria

  • Test VE with fixed width and collapsible sidebar
  • Document results
  • Document any bugs noticed

QA Results - Beta

ACStatusDetails
1T250375#6317182
2T250375#6317182
3T250375#6317182

Related Objects

Event Timeline

ovasileva added a project: Readers-Web-Backlog.
ovasileva added subscribers: Edtadros, ppelberg.

@Edtadros - moving this to the backlog so we don't forget it. This will be additional QA we'll want to do for VE prior to deploying to the test wikis.

@ovasileva It would be useful to tag this task along with the tasks that might impact it (the first two changes from the description).

@Edtadros: yesterday, @ovasileva and I talked about the testing y'all are planning to do in VE (this ticket) and I shared with Olga that I'd like to check with the Editing Team's engineers and QA about what they think is important to test.[i] Here is what they shared...

They recommended a thorough test [ii] of the VE, while paying special attention to the following:

  • How elements on the page adapt to the window being resized. Examples:
    • Images
    • Tables
    • Galleries
  • How dialogs adapt to the window being resized. Examples:
    • References dialog
    • Citation dialog
    • Link dialog
    • Image dialog
  • How the toolbar will be presented at the max width:
    • We assume this QA will be limited to testing in the languages these changes will be deployed in (French, Korean, Hebrew, Persian, Portuguese and Serbian).
    • However, if it's broader than that and testing will happen in more languages than those listed above, the page linked below might be helpful for prioritizing which languages to test the toolbar in. That page contains screenshots of how the toolbar behaves at its current 990px width. We figured it might be helpful to know which languages the toolbar is close to overflowing in (e.g. ml) and thus most likely to be affected by the new max width being 960px:

i. We assume this is stuff y'all already had in mind, just sharing here so there's no ambiguity! We appreciate you including this testing as part of y'alls work.
ii. As to what a "thorough test" might involve, feel free to follow up with @Ryasmeen about what they see this involving...Rummana and I talked about this and she is happy to help should you need it.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA steps

✅ AC1: How elements on the page adapt to the window being resized for images, tables, and galleries.

HebrewPersianEnglishFrenchKoreanPortugueseSerbian
Michael Milberger - Wikipedia-min.gif (480×586 px, 3 MB)
عبدالکریم سروش - ویکی_پدیا.gif (480×526 px, 3 MB)
Editing Table - Wikipedia, the free encyclopedia.gif (480×524 px, 3 MB)
Modification de Test Page for VE_RW — Wikipedia (2).gif (480×526 px, 3 MB)
Test Page for VE_RW 편집하기 - Wikipedia.gif (480×504 px, 2 MB)
A editar Test Page for VE_RW - Wikipedia.gif (480×516 px, 3 MB)
Test Page for VE_RW — уређивање — Wikipedia.gif (480×582 px, 3 MB)

❌ AC2: How dialogs adapt to the window being resized. Examples:

HebrewPersianEnglishFrenchKoreanPortugueseSerbian
References dialog
Citation dialog
Link dialog
Image dialog

Citation Dialog bug for all languages:

Screen Shot 2020-07-18 at 8.12.30 PM.png (623×798 px, 131 KB)

Language Dialog bug for all languages above:

Screen Shot 2020-07-18 at 8.13.18 PM.png (623×798 px, 123 KB)

✅ AC3: How the toolbar will be presented at the max width 960px:

SidebarHebrewPersianEnglishFrenchKoreanPortugueseSerbian
Collapsed
Screen Shot 2020-07-18 at 11.28.33 AM.png (1×957 px, 436 KB)
Screen Shot 2020-07-18 at 11.39.40 AM.png (1×957 px, 573 KB)
Screen Shot 2020-07-16 at 11.23.39 PM.png (1×962 px, 579 KB)
Screen Shot 2020-07-18 at 7.58.39 PM.png (1×957 px, 201 KB)
Screen Shot 2020-07-18 at 8.03.23 PM.png (1×957 px, 195 KB)
Screen Shot 2020-07-18 at 8.04.40 PM.png (1×957 px, 206 KB)
Screen Shot 2020-07-18 at 8.05.54 PM.png (1×957 px, 200 KB)
Expanded
Screen Shot 2020-07-18 at 11.28.39 AM.png (1×957 px, 448 KB)
Screen Shot 2020-07-18 at 11.39.51 AM.png (1×957 px, 588 KB)
Screen Shot 2020-07-18 at 11.26.19 AM.png (1×957 px, 203 KB)
Screen Shot 2020-07-18 at 7.58.45 PM.png (1×957 px, 245 KB)
Screen Shot 2020-07-18 at 8.03.31 PM.png (1×957 px, 228 KB)
Screen Shot 2020-07-18 at 8.04.47 PM.png (1×957 px, 247 KB)
Screen Shot 2020-07-18 at 8.06.05 PM.png (1×957 px, 242 KB)
Edtadros updated the task description. (Show Details)

@Edtadros - for the citation dialog, this is expected behavior. See below:

Screen Shot 2020-07-19 at 11.37.53 AM.png (1×1 px, 576 KB)

Screen Shot 2020-07-19 at 11.37.13 AM.png (1×2 px, 854 KB)

Screen Shot 2020-07-19 at 11.37.26 AM.png (1×2 px, 1007 KB)

T258501: [Bug] Pokey arrow on VE citation and link dialogs not rendering correctly opened to reflect the citation and link dialog arrow issues found above. Resolving this.