Page MenuHomePhabricator
Create Task
Maniphest T253216

Undeploy Extension:Listings from Wikimedia Production
Closed, ResolvedPublic
Actions

Description

The Listings extension is used on Wikimedia on Wikivoyages only.

According to its own description at https://www.mediawiki.org/wiki/Extension:Listings#Deprecation the extension's functionality can be achieved using standard templates. Some Wikivoyages such as de.wikivoyage (T206102) and it.wikivoyage (T253096) have removed or are in the process or removing the extension. On other Wikivoyages such as es.wikivoyage, looking for insource:/\<(buy|do|drink|eat|listing|see|sleep)/ (same search @MaxSem performed back in the days (T206102#4825809) returned zero results.

The extension maintenance over the past 5 years are mostly build updates.

If this extension is deprecated and unused in our Wikivoyages we should have it undeployed from Production. Do we have a standard plan for this kind of operations?

Adding @RolandUnger as listed extension author on mediawiki.org.

Thank you.

Adenda: Results of insource:/\<(buy|do|drink|eat|listing|see|sleep)/ across the Wikivoyage editions where the extension is still installed for NS_MAIN as of 2023-12-04 21:17 (UTC).

  • pl: 0 uses
  • ro: 7 uses
  • uk: 0 uses
  • zh: 0 use

Details

SubjectRepoBranchLines +/-
Undeploy Listings extension part IIIoperations/mediawiki-configmaster+0 -1
Undeploy listing extension part IIoperations/mediawiki-configmaster+0 -14
Undeploy Listings extension, part Ioperations/mediawiki-configmaster+0 -1
Disable Listings extension everywhere except rowikivoyageoperations/mediawiki-configmaster+0 -3
Disable listings extension in more wikisoperations/mediawiki-configmaster+4 -12
[Listings] Move to Wikimedia Legacytranslatewikimaster+1 -1
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
Stop branching Listings extensionrepos/releng/release!56ladsgroupundeploy_listingsmain
Customize query in GitLab

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2020, 11:29 AM
RhinosF1 subscribed.May 20 2020, 11:30 AM
MarcoAurelio updated the task description. (Show Details)May 20 2020, 6:15 PM
CptViraj subscribed.May 24 2020, 4:11 PM
MarcoAurelio mentioned this in T254820: Undeploy Listings extension from English Wikivoyage.Jun 9 2020, 9:10 AM
Andyrom75 subscribed.Jun 9 2020, 10:22 AM

IMHO it could worth to clean all the other NSs, not only the main one.

RhinosF1 added a subtask: T254820: Undeploy Listings extension from English Wikivoyage.Jun 9 2020, 10:23 AM
Jdforrester-WMF closed subtask T254820: Undeploy Listings extension from English Wikivoyage as Resolved.Jun 15 2020, 10:13 AM
Aklapper removed a parent task: T106123: Extensions needing to be removed from Wikimedia wikis.Jun 24 2020, 7:29 AM
Aklapper added subtasks: T206102: Undeploy the Listings extension on German Wikivoyage, T253096: Undeploy Insider and Listings extensions from Italian Wikivoyage.
Aklapper added a parent task: T106123: Extensions needing to be removed from Wikimedia wikis.Jun 24 2020, 7:32 AM
Nintendofan885 subscribed.Oct 26 2020, 1:54 PM
TheresNoTime removed a subscriber: RhinosF1.Dec 15 2022, 11:36 PM
Frostly subscribed.Aug 21 2023, 1:43 PM
Ladsgroup subscribed.Dec 3 2023, 10:05 PM

nlwiki is now down to only 16 cases after a ping in their VP \o/ I'll go and hunt down other wikis so we can call this done soon.

Jdforrester-WMF subscribed.Dec 4 2023, 5:05 PM
Jdforrester-WMF updated the task description. (Show Details)Dec 4 2023, 9:30 PM
Jdforrester-WMF closed subtask T352696: Undeploy Listings extension from Dutch Wikivoyage as Resolved.Dec 5 2023, 9:17 PM
Jdforrester-WMF closed subtask T352719: Undeploy the Listings extension on 7 Wikivoyages on which it's entirely unused as Resolved.
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Dec 5 2023, 9:21 PM

Change 980495 had a related patch set uploaded (by Raimond Spekking; author: Raimond Spekking):

[translatewiki@master] [Listings] Move to Wikimedia Legacy

https://gerrit.wikimedia.org/r/980495

gerritbot added a project: Patch-For-Review.Dec 5 2023, 9:21 PM
gerritbot added a comment.Dec 5 2023, 9:24 PM

Change 980495 merged by jenkins-bot:

[translatewiki@master] [Listings] Move to Wikimedia Legacy

https://gerrit.wikimedia.org/r/980495

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2023, 9:30 PM
Tommy_Kronkvist subscribed.Dec 8 2023, 7:34 AM
Tgr mentioned this in T272937: Make Listings extension compatible with Parsoid.Dec 11 2023, 5:44 PM
Tommy_Kronkvist added a comment.Dec 15 2023, 1:25 AM

I've now removed all instances of the Listings extension from the Swedish Wikivoyage: please see these sv.Voy query results: (buy|do|drink|eat|listing|see|sleep|stay).

Ladsgroup added a comment.Dec 15 2023, 1:02 PM

That's amazing! Thank you

Tommy_Kronkvist added a comment.Dec 16 2023, 6:03 AM

By the way, as you may have seen in the search string I linked to above, the Swedish Wikivoyage had also implemented a <stay> tag, on top of the standard <buy>, <do>, <drink>, <eat>, <listing>, <see> and <sleep> ones. I've search for <stay> in the other language versions of Wikivoyage listed above (el, fi, fr, pl, pt, ro, ru, uk, zh) and as far as I can tell it's not used there. (Slight reservation for the Chinese, Russian and Ukrainian language versions since they don't use Latin script – however I guess their code strings should still be in English?)

Shizhao added a project: User-notice.Dec 18 2023, 2:53 AM
Frostly added a comment.EditedDec 18 2023, 3:20 AM

I've removed the tags from zhwikivoyage :)

Aklapper added a subscriber: Shizhao.Dec 18 2023, 12:16 PM

@Shizhao: Why?

Ladsgroup added a comment.Dec 19 2023, 2:13 PM

Thank you @Frostly and @Tommy_Kronkvist! It's awesome. With this, it's basically only Polish Wikivoyage left.

Ladsgroup updated the task description. (Show Details)Dec 19 2023, 7:39 PM
Ladsgroup added a comment.Dec 19 2023, 7:42 PM
In T253216#9411940, @Frostly wrote:

I've removed the tags from zhwikivoyage :)

In the same page, there are a couple of <see> left, would you mind getting them done too so I can disable it in zhwikivoyage? Thank you!

Ladsgroup updated the task description. (Show Details)Dec 19 2023, 8:19 PM
Ladsgroup updated the task description. (Show Details)Dec 19 2023, 8:27 PM
Ladsgroup updated the task description. (Show Details)Dec 19 2023, 8:33 PM
Ladsgroup updated the task description. (Show Details)Dec 19 2023, 8:49 PM
gerritbot added a comment.Dec 19 2023, 8:53 PM

Change 984277 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Disable listings extension in more wikis

https://gerrit.wikimedia.org/r/984277

gerritbot added a project: Patch-For-Review.Dec 19 2023, 8:53 PM
gerritbot added a comment.Dec 19 2023, 9:30 PM

Change 984277 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable listings extension in more wikis

https://gerrit.wikimedia.org/r/984277

Stashbot added a comment.Dec 19 2023, 9:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-19T21:31:27Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:984277|Disable listings extension in more wikis (T253216)]]

Stashbot added a comment.Dec 19 2023, 9:32 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-19T21:32:53Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:984277|Disable listings extension in more wikis (T253216)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Dec 19 2023, 9:39 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-19T21:39:10Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:984277|Disable listings extension in more wikis (T253216)]] (duration: 07m 42s)

Maintenance_bot removed a project: Patch-For-Review.Dec 19 2023, 10:30 PM
Ladsgroup updated the task description. (Show Details)Dec 22 2023, 4:13 PM
Quiddity removed a project: User-notice.Jan 4 2024, 7:38 PM
Quiddity subscribed.

Removing User-notice as that is only for Tech News, and we try to avoid global announcements for things that only affect a handful of wikis. Please contact the those wikis directly, instead. Thanks!

Quiddity unsubscribed.Jan 4 2024, 7:39 PM
Ladsgroup updated the task description. (Show Details)Jan 7 2024, 9:46 PM
Ladsgroup updated the task description. (Show Details)Jan 7 2024, 10:20 PM
Ladsgroup updated the task description. (Show Details)Jan 7 2024, 10:23 PM
gerritbot added a comment.Jan 8 2024, 11:26 AM

Change 988460 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Disable Listings extension everywhere except rowikivoyage

https://gerrit.wikimedia.org/r/988460

gerritbot added a project: Patch-For-Review.Jan 8 2024, 11:26 AM
gerritbot added a comment.Jan 8 2024, 11:48 AM

Change 988460 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable Listings extension everywhere except rowikivoyage

https://gerrit.wikimedia.org/r/988460

Stashbot added a comment.Jan 8 2024, 11:48 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T11:48:14Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:988460|Disable Listings extension everywhere except rowikivoyage (T253216)]]

Stashbot added a comment.Jan 8 2024, 11:50 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T11:50:01Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:988460|Disable Listings extension everywhere except rowikivoyage (T253216)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 8 2024, 11:56 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T11:56:58Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:988460|Disable Listings extension everywhere except rowikivoyage (T253216)]] (duration: 08m 43s)

Ladsgroup added a comment.Jan 8 2024, 11:58 AM

Over the past couple of days I migrated zh, uk, and pl via this script:

from bs4 import BeautifulSoup
soup = BeautifulSoup(aaa)
attr_to_arg_mapping = {
    'name': 'name',
    'alt': 'alt',
    'address': 'address',
    'directions': 'directions',
    'phone': 'phone',
    'email': 'email',
    'fax': 'fax',
    'url': 'url',
    'checkin': 'checkin',
    'checkout': 'checkout',
    'lat': 'lat',
    'long': 'long',
    'tags': 'tags',
    'tollfree': 'tollfree',
    'hours': 'hours',
    'price': 'price'
}
tag_names = [
    'buy', 'do', 'drink', 'eat', 'listing', 'see', 'sleep'
]
for tag_name in tag_names:
    for case in soup.find_all(tag_name):
        text = '{{Listing|type=' + tag_name
        for attr_name in attr_to_arg_mapping:
            if case.attrs.get(attr_name):
                if '=' in case[attr_name] or '|' in case[attr_name]:
                    continue
                text += '|' + attr_to_arg_mapping[attr_name] + ' = ' +  case[attr_name]
        if ' '.join(case.find_all(text=True)):
            text += '|description = ' + ' '.join(case.find_all(text=True))
        text += '}}'
        case.replace_with(text)
print(soup)

Now only rowikivoyage left with seven pages but the wiki doesn't even have a listing template to migrate too. I tried raw wikitext but it's quite a mess.

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2024, 12:30 PM
Ladsgroup added a comment.Jan 8 2024, 3:32 PM

Okay, I managed to fix Romanian as well, via a fun trick: Copy it to google docs and then copy it back to VE. It strips out links but it's much easier to clean up and fix than doing it one by one. This is done. About to undeploy the extension now.

gerritbot added a comment.Jan 8 2024, 3:33 PM

Change 988654 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Undeploy Listings extension, part I

https://gerrit.wikimedia.org/r/988654

gerritbot added a project: Patch-For-Review.Jan 8 2024, 3:33 PM
gerritbot added a comment.Jan 8 2024, 3:38 PM

Change 988654 merged by jenkins-bot:

[operations/mediawiki-config@master] Undeploy Listings extension, part I

https://gerrit.wikimedia.org/r/988654

Stashbot added a comment.Jan 8 2024, 3:38 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T15:38:53Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:988654|Undeploy Listings extension, part I (T253216)]]

Stashbot added a comment.Jan 8 2024, 3:40 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T15:40:18Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:988654|Undeploy Listings extension, part I (T253216)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 8 2024, 3:47 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T15:47:15Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:988654|Undeploy Listings extension, part I (T253216)]] (duration: 08m 22s)

gerritbot added a comment.Jan 8 2024, 3:47 PM

Change 988655 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Undeploy listing extension part II

https://gerrit.wikimedia.org/r/988655

gerritbot added a comment.Jan 8 2024, 3:49 PM

Change 988655 merged by jenkins-bot:

[operations/mediawiki-config@master] Undeploy listing extension part II

https://gerrit.wikimedia.org/r/988655

Stashbot added a comment.Jan 8 2024, 3:49 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T15:49:41Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:988655|Undeploy listing extension part II (T253216)]]

gerritbot added a comment.Jan 8 2024, 3:51 PM

Change 988658 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Undeploy Listings extension part III

https://gerrit.wikimedia.org/r/988658

Stashbot added a comment.Jan 8 2024, 3:51 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T15:51:18Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:988655|Undeploy listing extension part II (T253216)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 8 2024, 3:58 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T15:58:21Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:988655|Undeploy listing extension part II (T253216)]] (duration: 08m 40s)

gerritbot added a comment.Jan 8 2024, 4:00 PM

Change 988658 merged by jenkins-bot:

[operations/mediawiki-config@master] Undeploy Listings extension part III

https://gerrit.wikimedia.org/r/988658

Stashbot added a comment.Jan 8 2024, 4:01 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T16:01:00Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]]

Stashbot added a comment.Jan 8 2024, 4:14 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T16:14:40Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

CodeReviewBot added a comment.Jan 8 2024, 4:16 PM

ladsgroup opened https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/56

Stop branching Listings extension

CodeReviewBot added a comment.Jan 8 2024, 4:19 PM

jforrester merged https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/56

Stop branching Listings extension

Stashbot added a comment.Jan 8 2024, 4:25 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T16:25:07Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]] (duration: 24m 06s)

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2024, 4:31 PM
Stashbot added a comment.Jan 8 2024, 4:41 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T16:41:06Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]]

Stashbot added a comment.Jan 8 2024, 4:42 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T16:42:47Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 8 2024, 4:49 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T16:49:53Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]] (duration: 08m 47s)

Stashbot added a comment.Jan 8 2024, 4:51 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T16:51:44Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]]

Stashbot added a comment.Jan 8 2024, 4:53 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T16:53:16Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 8 2024, 5:04 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T17:04:08Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]] (duration: 12m 24s)

Stashbot added a comment.Jan 8 2024, 5:04 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T17:04:39Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]]

Stashbot added a comment.Jan 8 2024, 5:06 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T17:06:08Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 8 2024, 5:12 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T17:12:40Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:988658|Undeploy Listings extension part III (T253216)]] (duration: 08m 01s)

Ladsgroup closed this task as Resolved.Jan 8 2024, 5:22 PM
Ladsgroup claimed this task.

One more extension without even one line of test is now gone.

Aklapper awarded a token.Jan 9 2024, 10:09 AM
ihurbain mentioned this in T352443: Come up with a porting plan for the Listing extension.Jan 12 2024, 9:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL