1.35.0-wmf.39 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	thcipriani
	Jun 1 2020, 4:11 PM

Details

Backup Train Conductor: • mmodell
Release Version: 1.35.0-wmf.39
Release Date: Jun 29 2020, 12:00 AM

2020 week 27 1.35-wmf.39 Changes wmf/1.35.0-wmf.39

This MediaWiki Train Deployment is scheduled for the week of Monday, June 29th:

Monday June 29th	Tuesday, June 30th	Wednesday, July 1st	Thursday, July 2nd	Friday
Backports only.	Branch `wmf.39` and deploy to Group 0 Wikis.	Deploy `wmf.39` to Group 1 Wikis.	Deploy `wmf.39` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.39 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.35.0-wmf.38

Next: 1.35.0-wmf.40

	Subject	Repo	Branch	Lines +/-
	Branch commit for wmf/1.35.0-wmf.39	mediawiki/core	wmf/1.35.0-wmf.39	+946 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	hashar	T254176 1.35.0-wmf.39 deployment blockers
Resolved		DannyS712	T256298 TypeError from line 27 of /srv/mediawiki/tags/2020-06-24_17:40:57/extensions/Thanks/includes/ThanksHooks.php: Argument 1 passed to ThanksHooks::insertThankLink() must be an instance of MediaWiki\Revision\RevisionRecord, bool given
Resolved	PRODUCTION ERROR	• Demian	T256761 1.35.0-wmf.39 breaks Flow

Event Timeline

thcipriani created this task.Jun 1 2020, 4:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2020, 4:11 PM

thcipriani assigned this task to hashar.Jun 1 2020, 4:22 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: • mmodell.

thcipriani added a project: Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)) board.

Nikerabbit added a subtask: T256298: TypeError from line 27 of /srv/mediawiki/tags/2020-06-24_17:40:57/extensions/Thanks/includes/ThanksHooks.php: Argument 1 passed to ThanksHooks::insertThankLink() must be an instance of MediaWiki\Revision\RevisionRecord, bool given.Jun 24 2020, 6:46 PM

DannyS712 closed subtask T256298: TypeError from line 27 of /srv/mediawiki/tags/2020-06-24_17:40:57/extensions/Thanks/includes/ThanksHooks.php: Argument 1 passed to ThanksHooks::insertThankLink() must be an instance of MediaWiki\Revision\RevisionRecord, bool given as Resolved.Jun 25 2020, 11:18 AM

Change 608499 had a related patch set uploaded (by DannyS712; owner: trainbranchbot):
[mediawiki/core@wmf/1.35.0-wmf.39] Branch commit for wmf/1.35.0-wmf.39

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608499

gerritbot added a project: Patch-For-Review.Jun 30 2020, 2:06 AM

Mentioned in SAL (#wikimedia-operations) [2020-06-30T08:10:38Z] <hashar> 1.35.0-wmf.39 was branched at e169e3dabcb2217809fc41ba44b43a39ae1a678e T254176

Change 608499 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.39] Branch commit for wmf/1.35.0-wmf.39

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608499

hashar mentioned this in T248947: img_auth.php may leak private extension images into the public cache (CVE-2020-15005).Jun 30 2020, 8:50 AM

Mentioned in SAL (#wikimedia-operations) [2020-06-30T08:51:55Z] <hashar> Applied security patches to wmf/1.35.0-wmf.39 # T254176

Mentioned in SAL (#wikimedia-operations) [2020-06-30T10:30:54Z] <hashar@deploy1001> Synchronized php-1.35.0-wmf.39/includes/specials/SpecialUndelete.php: Remove another use of PageArchive::getRevision - T249982 T254176 (duration: 00m 56s)

1.35.0-wmf.39 is now on testwiki: https://test.wikipedia.org/wiki/Special:Version

1.35.0-wmf.39 is now on group0 wikis.

Mentioned in SAL (#wikimedia-operations) [2020-06-30T14:43:45Z] <hashar> Train blocked on Flow being broken: T256761 # T254176

Stashbot mentioned this in T256761: 1.35.0-wmf.39 breaks Flow.Jun 30 2020, 2:44 PM

Ladsgroup subscribed.Jun 30 2020, 2:45 PM

Ammarpad closed subtask T256761: 1.35.0-wmf.39 breaks Flow as Resolved.Jun 30 2020, 6:24 PM

Mentioned in SAL (#wikimedia-operations) [2020-06-30T19:19:23Z] <hashar@deploy1001> rebuilt and synchronized wikiversions files: group 0 wikis to 1.35.0-wmf.39 # T254176

1.35.0-wmf.39 is on group 1 wikis:

13:16 	<hashar@deploy1001> 	Synchronized php: group1 wikis to 1.35.0-wmf.39 (duration: 01m 04s)

There is no new error showing and the performance metrics looks good.

Change 608937 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group2 wikis to 1.35.0-wmf.39 refs T254176

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/ /608937

Change 608937 merged by jenkins-bot:
[operations/mediawiki-config@master] group2 wikis to 1.35.0-wmf.39 refs T254176

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/ /608937

Mentioned in SAL (#wikimedia-operations) [2020-07-01T19:18:22Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group2 wikis to 1.35.0-wmf.39 refs T254176

Mentioned in SAL (#wikimedia-operations) [2020-07-01T19:23:37Z] <twentyafterfour> 1.35.0-wmf.39 is now deployed to group2 wikis, everything appears to be normal. refs T254176

Krinkle added a subtask: T256922: {{SUBPAGENAME}} no longer returning the title for pages without subpages.Jul 1 2020, 10:04 PM

Krinkle removed a subtask: T256922: {{SUBPAGENAME}} no longer returning the title for pages without subpages.Jul 1 2020, 11:21 PM

This is complete. Thank you for the quick fixes on T256298 T256761 and for the logspam triage on wednesday just before group2.

1.35.0-wmf.39 deployment blockersClosed, ResolvedPublicReleaseActions