1.35.0-wmf.40 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor: Jdforrester-WMF
Release Version: 1.35.0-wmf.40
Release Date: Jul 6 2020, 12:00 AM

2020 week 28 1.35-wmf.40 Changes wmf/1.35.0-wmf.40

This MediaWiki Train Deployment is scheduled for the week of Monday, July 6th:

Monday July 6th	Tuesday, July 7th	Wednesday, July 8th	Thursday, July 9th	Friday
Backports only.	Branch `wmf.40` and deploy to Group 0 Wikis.	Deploy `wmf.40` to Group 1 Wikis.	Deploy `wmf.40` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.40 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.35.0-wmf.39

Next: 1.35.0-wmf.41

	Subject	Repo	Branch	Lines +/-
	Branch commit for wmf/1.35.0-wmf.40	mediawiki/core	wmf/1.35.0-wmf.40	+956 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	• mmodell	T256668 1.35.0-wmf.40 deployment blockers
Resolved		daniel	T256922 {{SUBPAGENAME}} no longer returning the title for pages without subpages
Resolved	PRODUCTION ERROR	Lucas_Werkmeister_WMDE	T257296 Beta cluster wikidata fails to load scripts with "OutOfBoundsException from line 60 of /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/SettingsArray.php: Attempt to get non-existing setting "repoScriptPath"
Resolved		Lucas_Werkmeister_WMDE	T257334 Remove \Wikibase\Lib\Settings

Event Timeline

thcipriani created this task.Jun 29 2020, 5:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2020, 5:59 PM

thcipriani assigned this task to • mmodell.Jun 29 2020, 7:16 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: Jdforrester-WMF.

thcipriani added a project: Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)) board.

Krinkle added a subtask: T256922: {{SUBPAGENAME}} no longer returning the title for pages without subpages.Jul 1 2020, 10:07 PM

DannyS712 added a subtask: T232568: Special:UserRights exposes the existence of hidden users (CVE-2020-25813).Jul 4 2020, 2:26 PM

A little risky patch! 🚂🔥

Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/608845
What it does/What it's risky:
- This is hard-deprecating the Revision class. A lot of effort have gone into tracking down and removing all usages, but in case we've missed some prominent ones, there would be a flood of warnings in the deprecation channel* Test Plan:
- Look at the deprecation channel in logstash: https://logstash.wikimedia.org/app/kibana#/dashboard/mediawiki-deprecated
Revert Plan: in case found on smaller groups, ping @DannyS712 or Platform Engineering and we will try to quick-fix the problem. In case too much logspam - revert. I will leave the judgement of what is too much logspam to you.

DannyS712 removed a subtask: T232568: Special:UserRights exposes the existence of hidden users (CVE-2020-25813).Jul 6 2020, 6:15 PM

Krinkle closed subtask T256922: {{SUBPAGENAME}} no longer returning the title for pages without subpages as Resolved.Jul 6 2020, 7:23 PM

Change 609892 had a related patch set uploaded (by DannyS712; owner: trainbranchbot):
[mediawiki/core@wmf/1.35.0-wmf.40] Branch commit for wmf/1.35.0-wmf.40

https://gerrit.wikimedia.org/r/609892

gerritbot added a project: Patch-For-Review.Jul 7 2020, 4:04 AM

Mentioned in SAL (#wikimedia-operations) [2020-07-07T09:24:29Z] <James_F> 1.35.0-wmf.40 was branched at 88ecd6df00a46e432c06c1cf40d5098128abc4d8 for T256668

Change 609892 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.40] Branch commit for wmf/1.35.0-wmf.40

https://gerrit.wikimedia.org/r/609892

Mentioned in SAL (#wikimedia-operations) [2020-07-07T11:39:19Z] <jforrester@deploy1001> Started scap: Full scap and testwikis to 1.35.0-wmf.40 for T256668

Mentioned in SAL (#wikimedia-operations) [2020-07-07T12:12:28Z] <jforrester@deploy1001> Finished scap: Full scap and testwikis to 1.35.0-wmf.40 for T256668 (duration: 33m 09s)

Two scaps and forty minutes later, testwikis seem initially fine (though there was an old gadget, InterProjectLinks, which was visibly broken and unmaintained, so I killed it).

Jdforrester-WMF added a subtask: T257296: Beta cluster wikidata fails to load scripts with "OutOfBoundsException from line 60 of /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/SettingsArray.php: Attempt to get non-existing setting "repoScriptPath".Jul 7 2020, 12:23 PM

Naturally, spoke too soon. :-(

taavi removed a subtask: T257296: Beta cluster wikidata fails to load scripts with "OutOfBoundsException from line 60 of /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/SettingsArray.php: Attempt to get non-existing setting "repoScriptPath".Jul 7 2020, 4:47 PM

taavi subscribed.Jul 7 2020, 5:16 PM

Change 610141 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.40 refs T256668

https://gerrit.wikimedia.org/r/610141

Change 610141 merged by jenkins-bot:
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.40 refs T256668

https://gerrit.wikimedia.org/r/610141

Mentioned in SAL (#wikimedia-operations) [2020-07-07T19:18:35Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group0 wikis to 1.35.0-wmf.40 refs T256668

No sign of deprecation warnings for the revision class. I only see deprecation warnings for these two:

Article::getContentModel
Article::prepareContentForEdit

Lucas_Werkmeister_WMDE added a subtask: T257296: Beta cluster wikidata fails to load scripts with "OutOfBoundsException from line 60 of /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/SettingsArray.php: Attempt to get non-existing setting "repoScriptPath".Jul 8 2020, 8:04 AM

Lucas_Werkmeister_WMDE closed subtask T257296: Beta cluster wikidata fails to load scripts with "OutOfBoundsException from line 60 of /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/SettingsArray.php: Attempt to get non-existing setting "repoScriptPath" as Resolved.

Change 610350 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.40 refs T256668

https://gerrit.wikimedia.org/r/610350

Change 610350 merged by jenkins-bot:
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.40 refs T256668

https://gerrit.wikimedia.org/r/610350

Mentioned in SAL (#wikimedia-operations) [2020-07-08T19:17:54Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group1 wikis to 1.35.0-wmf.40 refs T256668

Mentioned in SAL (#wikimedia-operations) [2020-07-08T19:18:58Z] <twentyafterfour@deploy1001> Synchronized php: group1 wikis to 1.35.0-wmf.40 refs T256668 (duration: 01m 04s)

Change 610904 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] all wikis to 1.35.0-wmf.40 refs T256668

https://gerrit.wikimedia.org/r/610904

Change 610904 merged by jenkins-bot:
[operations/mediawiki-config@master] all wikis to 1.35.0-wmf.40 refs T256668

https://gerrit.wikimedia.org/r/610904

Mentioned in SAL (#wikimedia-operations) [2020-07-09T19:05:47Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: all wikis to 1.35.0-wmf.40 refs T256668

Let's call this one done.

FTR, T257625: Interwiki sorting broken seems to be new with wmf.40, but I don’t think it’s bad enough to justify rolling back the train.

1.35.0-wmf.40 deployment blockersClosed, ResolvedPublicReleaseActions