Page MenuHomePhabricator

Switch test wikis to new version of vector by default
Closed, ResolvedPublic5 Estimated Story Points

Description

NOTE: this is blocked until development and instrumentation of the collapsible sidebar & max-width is complete. It is blocked on T254228 being resolved first.

Background

After building out our collapsible sidebar and fixed width for articles, we will be ready to make our first deployment to our test wikis. We will do this in two steps to allow for sufficient QA. To learn more about our release plan, please see our project page: https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Opting_in_and_Release_Plan

Deployment schedule

projectWed. July 22Tues. July 28Wed. July 29
euwiki (Basque Wikipedia)x
fawiki (Persian Wikipedia)x
frwiki (French Wikipedia)x
frwiktionary (French Wiktionary)x
hewiki (Hebrew Wikipedia)x
ptwikiversity (Portuguese Wikiversity)x

Note Office Wiki is already enabled by default.

Acceptance criteria

Step 1:

  • Switch the default of the following wikis to the new version of the vector skin: euwiki, frwiktionary, ptwikiversity

Step 2:

  • Switch the default of the following wikis to the new version of the vector skin:, fawiki, hewiki

Step 3

  • frwiki
  • Feature flag states:
    • Preference - on
    • Default - on
    • Sidebar closed by default - off
    • Sidebar instrumentation - on
    • Max width - on

Questions

  • If we're changing anonymous presentation, what will we do about cached HTML? Do we have to purge the whole cache?
  • Are there more changes planned that will significantly impact the HTML? For example, moving the search bar. Do the caching implications change the deployment strategy?

Event Timeline

ovasileva renamed this task from Switch test wikis to new version of vector. to Switch test wikis to new version of vector by default.Jun 2 2020, 10:07 AM
ovasileva triaged this task as High priority.
ovasileva updated the task description. (Show Details)

If we're changing anonymous presentation, what will we do about cached HTML? Do we have to purge the whole cache?

If we want to purge the whole cache we'll need to reach out to ops now.
If we're happy with some pages showing old design and some showing new, we don't need to do anything (we could perhaps mitigate that by showing a dismissable banner at the top of newly rolled out pages.

TTL is 4 days: T124954#3703453 - I suggest talking to @BBlack about whether we can clear the cache for Basque Wikipedia, French Wikipedia, French Wiktionary, Hebrew Wikipedia, Persian Wikipedia and Portuguese Wikiversity

It's my understanding that this task includes changing VectorDefaultSkinVersion to '2'. I assume VectorDefaultSkinVersionForNewAccounts should also be configured to '2' and I see that T254228 covers setting VectorShowSkinPreferences. Are there any changes wanted to VectorDefaultSkinVersionForExistingAccounts?

ovasileva set the point value for this task to 5.

Change 614890 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Switch test wikis to new version of vector by default (2/3)

https://gerrit.wikimedia.org/r/614890

Change 614891 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Switch test wikis to new version of vector by default (3/3)

https://gerrit.wikimedia.org/r/614891

Mentioned in SAL (#wikimedia-operations) [2020-07-22T11:42:00Z] <jdrewniak@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:614889|Enable desktop improvements by default for testing group (round 1) (T254227)]] (duration: 01m 05s)

We need to update the deployment schedule and coordinate with traffic for phase 2. Blocked until that's done.

Change 614890 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable desktop improvements by default for testing group (round 2)

https://gerrit.wikimedia.org/r/614890

Mentioned in SAL (#wikimedia-operations) [2020-07-28T11:10:43Z] <jdrewniak@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:614890 desktop improvements by default for testing group (round 2) (T254227)]] (duration: 01m 06s)

Change 614891 merged by jenkins-bot:
[operations/mediawiki-config@master] Switch test wikis to new version of vector by default (3/3)

https://gerrit.wikimedia.org/r/614891

Mentioned in SAL (#wikimedia-operations) [2020-08-05T11:36:02Z] <awight@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:614891|Switch test wikis to new version of vector by default (3/3) (T254227)]] (duration: 01m 07s)

Hi, using the "Download as PDF" feature on French Wikipedia, I noticed that the sidebar is included in the generated PDF, contrarily to a PDF generated on e.g. English Wikipedia.

Though not sure, I suspect it is a side effect of the changes to the sidebar.

For example, compare the PDFs generated from French and English wikis:
https://fr.wikipedia.org/w/index.php?title=Sp%C3%A9cial:DownloadAsPdf&page=Rick_Astley&action=show-download-screen
https://en.wikipedia.org/w/index.php?title=Special:DownloadAsPdf&page=Rick_Astley&action=show-download-screen