Change 628249 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] [WIP] Variant C/D welcome popup on desktop

https://gerrit.wikimedia.org/r/628249

QA instructions from the patch:

To test, switch to variant C or D, run the following snippet in the browser console, then visit the homepage:

new mw.Api().saveOptions( {
    'growthexperiments-tour-homepage-welcome': '0',
    'growthexperiments-tour-homepage-discovery': '0'
} ).done( function() { window.location.reload() } );

Change 628249 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Variant C/D welcome popup on desktop

https://gerrit.wikimedia.org/r/628249

Thanks, @kostajh for the QA instructions!

For Design review - two points need to be clarified (marked with in the task):

(1) The implementation is done exactly as in the mockups, so there are no issues with the implementation - just to confirm that all is as expected:
Both - C and D variants - have the same description for the popup:

When the user first arrives on their homepage, they will see a popup on top of the page that is pointing to their username.

and it's clarified in the following:

Basically, both Variants C-desktop and D-desktop now have a popup in the same place under the same circumstances [...]

However, the place is not the same and they point to different usernames - in variant C it's username in the title and in variant D - it's a link:

variant C	variant D

(2) Variant C

Body: "You can always click on your username to return here. Continue to learn about the suggested edits on your homepage."

Variant C has "suggested edits" in quotes - is it ok?

Additional question - variant D is supposed to display onboarding at the same time as the welcome message , e.g. from D variant mockup. I did not see it in betalabs - it could be a limitation of present testing environment, I suppose?

Moving back to address the points @Etonkovidova picked up:

In T258009#6484846, @Etonkovidova wrote:

Thanks, @kostajh for the QA instructions!

For Design review - two points need to be clarified (marked with in the task):
(1) The implementation is done exactly as in the mockups, so there are no issues with the implementation - just to confirm that all is as expected:
Both - C and D variants - have the same description for the popup:

When the user first arrives on their homepage, they will see a popup on top of the page that is pointing to their username.

and it's clarified in the following:

Basically, both Variants C-desktop and D-desktop now have a popup in the same place under the same circumstances [...]

However, the place is not the same and they point to different usernames - in variant C it's username in the title and in variant D - it's a link:

variant C	variant D

(2) Variant C

Body: "You can always click on your username to return here. Continue to learn about the suggested edits on your homepage."

Variant C has "suggested edits" in quotes - is it ok?

Yes, the task description is correct – the pop-up should appear in the same position with the callout under the username link in personal tools, but I missed updating the Zeplin mock.
Also, suggested edits should not have quotes, but be bolded.

Additional question - variant D is supposed to display onboarding at the same time as the welcome message , e.g. from D variant mockup. I did not see it in betalabs - it could be a limitation of present testing environment, I suppose?

It is supposed to display the onboarding on variant D, that's right.

Change 630322 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix variant C desktop popup positioning/messaging

https://gerrit.wikimedia.org/r/630322

Change 630322 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix variant C desktop popup positioning/messaging

https://gerrit.wikimedia.org/r/630322

For Design review - it seems that all fixes are in place.

Yes, the task description is correct – the pop-up should appear in the same position with the callout under the username link in personal tools, but I missed updating the Zeplin mock.

and

It is supposed to display the onboarding on variant D, that's right.

Done.

variant C	variant D

(2) Variant C
Also, suggested edits should not have quotes, but be bolded.

Done - however, the message is up to translation after the update (see https://translatewiki.net/wiki/Special:Translations?message=MediaWiki%3Agrowthexperiments-tour-welcome-description-c&namespace=8)

Thanks @Etonkovidova , LGTM!
Regarding the translation, I think it's OK if not all of the wikis have changed the slight formatting from 'suggested edits' to suggested edits in the message yet.

In T258009#6500190, @Etonkovidova wrote:

For Design review - it seems that all fixes are in place.

Yes, the task description is correct – the pop-up should appear in the same position with the callout under the username link in personal tools, but I missed updating the Zeplin mock.

and

It is supposed to display the onboarding on variant D, that's right.

Done.

variant C	variant D

(2) Variant C
Also, suggested edits should not have quotes, but be bolded.

Done - however, the message is up to translation after the update (see https://translatewiki.net/wiki/Special:Translations?message=MediaWiki%3Agrowthexperiments-tour-welcome-description-c&namespace=8)

This looks good to me in beta. To be resolved once it's in production.