Page MenuHomePhabricator

Split MediaSearch out into its own extension
Open, Needs TriagePublic

Description

As discussed in a recent engineering team meeting, there are several advantages to splitting MediaSearch out of WikibaseMediaInfo into its own extension:

  • We can set up Jest for front-end testing without having to deal with the existing node-qunit frameowrk in WBMI
  • We can use the opportunity to create some boilerplate code for future projects (test framework, potentially webpack config or Storybook implementation)
  • If an opportunity to use MediaSeach on another wiki comes up in the future, the code will already be modular and separate from WBMI
  • WBMI is becoming quite large and modular code will be easier to maintain going forward

Here's a rough outline of what needs to be done; I'll split some of this out into subtasks later:

  • Request a new Gerrit repo
  • Build new extension, get CR from team
  • Determine if we need security readiness review and, if so, get the ball rolling on that
  • Remove code from WBMI
  • Coordinate deployment
  • Documentation: extension page and help page on mediawiki.org, add to https://www.mediawiki.org/wiki/Developers/Maintainers

Event Timeline

AnneT created this task.Oct 19 2020, 7:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2020, 7:12 PM

Mentioned in SAL (#wikimedia-releng) [2020-10-20T22:15:08Z] <James_F> Zuul: [mediawiki/extensions/MediaSearch] Install CI for this new prod repo T265939

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

I've installed CI for this new repo; shout if you need help with anything else in the process.

Change 636499 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MediaSearch@master] [WIP] To do: - Transfer i18n messages from WBMI to this extension. Thus far, only the api files and the en and qqq main files have been copied over - Determine strategy for the above change to avoid disrupting translatewiki.net - Determine strategy for deploying, given we need to disable and eventually remove this code from WBMI to avoid conflicts

https://gerrit.wikimedia.org/r/636499

Change 636506 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] Zuul: [mediawiki/extensions/MediaSearch] Add WikibaseCirrus dep.

https://gerrit.wikimedia.org/r/636506

Change 636506 merged by jenkins-bot:
[integration/config@master] Zuul: [mediawiki/extensions/MediaSearch] Add WikibaseCirrus dep.

https://gerrit.wikimedia.org/r/636506

Mentioned in SAL (#wikimedia-releng) [2020-10-26T22:21:16Z] <James_F> Zuul: [mediawiki/extensions/MediaSearch] Add WikibaseCirrus dependency T265939