Maniphest T271919

Write tests for Extension:TheWikipediaLibrary
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Samwalton9-WMF
	Jan 13 2021, 1:26 PM

Description

Extension:TheWikipediaLibrary currently has no tests. Because this extension has code which is loaded on every page view we should ensure it has good test coverage.

Details

	Subject	Repo	Branch	Lines +/-
	Add tests for the extension	mediawiki/extensions/TheWikipediaLibrary	master	+227 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T125653 Create new types of notifications
Resolved	• Samwalton9-WMF	T132084 Notify editors that they are now eligible for the Wikipedia Library program
Resolved	Scardenasmolinar	T271919 Write tests for Extension:TheWikipediaLibrary

Event Timeline

• Samwalton9-WMF created this task.Jan 13 2021, 1:26 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 13 2021, 1:26 PM

There wasn't much info in the spike on this one @jsn.sherman, feel free to expand as is helpful.

• Samwalton9-WMF mentioned this in T269849: Evaluate Wikipedia Library notification progress [4hr].Jan 13 2021, 1:41 PM

Aklapper removed projects: User-notice, Notifications, Growth-Team.Jan 13 2021, 1:57 PM

Aklapper removed subscribers: • jmatazzoni, • KMuthu, • AVasanth_WMF, • WingedBladesofGodric.

Legoktm unsubscribed.Jan 13 2021, 4:06 PM

• Samwalton9-WMF edited projects, added The-Wikipedia-Library (Kanban); removed The-Wikipedia-Library.Jan 15 2021, 9:57 AM

Trizek-WMF unsubscribed.Jan 26 2021, 3:39 PM

I need to configure my MediaWiki local environment with this extension, but I'm starting to work on that.

Quiddity unsubscribed.Feb 8 2021, 11:50 PM

Change 666765 had a related patch set uploaded (by Scardenasmolinar; owner: Scardenasmolinar):
[mediawiki/extensions/TheWikipediaLibrary@master] Add tests for the extension

https://gerrit.wikimedia.org/r/666765

gerritbot added a project: Patch-For-Review.Feb 25 2021, 1:01 AM

• Samwalton9-WMF mentioned this in T275774: Performance review of TheWikipediaLibrary extension.Feb 25 2021, 2:30 PM

Scardenasmolinar moved this task from In Progress to Review on the The-Wikipedia-Library (Kanban) board.Mar 4 2021, 3:11 PM

@Scardenasmolinar Do we know how/where we can get a +2 for this?

• Samwalton9-WMF mentioned this in T256297: Improve TheWikipediaLibrary guard clause to prevent spam.Mar 8 2021, 2:21 PM

Jason can +2 it, although it might be a good idea to get another set of eyes on the code before merging.

Change 666765 merged by jenkins-bot:
[mediawiki/extensions/TheWikipediaLibrary@master] Add tests for the extension

https://gerrit.wikimedia.org/r/666765

Scardenasmolinar mentioned this in rEWPL5d1c737f9133: Add tests for the extension.Mar 12 2021, 1:45 AM

Scardenasmolinar moved this task from Review to Done on the The-Wikipedia-Library (Kanban) board.Mar 12 2021, 1:53 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 12 2021, 2:00 AM