Make topic subscriptions available via URL parameter
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Jun 7 2021, 7:46 PM

Description

T243621 introduced a query string parameter that makes it possible for volunteers to try new [Talk pages project]() features on live talk pages prior to said "features" being made available within the Discussion tools beta feature.

This task is about making it possible for people using the ?dtenable=1 URL parameter try topic subscriptions (T263820) on any Wikimedia wiki.

Requirements

People who append `?dtenable=1 to the URL of any page where the Reply Tool is already available, will:
- 1) See [ subscribe ] affordances next to any ==H2== sections that appear on said page
- 2) Be able to click the [ subscribe ] affordance(s) mentioned in "1)"
- 3) Receive notification(s) when new comment(s) are posted in section to which they have subscribed
- 4) Be able to unsubscribe from conversations to which they have previously subscribed

Done

===Requirements are met

Details

Subject	Repo	Branch	Lines +/-
Config option to enable topic subscriptions backend and dtenable=1 URL parameter	mediawiki/extensions/DiscussionTools	master	+12 -5
Config option to enable topic subscriptions backend and dtenable=1 URL parameter	mediawiki/extensions/DiscussionTools	wmf/1.37.0-wmf.12	+12 -5
Config option to enable topic subscriptions backend and dtenable=1 URL parameter	mediawiki/extensions/DiscussionTools	wmf/1.37.0-wmf.11	+12 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Resolved	• ppelberg	T284489 Deploy topic subscriptions (desktop) as opt-out feature at all projects
Resolved	• ppelberg	T284490 Offer topic subscriptions as a Beta Feature at all projects
Resolved	• ppelberg	T287276 Offer manual topic subscriptions as Beta Feature at all projects
Resolved	• Whatamidoing-WMF	T286094 Publicize availability of topic subscriptions via URL parameter
Resolved	matmarex	T284491 Make topic subscriptions available via URL parameter

Event Timeline

• ppelberg created this task.Jun 7 2021, 7:46 PM

• ppelberg moved this task from Incoming to Upcoming on the Editing-team (Kanban Board) board.

• ppelberg added a subtask: T282699: Create topic subscription table.

Patriccck awarded a token.Jun 7 2021, 8:30 PM

Change 698623 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Allow dtenable=1 URL parameter to enable topic subscriptions

https://gerrit.wikimedia.org/r/698623

gerritbot added a project: Patch-For-Review.Jun 7 2021, 8:47 PM

matmarex claimed this task.Jun 7 2021, 8:47 PM

matmarex moved this task from Upcoming to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

@Esanders noted (on Gerrit) that this needs more work:

This is slightly useless as events will not be generated until the feature is at least in beta. All you can test is the subscribe links.

Patch updated

• ppelberg closed subtask T282699: Create topic subscription table as Resolved.Jun 16 2021, 11:24 PM

Change 698623 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Config option to enable topic subscriptions backend and dtenable=1 URL parameter

https://gerrit.wikimedia.org/r/698623

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jun 29 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2021, 4:10 PM

I'll backport this today.

Change 702171 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.11] Config option to enable topic subscriptions backend and dtenable=1 URL parameter

https://gerrit.wikimedia.org/r/702171

Change 702172 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.12] Config option to enable topic subscriptions backend and dtenable=1 URL parameter

https://gerrit.wikimedia.org/r/702172

https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210629T2300

This is a slightly bigger change than it seems – in order to allow folks to receive notifications, we have to run the code that generates them on every talk page edit (the "topic subscriptions backend"), just like when topic subscriptions are available as a beta feature.

We've made it available as a beta feature yesterday on a number of wikis, and everything seems good so far. So I'm comfortable with deploying this.

In the unlikely event that it causes issues, the new code can be quickly disabled in config, by setting $wgDiscussionToolsEnableTopicSubscriptionBackend = false.

Change 702171 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.11] Config option to enable topic subscriptions backend and dtenable=1 URL parameter

https://gerrit.wikimedia.org/r/702171

Change 702172 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.12] Config option to enable topic subscriptions backend and dtenable=1 URL parameter

https://gerrit.wikimedia.org/r/702172

Mentioned in SAL (#wikimedia-operations) [2021-06-29T23:30:18Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/DiscussionTools/: e77e002130a7815570ff967013757bacc7037fb0: Config option to enable topic subscriptions backend and dtenable=1 URL parameter (T284491) (duration: 01m 09s)

Mentioned in SAL (#wikimedia-operations) [2021-06-29T23:31:40Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/DiscussionTools/: bad82665f8bea667aff049794612c270063c7519: Config option to enable topic subscriptions backend and dtenable=1 URL parameter (T284491) (duration: 01m 06s)

Mentioned in SAL (#wikimedia-operations) [2021-06-29T23:33:06Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.11/extensions/DiscussionTools/: bad82665f8bea667aff049794612c270063c7519: Config option to enable topic subscriptions backend and dtenable=1 URL parameter (T284491) (duration: 01m 05s)

matmarex moved this task from Doing to QA on the Editing-team (Kanban Board) board.Jun 29 2021, 11:39 PM

matmarex edited projects, added Editing QA; removed Patch-For-Review.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.12; 2021-06-28); removed MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jun 30 2021, 12:00 AM

In T284491#7185400, @matmarex wrote:

This is a slightly bigger change than it seems – in order to allow folks to receive notifications, we have to run the code that generates them on every talk page edit (the "topic subscriptions backend"), just like when topic subscriptions are available as a beta feature.

@matmarex: what – if any – impact will this change have on the load DiscussionTools is placing on the Parser Cache?

None, the additional load is on appservers (where our code runs), RESTBase/Parsoid (which deliver the HTML we use) and the x1 databases (where Echo notifications data is mostly stored).

matmarex mentioned this in T285895: ApiUsageException: There is no revision with ID [REDACTED]..Jun 30 2021, 7:51 PM

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.Jul 1 2021, 2:57 PM

In T284491#7187749, @matmarex wrote:

None, the additional load is on appservers (where our code runs), RESTBase/Parsoid (which deliver the HTML we use) and the x1 databases (where Echo notifications data is mostly stored).

Understood.

• ppelberg moved this task from Inbox to High Priority on the Editing QA board.Jul 1 2021, 7:20 PM

• ppelberg removed a parent task: T284490: Offer topic subscriptions as a Beta Feature at all projects.Jul 2 2021, 11:44 PM

• ppelberg added a parent task: T286094: Publicize availability of topic subscriptions via URL parameter.

matmarex mentioned this in T285796: Subscribe links appearing in main namespace unexpectedly.Jul 12 2021, 6:20 PM

Ryasmeen edited projects, added Verified; removed Editing QA.Jul 16 2021, 9:16 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

• ppelberg closed this task as Resolved.Jul 20 2021, 11:49 PM

• ppelberg removed a subtask: T282699: Create topic subscription table.Jul 26 2021, 11:53 PM

• jbolorinos-ctr subscribed.Jul 27 2021, 7:34 PM

Make topic subscriptions available via URL parameterClosed, ResolvedPublicActions