Page MenuHomePhabricator
Create Task
Maniphest T289926

Fix passing null to non-null param of PHP internal functions in MediaWiki core (PHP 8.1 warning)
Open, Needs TriagePublicBUG REPORT
Actions

Description

It's deprecated in PHP 8.1, so in a lot of places, one could see notices like urlencode(): Passing null to parameter #1 ($string) of type string is deprecated.

Current unique issues from composer phpunit:unit only:

MediaWiki\Tests\Rest\Handler\UserContributionsHandlerTest::testThatParametersAreHandledCorrectlyForMeEndpoint with data set #0 (array())
urlencode(): Passing null to parameter #1 ($string) of type string is deprecated

tests/phpunit/unit/includes/Rest/Handler/HandlerTestTrait.php:62
includes/Rest/Handler.php:103
includes/Rest/Handler/UserContributionsHandler.php:92
includes/Rest/Handler/UserContributionsHandler.php:31
tests/phpunit/unit/includes/Rest/Handler/HandlerTestTrait.php:151
tests/phpunit/unit/includes/Rest/Handler/UserContributionsHandlerTest.php:175
tests/phpunit/MediaWikiUnitTestCase.php:108
SiteConfigurationTest::testSiteFromDb
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated

includes/SiteConfiguration.php:515
tests/phpunit/unit/includes/SiteConfigurationTest.php:136
tests/phpunit/MediaWikiUnitTestCase.php:108
FileBackendGroupTest::testGuessMimeInternal with data set "No extension" ('foo', null, null, null, null)
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

tests/phpunit/unit/includes/filebackend/FileBackendGroupTestTrait.php:413
tests/phpunit/MediaWikiUnitTestCase.php:108
  • This test shouldn't be marked as unity at all, it depends on wfExpandUrl() and therefore $wgServer.
HttpRequestFactoryTest::testCreate
substr(): Passing null to parameter #1 ($string) of type string is deprecated

includes/GlobalFunctions.php:782
includes/GlobalFunctions.php:490
includes/http/MWHttpRequest.php:101
includes/http/GuzzleHttpRequest.php:62
includes/http/HttpRequestFactory.php:120
tests/phpunit/unit/includes/http/HttpRequestFactoryTest.php:91
tests/phpunit/MediaWikiUnitTestCase.php:108

Details

SubjectRepoBranchLines +/-
Ensure that if db returns null we don't pass it to strlenmediawiki/coremaster+1 -1
More fixes for incorrect types being passed to core php functionsmediawiki/coremaster+7 -4
Isolate dbkey creation so we can ensure that the dbkey is a stringmediawiki/coremaster+35 -25
More 8.1 type strictnessmediawiki/coremaster+27 -17
Ensure private method prepareUrlForCSP doesn't get nullmediawiki/coremaster+59 -30
SpecialRevisionDelete: Set default of '' for wpReasonmediawiki/coremaster+1 -1
Fix PHP 8 compatibility issue in SpecialMapmediawiki/extensions/Kartographermaster+10 -12
Avoid passing null to PHP 8.1 functions that don't support itmediawiki/extensions/OAuthREL1_39+4 -4
SpecialRevisionDelete: Set default of '' for wpReasonmediawiki/coreREL1_38+1 -1
SpecialRevisionDelete: Set default of '' for wpReasonmediawiki/coreREL1_35+1 -1
SpecialRevisionDelete: Set default of '' for wpReasonmediawiki/coreREL1_39+1 -1
Avoid passing null to PHP 8.1 functions that don't support itmediawiki/extensions/OAuthREL1_38+4 -4
Avoid passing null to HTMLFormField methodsmediawiki/coremaster+1 -1
Title: Fix Title::makeTitle to allow null $fragmentmediawiki/coremaster+22 -21
Avoid passing null to PHP 8.1 functions that don't support itmediawiki/extensions/OAuthREL1_37+4 -4
Fix incomplete ITextFormatter mocksmediawiki/coreREL1_39+27 -18
Fix incomplete ITextFormatter mocksmediawiki/coremaster+27 -18
api: Fix minor PHP 8.1 incompatibility in ApiOptionsmediawiki/coreREL1_37+2 -2
api: Fix minor PHP 8.1 incompatibility in ApiOptionsmediawiki/coreREL1_39+2 -2
api: Fix minor PHP 8.1 incompatibility in ApiOptionsmediawiki/coreREL1_38+2 -2
api: Fix minor PHP 8.1 incompatibility in ApiOptionsmediawiki/coremaster+2 -2
Don't pass null to json_decode() (deprecated in PHP 8.1)mediawiki/coremaster+1 -1
Avoid passing null to PHP 8.1 functions that don't support itmediawiki/extensions/OAuthREL1_35+4 -4
Avoid passing null to PHP 8.1 functions that don't support itmediawiki/extensions/OAuthmaster+4 -4
Get rid of warnings on PHP 8.1mediawiki/coreREL1_35+116 -89
Get rid of warnings on PHP 8.1mediawiki/coreREL1_37+97 -88
Get rid of warnings on PHP 8.1mediawiki/coreREL1_38+100 -91
Ensure that strtr does not get null.mediawiki/extensions/CirrusSearchmaster+3 -2
site: Consistently return null from Site::getDomain()mediawiki/coreREL1_35+10 -4
site: Consistently return null from Site::getDomain()mediawiki/coreREL1_38+10 -4
site: Consistently return null from Site::getDomain()mediawiki/coreREL1_37+10 -4
Handle null passed to wfShorthandToInteger() and Html::element()mediawiki/coremaster+4 -4
Ensure that strlen() does not get passed a (valid) nullmediawiki/coremaster+2 -2
Ensure we don't pass null to mb_strlen.mediawiki/coremaster+1 -1
site: Consistently return null from Site::getDomain()mediawiki/coremaster+10 -4
Ensure we don't pass null to mb_strlen.mediawiki/coreREL1_35+1 -1
Ensure we don't pass null to mb_strlen.mediawiki/coreREL1_37+1 -1
Ensure we don't pass null to mb_strlen.mediawiki/coreREL1_38+1 -1
Ensure that strlen() does not get passed a (valid) nullmediawiki/coreREL1_35+2 -2
Ensure that strlen() does not get passed a (valid) nullmediawiki/coreREL1_37+2 -2
Ensure that strlen() does not get passed a (valid) nullmediawiki/coreREL1_38+2 -2
Handle null passed to wfShorthandToInteger() and Html::element()mediawiki/coreREL1_38+4 -4
Handle null passed to wfShorthandToInteger() and Html::element()mediawiki/coreREL1_37+4 -4
Handle null passed to wfShorthandToInteger() and Html::element()mediawiki/coreREL1_35+4 -4
Don't pass null where strings are expectedmediawiki/extensions/CirrusSearchmaster+5 -5
Ensure we don't pass null to a few of strlenmediawiki/coremaster+3 -3
Avoid passing null to trim() in SkinTemplatemediawiki/coreREL1_38+1 -1
Avoid passing null to trim() in SkinTemplatemediawiki/coreREL1_37+1 -1
Avoid passing null to trim() in SkinTemplatemediawiki/coreREL1_35+1 -1
Get rid of warnings on PHP 8.1mediawiki/coremaster+100 -91
Avoid passing null to trim() in SkinTemplatemediawiki/coremaster+1 -1
Improve ImagePage::doRenderLangOpt/File::getMatchedLanguagemediawiki/coremaster+8 -8
SiteConfiguration: Don't pass null to str_replace()mediawiki/coreREL1_35+10 -8
SiteConfiguration: Don't pass null to str_replace()mediawiki/coreREL1_36+10 -8
SiteConfiguration: Don't pass null to str_replace()mediawiki/coreREL1_37+10 -8
SiteConfiguration: Don't pass null to str_replace()mediawiki/coremaster+10 -8
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenBUG REPORTNoneT289926 Fix passing null to non-null param of PHP internal functions in MediaWiki core (PHP 8.1 warning)
 ResolvedAmmarpadT299696 substr(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedReedyT311551 Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in ShellboxClientFactory.php on line
ResolvedReedyT311552 Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in FormatJson.php on line 147
 ResolvedReedyT311554 Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in ChangeTags.php on line 192
 ResolvedReedyT311557 Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in SpecialGadgets.php on line 32
 ResolvedReedyT311559 Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541
 ResolvedReedyT311561 Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in ImageListPager.php on line 501
 ResolvedReedyT311563 Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in SpecialStructuredDiscussions.php on line 50
 ResolvedKrinkleT311566 Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated in MemcachedBagOStuff.php on line 68
 ResolvedReedyT311568 Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in UploadBase.php on line 288
 ResolvedReedyT311569 Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in FileBackend.php on line 1511
 ResolvedBUG REPORTJdforrester-WMFT311567 ManualLogEntry::getComment() should always return string
 ResolvedReedyT311570 Deprecated: ord(): Passing null to parameter #1 ($character) of type string is deprecated in Language.php on line 2646
 ResolvedReedyT311571 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in HTMLIntField.php on line 27
 ResolvedReedyT311572 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in HTMLFloatField.php on line 20
 ResolvedReedyT311574 Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Parser.php on line 2333
 ResolvedReedyT311576 Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in Parser.php on line 2319
 ResolvedReedyT311577 Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in SpecialMWOAuthListConsumers.php on line 58
 ResolvedReedyT311578 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in HTMLDateTimeField.php on line 125
 ResolvedReedyT311579 Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in SpecialAbuseLog.php on line 215
 ResolvedReedyT311580 Deprecated: file_exists(): Passing null to parameter #1 ($filename) of type string is deprecated in SiteMatrix.php on line 83
 ResolvedReedyT311674 Deprecated: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated in MathRenderer.php on line 521
 ResolvedReedyT311678 Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialEditWatchlist.php on line 822
 ResolvedReedyT311920 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialBlockList.php on line 100
 ResolvedReedyT311921 Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in SpecialUserrights.php on line 663
 ResolvedReedyT311922 Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541
 ResolvedReedyT312300 Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in SpecialDiff.php on line 50
 ResolvedZabeT312301 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialDiff.php on line 92
 ResolvedReedyT312302 Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in SpecialRedirect.php on line 81
 ResolvedReedyT312303 Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in SpecialRenameuser.php on line 110
 ResolvedReedyT312304 Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541
 ResolvedReedyT312305 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in HTMLDateTimeField.php on line 125
 ResolvedReedyT312519 Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in Parser.php on line 3997
 ResolvedReedyT312520 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in Sanitizer.php on line 1139
 ResolvedReedyT312678 Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in UploadSourceAdapter.php on line 88
 ResolvedReedyT312680 various null passed to functions in Language.php when processing Barack Obama
 ResolvedReedyT313053 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in UnreviewedPages.php on line 49
 ResolvedReedyT313050 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in PendingChanges.php on line 44
 ResolvedReedyT313055 Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541
 ResolvedReedyT313054 Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541
 ResolvedReedyT313056 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialCheckUserLog.php on line 67
 ResolvedBUG REPORTNoneT318307 HTMLForm's validation-callback is given mixed values (against documentation)
 ResolvedBUG REPORTReedyT318460 wfCgiToArray() passes deprecated null parameter
 ResolvedReedyT326837 Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 539
 ResolvedReedyT326838 WikimediaMessages hooks passing null to preg_match
 ResolvedReedyT344568 PHP deprecations: json_decode() / explode(): Passing null to parameter $string is deprecated
 ResolvedBUG REPORTTK-999T351088 PHP 8.1: WebRequest::getFuzzyBool may emit deprecation warnings

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jul 14 2022, 10:25 PM

Change 813958 had a related patch set uploaded (by Zabe; author: MarkAHershberger):

[mediawiki/core@REL1_35] Ensure we don't pass null to mb_strlen.

https://gerrit.wikimedia.org/r/813958

gerritbot added a comment.Jul 14 2022, 10:34 PM

Change 813958 merged by jenkins-bot:

[mediawiki/core@REL1_35] Ensure we don't pass null to mb_strlen.

https://gerrit.wikimedia.org/r/813958

gerritbot added a comment.Jul 14 2022, 10:37 PM

Change 813957 merged by jenkins-bot:

[mediawiki/core@REL1_37] Ensure we don't pass null to mb_strlen.

https://gerrit.wikimedia.org/r/813957

gerritbot added a comment.Jul 14 2022, 10:38 PM

Change 813956 merged by jenkins-bot:

[mediawiki/core@REL1_38] Ensure we don't pass null to mb_strlen.

https://gerrit.wikimedia.org/r/813956

Reedy closed subtask T312303: Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in SpecialRenameuser.php on line 110 as Resolved.Jul 15 2022, 12:47 AM
Dreamy_Jazz closed subtask T313056: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialCheckUserLog.php on line 67 as Resolved.Jul 15 2022, 11:04 AM
Reedy closed subtask T313053: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in UnreviewedPages.php on line 49 as Resolved.Jul 15 2022, 11:47 AM
Reedy closed subtask T313050: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in PendingChanges.php on line 44 as Resolved.
Reedy closed subtask T312305: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in HTMLDateTimeField.php on line 125 as Resolved.Jul 16 2022, 10:46 AM
Reedy closed subtask T311572: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in HTMLFloatField.php on line 20 as Resolved.
Reedy closed subtask T311571: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in HTMLIntField.php on line 27 as Resolved.
Reedy closed subtask T311578: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in HTMLDateTimeField.php on line 125 as Resolved.
gerritbot added a comment.Jul 16 2022, 10:59 AM

Change 814307 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_38] site: Consistently return null from Site::getDomain()

https://gerrit.wikimedia.org/r/814307

gerritbot added a comment.Jul 16 2022, 11:00 AM

Change 814308 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_37] site: Consistently return null from Site::getDomain()

https://gerrit.wikimedia.org/r/814308

gerritbot added a comment.Jul 16 2022, 11:00 AM

Change 814309 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_35] site: Consistently return null from Site::getDomain()

https://gerrit.wikimedia.org/r/814309

gerritbot added a comment.Jul 16 2022, 11:10 AM

Change 814308 merged by jenkins-bot:

[mediawiki/core@REL1_37] site: Consistently return null from Site::getDomain()

https://gerrit.wikimedia.org/r/814308

gerritbot added a comment.Jul 16 2022, 11:11 AM

Change 814309 merged by jenkins-bot:

[mediawiki/core@REL1_35] site: Consistently return null from Site::getDomain()

https://gerrit.wikimedia.org/r/814309

gerritbot added a comment.Jul 16 2022, 11:11 AM

Change 814307 merged by jenkins-bot:

[mediawiki/core@REL1_38] site: Consistently return null from Site::getDomain()

https://gerrit.wikimedia.org/r/814307

Dreamy_Jazz reopened subtask T313056: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialCheckUserLog.php on line 67 as Open.Jul 17 2022, 12:11 PM
Zabe closed subtask T313056: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialCheckUserLog.php on line 67 as Resolved.Jul 17 2022, 12:19 PM
Reedy closed subtask T313054: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541 as Resolved.Jul 17 2022, 7:39 PM
Reedy closed subtask T313055: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541 as Resolved.Jul 18 2022, 1:33 PM
gerritbot added a comment.Jul 18 2022, 4:18 PM

Change 812400 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Ensure that strtr does not get null.

https://gerrit.wikimedia.org/r/812400

gerritbot added a comment.Jul 28 2022, 6:26 PM

Change 818200 had a related patch set uploaded (by Brian Wolff; author: Simetrical):

[mediawiki/core@REL1_38] Get rid of warnings on PHP 8.1

https://gerrit.wikimedia.org/r/818200

gerritbot added a comment.Jul 28 2022, 6:29 PM

Change 818201 had a related patch set uploaded (by Brian Wolff; author: Simetrical):

[mediawiki/core@REL1_37] Get rid of warnings on PHP 8.1

https://gerrit.wikimedia.org/r/818201

gerritbot added a comment.Jul 28 2022, 6:39 PM

Change 818202 had a related patch set uploaded (by Brian Wolff; author: Simetrical):

[mediawiki/core@REL1_35] Get rid of warnings on PHP 8.1

https://gerrit.wikimedia.org/r/818202

gerritbot added a comment.Jul 28 2022, 6:39 PM

Change 818200 merged by jenkins-bot:

[mediawiki/core@REL1_38] Get rid of warnings on PHP 8.1

https://gerrit.wikimedia.org/r/818200

gerritbot added a comment.Jul 28 2022, 6:52 PM

Change 818201 merged by jenkins-bot:

[mediawiki/core@REL1_37] Get rid of warnings on PHP 8.1

https://gerrit.wikimedia.org/r/818201

gerritbot added a comment.Jul 28 2022, 7:53 PM

Change 818202 merged by jenkins-bot:

[mediawiki/core@REL1_35] Get rid of warnings on PHP 8.1

https://gerrit.wikimedia.org/r/818202

Reedy closed subtask T312304: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541 as Resolved.Aug 1 2022, 11:03 PM
Reedy closed subtask T311674: Deprecated: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated in MathRenderer.php on line 521 as Resolved.Aug 8 2022, 1:01 PM
Samwilson added a subtask: T318307: HTMLForm's validation-callback is given mixed values (against documentation).Sep 22 2022, 4:34 AM
Samwilson added a subtask: T318460: wfCgiToArray() passes deprecated null parameter.Sep 24 2022, 3:33 AM
gerritbot added a comment.Sep 24 2022, 3:47 AM

Change 834621 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/OAuth@master] Avoid passing null to PHP 8.1 functions that don't support it

https://gerrit.wikimedia.org/r/834621

gerritbot added a comment.Sep 24 2022, 1:53 PM

Change 834621 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Avoid passing null to PHP 8.1 functions that don't support it

https://gerrit.wikimedia.org/r/834621

gerritbot added a comment.Sep 24 2022, 1:54 PM

Change 834536 had a related patch set uploaded (by Reedy; author: Samwilson):

[mediawiki/extensions/OAuth@REL1_39] Avoid passing null to PHP 8.1 functions that don't support it

https://gerrit.wikimedia.org/r/834536

gerritbot added a comment.Sep 24 2022, 1:55 PM

Change 834537 had a related patch set uploaded (by Reedy; author: Samwilson):

[mediawiki/extensions/OAuth@REL1_38] Avoid passing null to PHP 8.1 functions that don't support it

https://gerrit.wikimedia.org/r/834537

gerritbot added a comment.Sep 24 2022, 1:55 PM

Change 834538 had a related patch set uploaded (by Reedy; author: Samwilson):

[mediawiki/extensions/OAuth@REL1_37] Avoid passing null to PHP 8.1 functions that don't support it

https://gerrit.wikimedia.org/r/834538

gerritbot added a comment.Sep 24 2022, 1:55 PM

Change 834539 had a related patch set uploaded (by Reedy; author: Samwilson):

[mediawiki/extensions/OAuth@REL1_35] Avoid passing null to PHP 8.1 functions that don't support it

https://gerrit.wikimedia.org/r/834539

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 24 2022, 2:00 PM
gerritbot added a comment.Sep 24 2022, 2:19 PM

Change 834539 merged by jenkins-bot:

[mediawiki/extensions/OAuth@REL1_35] Avoid passing null to PHP 8.1 functions that don't support it

https://gerrit.wikimedia.org/r/834539

Reedy closed subtask T318460: wfCgiToArray() passes deprecated null parameter as Resolved.Sep 24 2022, 6:02 PM
gerritbot added a comment.Sep 26 2022, 3:38 AM

Change 834734 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Don't pass null to json_decode() (deprecated in PHP 8.1)

https://gerrit.wikimedia.org/r/834734

gerritbot added a comment.Sep 27 2022, 3:38 PM

Change 834734 merged by jenkins-bot:

[mediawiki/core@master] Don't pass null to json_decode() (deprecated in PHP 8.1)

https://gerrit.wikimedia.org/r/834734

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.4; 2022-10-03); removed MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 27 2022, 4:00 PM
gerritbot added a comment.Oct 14 2022, 4:51 AM

Change 842560 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Avoid passing null to HTMLFormField methods

https://gerrit.wikimedia.org/r/842560

Bawolff closed subtask T311567: ManualLogEntry::getComment() should always return string as Resolved.Oct 21 2022, 11:52 PM
gerritbot added a comment.Nov 8 2022, 11:25 AM

Change 854492 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/core@master] api: Fix minor PHP 8.1 incompatibility in ApiOptions

https://gerrit.wikimedia.org/r/854492

gerritbot added a comment.Nov 8 2022, 3:35 PM

Change 854492 merged by jenkins-bot:

[mediawiki/core@master] api: Fix minor PHP 8.1 incompatibility in ApiOptions

https://gerrit.wikimedia.org/r/854492

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Nov 8 2022, 4:00 PM
gerritbot added a comment.Nov 8 2022, 5:22 PM

Change 854081 had a related patch set uploaded (by Zabe; author: Thiemo Kreuz (WMDE)):

[mediawiki/core@REL1_39] api: Fix minor PHP 8.1 incompatibility in ApiOptions

https://gerrit.wikimedia.org/r/854081

gerritbot added a comment.Nov 8 2022, 5:22 PM

Change 854082 had a related patch set uploaded (by Zabe; author: Thiemo Kreuz (WMDE)):

[mediawiki/core@REL1_38] api: Fix minor PHP 8.1 incompatibility in ApiOptions

https://gerrit.wikimedia.org/r/854082

gerritbot added a comment.Nov 8 2022, 5:23 PM

Change 854083 had a related patch set uploaded (by Zabe; author: Thiemo Kreuz (WMDE)):

[mediawiki/core@REL1_37] api: Fix minor PHP 8.1 incompatibility in ApiOptions

https://gerrit.wikimedia.org/r/854083

gerritbot added a comment.Nov 8 2022, 5:33 PM

Change 854083 merged by jenkins-bot:

[mediawiki/core@REL1_37] api: Fix minor PHP 8.1 incompatibility in ApiOptions

https://gerrit.wikimedia.org/r/854083

gerritbot added a comment.Nov 8 2022, 5:33 PM

Change 854081 merged by jenkins-bot:

[mediawiki/core@REL1_39] api: Fix minor PHP 8.1 incompatibility in ApiOptions

https://gerrit.wikimedia.org/r/854081

gerritbot added a comment.Nov 8 2022, 5:34 PM

Change 854082 merged by jenkins-bot:

[mediawiki/core@REL1_38] api: Fix minor PHP 8.1 incompatibility in ApiOptions

https://gerrit.wikimedia.org/r/854082

ReleaseTaggerBot edited projects, added MW-1.39-notes; removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Nov 8 2022, 6:00 PM
gerritbot added a comment.Nov 21 2022, 9:01 AM

Change 858993 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/core@master] Fix incomplete ITextFormatter mocks

https://gerrit.wikimedia.org/r/858993

gerritbot added a comment.Nov 21 2022, 10:06 AM

Change 858993 merged by jenkins-bot:

[mediawiki/core@master] Fix incomplete ITextFormatter mocks

https://gerrit.wikimedia.org/r/858993

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.12; 2022-11-28); removed MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 21 2022, 11:01 AM
gerritbot added a comment.Nov 21 2022, 5:17 PM

Change 859072 had a related patch set uploaded (by Zabe; author: Thiemo Kreuz (WMDE)):

[mediawiki/core@REL1_39] Fix incomplete ITextFormatter mocks

https://gerrit.wikimedia.org/r/859072

gerritbot added a comment.Nov 21 2022, 5:27 PM

Change 859072 merged by jenkins-bot:

[mediawiki/core@REL1_39] Fix incomplete ITextFormatter mocks

https://gerrit.wikimedia.org/r/859072

Jdforrester-WMF removed projects: MW-1.37-release, MW-1.37-notes.Nov 30 2022, 8:58 PM
Jdforrester-WMF subscribed.

1.37.x is now EOL.

gerritbot added a comment.Dec 1 2022, 1:48 AM

Change 834538 abandoned by Umherirrender:

[mediawiki/extensions/OAuth@REL1_37] Avoid passing null to PHP 8.1 functions that don't support it

Reason:

EOL branch, T324133

https://gerrit.wikimedia.org/r/834538

Reedy edited projects, added MW-1.39-release; removed MW-1.35-release.Jan 8 2023, 6:18 PM
Reedy added subtasks: T326837: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 539, T326838: WikimediaMessages hooks passing null to preg_match.Jan 12 2023, 7:03 PM
Reedy closed subtask T326837: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 539 as Resolved.Jan 12 2023, 8:36 PM
Reedy closed subtask T326838: WikimediaMessages hooks passing null to preg_match as Resolved.Jan 13 2023, 12:15 PM
gerritbot added a comment.Jan 17 2023, 3:06 PM

Change 810964 abandoned by MarkAHershberger:

[mediawiki/core@master] Title: Fix Title::makeTitle to allow null $fragment

Reason:

https://gerrit.wikimedia.org/r/810964

gerritbot added a comment.Jan 19 2023, 7:18 PM

Change 842560 merged by jenkins-bot:

[mediawiki/core@master] Avoid passing null to HTMLFormField methods

https://gerrit.wikimedia.org/r/842560

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.20; 2023-01-23); removed MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Jan 20 2023, 9:01 AM
gerritbot added a comment.Jan 31 2023, 1:04 AM

Change 834537 merged by jenkins-bot:

[mediawiki/extensions/OAuth@REL1_38] Avoid passing null to PHP 8.1 functions that don't support it

https://gerrit.wikimedia.org/r/834537

gerritbot added a comment.Jan 31 2023, 1:52 AM

Change 885062 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] SpecialRevisionDelete: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/885062

gerritbot added a comment.Jan 31 2023, 2:24 AM

Change 885062 merged by jenkins-bot:

[mediawiki/core@master] SpecialRevisionDelete: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/885062

gerritbot added a comment.Jan 31 2023, 2:55 AM

Change 884937 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] SpecialRevisionDelete: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/884937

gerritbot added a comment.Jan 31 2023, 2:55 AM

Change 884938 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_38] SpecialRevisionDelete: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/884938

gerritbot added a comment.Jan 31 2023, 2:55 AM

Change 884939 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_35] SpecialRevisionDelete: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/884939

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 31 2023, 3:00 AM
gerritbot added a comment.Jan 31 2023, 3:02 AM

Change 884939 merged by jenkins-bot:

[mediawiki/core@REL1_35] SpecialRevisionDelete: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/884939

gerritbot added a comment.Jan 31 2023, 3:05 AM

Change 884937 merged by jenkins-bot:

[mediawiki/core@REL1_39] SpecialRevisionDelete: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/884937

gerritbot added a comment.Jan 31 2023, 3:06 AM

Change 884938 merged by jenkins-bot:

[mediawiki/core@REL1_38] SpecialRevisionDelete: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/884938

gerritbot added a comment.Jan 31 2023, 3:29 PM

Change 834536 merged by jenkins-bot:

[mediawiki/extensions/OAuth@REL1_39] Avoid passing null to PHP 8.1 functions that don't support it

https://gerrit.wikimedia.org/r/834536

gerritbot added a comment.Feb 16 2023, 7:50 AM

Change 889748 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Fix PHP 8 compatibility issue in SpecialMap

https://gerrit.wikimedia.org/r/889748

gerritbot added a comment.Feb 18 2023, 2:04 AM

Change 889748 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix PHP 8 compatibility issue in SpecialMap

https://gerrit.wikimedia.org/r/889748

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.24; 2023-02-20); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 18 2023, 3:00 AM
Reedy moved this task from Blocker to Not a blocker on the MW-1.38-release board.Jun 20 2023, 4:26 AM
Izno added a subtask: T344568: PHP deprecations: json_decode() / explode(): Passing null to parameter $string is deprecated.Aug 20 2023, 6:36 PM
gerritbot added a comment.Sep 3 2023, 6:09 PM

Change 811768 abandoned by MarkAHershberger:

[mediawiki/core@master] Ensure private method prepareUrlForCSP doesn't get null

Reason:

https://gerrit.wikimedia.org/r/811768

Reedy moved this task from Blocker to Not a blocker on the MW-1.39-release board.Oct 1 2023, 12:59 PM
Reedy closed subtask T344568: PHP deprecations: json_decode() / explode(): Passing null to parameter $string is deprecated as Resolved.Oct 7 2023, 6:31 PM
TK-999 added a subtask: T351088: PHP 8.1: WebRequest::getFuzzyBool may emit deprecation warnings.Nov 13 2023, 2:40 PM
matmarex closed subtask T351088: PHP 8.1: WebRequest::getFuzzyBool may emit deprecation warnings as Resolved.Nov 13 2023, 5:27 PM
gerritbot added a comment.Feb 16 2024, 2:55 PM

Change 809720 abandoned by MarkAHershberger:

[mediawiki/core@master] More 8.1 type strictness

Reason:

https://gerrit.wikimedia.org/r/809720

gerritbot added a comment.Feb 16 2024, 2:55 PM

Change 811378 abandoned by MarkAHershberger:

[mediawiki/core@master] Isolate dbkey creation so we can ensure that the dbkey is a string

Reason:

https://gerrit.wikimedia.org/r/811378

gerritbot added a comment.Feb 16 2024, 2:55 PM

Change 809320 abandoned by MarkAHershberger:

[mediawiki/core@master] More fixes for incorrect types being passed to core php functions

Reason:

https://gerrit.wikimedia.org/r/809320

gerritbot added a comment.Feb 16 2024, 2:56 PM

Change 811778 abandoned by MarkAHershberger:

[mediawiki/core@master] Ensure that if db returns null we don't pass it to strlen

Reason:

https://gerrit.wikimedia.org/r/811778

Pppery removed a project: Patch-For-Review.Oct 12 2024, 4:35 AM
matmarex closed subtask T318307: HTMLForm's validation-callback is given mixed values (against documentation) as Resolved.Wed, Jan 8, 5:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits