Page MenuHomePhabricator
Create Task
Maniphest T293080

Refactor Wikibase WebdriverIO tests from sync to async mode
Open, Needs TriagePublic
Actions

Description

Wikibase browser test suites to migrate:

  • Data bridge: client/data-bridge/tests/selenium/
  • Wikibase Repo (generic): repo/tests/selenium/; tracked in T343886
  • Tainted references: repo/tests/selenium/specs/tainted-ref.js; done as part of T343886
  • Termbox: view/lib/wikibase-termbox/tests/selenium/ (requires changes in the termbox repo); tracked in T300807
  • WikibaseLexeme: tracked in T293081

Instructions for the migration can be found in the commit message of the patch that temporarily disabled them: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/944967/

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+1 -1tests: Temporarily disable automatic running of Wdio tests in CI
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
 OpenNoneT226869 Run browser tests in parallel
 OpenNoneT344754 Browser tests video capture is shared between tests
 ResolvedNoneT314468 Update vite to Version 3
 OpenNoneT314470 Upgrade all CI jobs for WMF-deployed projects from Node 14 to Node 16
 OpenNoneT210726 Selenium framework cleanup
 OpenNoneT324685 Upgrade WebdriverIO to v8 in all repositories
 StalledNoneT324318 Update Wikibase code bases to WebdriverIO v8
 OpenNoneT256626 Refactor WebdriverIO tests from sync to async mode
 DeclinedNoneT182412 Investigate if WebdriverIO `sync: false` would be useful to us and document how to use it
 ResolvedzeljkofilipinT292853 Run Selenium tests targeting MediaWiki Core in MediaWiki-Docker
 ResolvedOsamaahmed17T293071 Refactor MediaWiki Core WebdriverIO tests from sync to async mode
 ResolvedNoneT297950 npm ERR! enoent Invalid response body while trying to fetch https://registry.npmjs.org/ua-parser-js: ENOENT: no such file or directory
 ResolvedNoneT293072 Refactor Popups WebdriverIO tests from sync to async mode
 DuplicateBUG REPORTzeljkofilipinT331063 Popups browser tests failing with `08:25:51 node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed.`
 ResolvedOsamaahmed17T293073 Refactor Echo WebdriverIO tests from sync to async mode
 ResolvedzeljkofilipinT293074 Refactor GlobalWatchlist WebdriverIO tests from sync to async mode
 ResolvedNoneT293076 Refactor Math WebdriverIO tests from sync to async mode
 ResolvedNoneT293078 Refactor Newsletter WebdriverIO tests from sync to async mode
 ResolvedKrinkleT293079 Refactor ProofreadPage WebdriverIO tests from sync to async mode
 OpenNoneT293080 Refactor Wikibase WebdriverIO tests from sync to async mode
 ResolvedOllie.Shotton_WMDET343886 Refactor generic Wikibase repo WebdriverIO tests from sync to async mode
 ResolvedJakob_WMDET300807 Refactor Termbox WebdriverIO tests from sync to async mode
 OpenNoneT293081 Refactor WikibaseLexeme WebdriverIO tests from sync to async mode
 ResolvedOsamaahmed17T293082 Refactor WikiLambda WebdriverIO tests from sync to async mode
 ResolvedvaughnwaltersT293084 Refactor MinervaNeue WebdriverIO tests from sync to async mode
 ResolvedzeljkofilipinT293258 Push a commit to Gerrit
 ResolvedzeljkofilipinT293374 Amend existing commit in Gerrit
 ResolvedzeljkofilipinT293381 Create a Wikimedia developer account
 ResolvedzeljkofilipinT293748 Introduce yourself in WebdriverIO topic in Zulip
 ResolvedkostajhT299102 Refactor GrowthExperiments WebdriverIO tests from sync to async mode
 ResolvedOsamaahmed17T299756 Refactor VisualEditor WebdriverIO tests from sync to async mode
 ResolvedOsamaahmed17T299684 Refactor ElectronPdfService WebdriverIO tests from sync to async mode
 OpenNoneT300808 Refactor wikidata/query/gui WebdriverIO tests from sync to async mode
 ResolvedpwangaiT300790 Refactor AbuseFilter WebdriverIO tests from sync to async mode
 ResolvedWMDE-FischT300791 Refactor AdvancedSearch WebdriverIO tests from sync to async mode
 ResolvedNoneT338793 Condense AdvancedSearch browser tests suite
 ResolvedOsamaahmed17T300212 Refactor CentralNotice WebdriverIO tests from sync to async mode
 ResolvedGehelT300793 Refactor CirrusSearch WebdriverIO tests from sync to async mode
 ResolvedpwangaiT300196 Refactor Cite WebdriverIO tests from sync to async mode
 ResolvedNoneT300205 Refactor CodeMirror WebdriverIO tests from sync to async mode
 InvalidpwangaiT300794 Refactor EntitySchema WebdriverIO tests from sync to async mode
 ResolvedNoneT300535 Refactor FileImporter WebdriverIO tests from sync to async mode
 InvalidNoneT300796 Refactor MobileFrontend WebdriverIO tests from sync to async mode
 ResolvedOsamaahmed17T300797 Refactor RelatedArticles WebdriverIO tests from sync to async mode
 ResolvedvaughnwaltersT300798 Refactor RevisionSlider WebdriverIO tests from sync to async mode
 ResolvedpwangaiT300208 Refactor TemplateWizard WebdriverIO tests from sync to async mode
 ResolvedNoneT300800 Refactor TwoColConflict WebdriverIO tests from sync to async mode
 InvalidNoneT300809 Refactor Deploy WebdriverIO tests from sync to async mode
 ResolvedOllie.Shotton_WMDET300811 Refactor Wdio-Wikibase WebdriverIO tests from sync to async mode
 ResolvedDreamy_JazzT321904 Refactor CheckUser WebdriverIO tests from sync to async mode
 OpenNoneT337463 Refactor wdio-mediawiki from sync to async mode

Event Timeline

zeljkofilipin created this task.Oct 12 2021, 12:47 PM
Restricted Application added a project: wdwb-tech. · View Herald TranscriptOct 12 2021, 12:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
zeljkofilipin added a parent task: T256626: Refactor WebdriverIO tests from sync to async mode.Oct 12 2021, 12:47 PM
zeljkofilipin mentioned this in T256626: Refactor WebdriverIO tests from sync to async mode.
Osamaahmed17 updated the task description. (Show Details)Feb 2 2022, 9:19 PM
Lucas_Werkmeister_WMDE mentioned this in T324318: Update Wikibase code bases to WebdriverIO v8.Dec 2 2022, 10:23 AM
vaughnwalters claimed this task.Apr 11 2023, 8:32 PM
vaughnwalters added a project: User-vaughnwalters.
vaughnwalters moved this task from incoming to in progress on the Wikidata board.
vaughnwalters moved this task from Backlog to In Progress on the User-vaughnwalters board.
Krinkle added a parent task: T324685: Upgrade WebdriverIO to v8 in all repositories.Aug 2 2023, 5:40 PM
Krinkle added a parent task: T324318: Update Wikibase code bases to WebdriverIO v8.
vaughnwalters moved this task from In Progress to Backlog on the User-vaughnwalters board.Aug 2 2023, 5:43 PM
gerritbot added a comment.Aug 2 2023, 5:52 PM

Change 944967 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Wikibase@master] tests: Temporarily disable automatic running of Wdio tests in CI

https://gerrit.wikimedia.org/r/944967

gerritbot added a project: Patch-For-Review.Aug 2 2023, 5:52 PM
WMDE-leszek added a subscriber: WMDE-leszek.Aug 3 2023, 8:56 AM
Michael added a subscriber: Michael.Aug 3 2023, 9:14 AM
Tarrow added a subscriber: Tarrow.Aug 7 2023, 5:14 PM

Hey @vaughnwalters!

I noticed you were assigned to this task for a while; as you might have seem there is a a patch up to disable these tests in the near future unless we resolve this ticket therefore driving it forwards has become a little more urgent.

Are you currently actively working on it? If so do you need any assistance? If not, that's also fine but I suspect someone from WMDE may wish to work on this in the near future and I wouldn't want to give the impression of them treading on your toes unnecessarily, if that's that case could you unassign yourself?

Thanks!

vaughnwalters added a comment.Aug 7 2023, 5:20 PM
In T293080#9074768, @Tarrow wrote:

Hey @vaughnwalters!

I noticed you were assigned to this task for a while; as you might have seem there is a a patch up to disable these tests in the near future unless we resolve this ticket therefore driving it forwards has become a little more urgent.

Are you currently actively working on it? If so do you need any assistance? If not, that's also fine but I suspect someone from WMDE may wish to work on this in the near future and I wouldn't want to give the impression of them treading on your toes unnecessarily, if that's that case could you unassign yourself?

Thanks!

Hi Hi @Tarrow I am not currently actively working on it and so I will go ahead and unassign myself but keep tracking this task. Thanks for the heads up, and if I get back to this before anyone else does I'll circle back for help as needed.

vaughnwalters removed vaughnwalters as the assignee of this task.Aug 7 2023, 5:21 PM
vaughnwalters added a subscriber: vaughnwalters.
gerritbot added a comment.Aug 7 2023, 7:11 PM

Change 944967 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Temporarily disable automatic running of Wdio tests in CI

https://gerrit.wikimedia.org/r/944967

Maintenance_bot removed a project: Patch-For-Review.Aug 7 2023, 7:30 PM
Jakob_WMDE added a subscriber: Jakob_WMDE.Aug 8 2023, 10:00 AM
Ifrahkhanyaree_WMDE added a project: Wikibase Product Platform Team WPP.Aug 8 2023, 10:24 AM
Ifrahkhanyaree_WMDE moved this task from Backlog to To polish on the Wikibase Product Platform Team WPP board.Aug 8 2023, 11:53 AM
Jakob_WMDE updated the task description. (Show Details)Aug 9 2023, 10:02 AM
Jakob_WMDE updated the task description. (Show Details)Aug 9 2023, 10:09 AM
Ifrahkhanyaree_WMDE moved this task from To polish to Backlog on the Wikibase Product Platform Team WPP board.Aug 9 2023, 12:13 PM
Ifrahkhanyaree_WMDE updated the task description. (Show Details)Aug 9 2023, 2:11 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)Aug 9 2023, 2:29 PM
zeljkofilipin moved this task from Backlog 🪒 to Waiting 🏹 on the User-zeljkofilipin board.Aug 23 2023, 4:42 PM
zeljkofilipin added a subscriber: Ollie.Shotton_WMDE.

@Ollie.Shotton_WMDE is this task a duplicate of T343886: Refactor generic Wikibase repo WebdriverIO tests from sync to async mode?

Ollie.Shotton_WMDE updated the task description. (Show Details)Aug 23 2023, 5:03 PM
Ollie.Shotton_WMDE added subtasks: T343886: Refactor generic Wikibase repo WebdriverIO tests from sync to async mode, T300807: Refactor Termbox WebdriverIO tests from sync to async mode, T293081: Refactor WikibaseLexeme WebdriverIO tests from sync to async mode.EditedAug 23 2023, 5:05 PM

Hi @zeljkofilipin, no this task is more like a parent of T343886: Refactor generic Wikibase repo WebdriverIO tests from sync to async mode. I have updated the description and related tasks to help clarify that.

Ifrahkhanyaree_WMDE removed a project: Wikibase Product Platform Team WPP.Aug 24 2023, 10:46 AM
matmarex mentioned this in T345660: wikibase@0.1.0 install:bridge fails with webpack dependency error.Tue, Sep 5, 8:32 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL