Page MenuHomePhabricator
Create Task
Maniphest T256626

Refactor WebdriverIO tests from sync to async mode
Open, Needs TriagePublic
Actions

Description

Status

✅ done 30/33 (91%)
🔨 in progress 1/33 (3%)
🔜 not started 2/33 (6%)

Description

MediaWiki Core, it's extensions and skins use WebdriverIO to drive our Selenium testing framework. All tests are written using WebdriverIO sync mode. The sync mode will be deprecated in Node.js v16. We need to move tests in MediaWiki Core, it's extensions and skins from WebdriverIO sync to async mode.

TODO

Optional

Repositories

RepositorySuitesTestsTaskStatus
mediawiki/core513T293071✅
mediawiki/extensions/AbuseFilter324T300790✅
mediawiki/extensions/AdvancedSearch541T300791✅
mediawiki/extensions/CampaignEvents✅
mediawiki/extensions/CentralNotice11T300212✅
mediawiki/extensions/CheckUser22T321904✅
mediawiki/extensions/CirrusSearch13T300793✅
mediawiki/extensions/Cite16T300196✅
mediawiki/extensions/CodeMirror35T300205✅
mediawiki/extensions/ContactPage11T334094✅
mediawiki/extensions/Echo25T293073✅
mediawiki/extensions/ElectronPdfService11T299684✅
mediawiki/extensions/FileImporter21T300535✅
mediawiki/extensions/GlobalWatchlist12T293074✅
mediawiki/extensions/GrowthExperiments27T299102✅
mediawiki/extensions/Math11T293076✅
mediawiki/extensions/Newsletter11T293078✅
mediawiki/extensions/PageTriage✅
mediawiki/extensions/Popups27T293072✅
mediawiki/extensions/ProofreadPage11T293079✅
mediawiki/extensions/RelatedArticles10T300797✅
mediawiki/extensions/RevisionSlider822T300798✅
mediawiki/extensions/TemplateWizard13T300208✅
mediawiki/extensions/TwoColConflict746T300800✅
mediawiki/extensions/VisualEditor11T299756✅
mediawiki/extensions/Wikibase1637T293080 T343886🔨
mediawiki/extensions/WikibaseLexeme1648T293081🔜
mediawiki/extensions/WikiLambda12T293082✅
mediawiki/extensions/Wikistories✅
mediawiki/skins/MinervaNeue1014T293084✅
wikibase/termbox425T300807✅
wikidata/query/gui10T300808🔜
wmde/wdio-wikibase00T300811✅

(Number of tests estimated with ack --count --files-with-matches ' it\('. See P17460.)

Notes

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
 OpenNoneT226869 Run browser tests in parallel
 OpenNoneT344754 Browser tests video capture is shared between tests
 OpenNoneT210726 Selenium framework cleanup
 OpenNoneT324685 Upgrade WebdriverIO to v8 in all repositories
 StalledNoneT324318 Update Wikibase code bases to WebdriverIO v8
 ResolvedNoneT314468 Update vite to Version 3
 OpenNoneT314470 Upgrade all CI jobs for WMF-deployed projects from Node 14 to Node 16
 OpenNoneT256626 Refactor WebdriverIO tests from sync to async mode
 DeclinedNoneT182412 Investigate if WebdriverIO `sync: false` would be useful to us and document how to use it
 ResolvedzeljkofilipinT292853 Run Selenium tests targeting MediaWiki Core in MediaWiki-Docker
 ResolvedOsamaahmed17T293071 Refactor MediaWiki Core WebdriverIO tests from sync to async mode
 ResolvedNoneT297950 npm ERR! enoent Invalid response body while trying to fetch https://registry.npmjs.org/ua-parser-js: ENOENT: no such file or directory
 ResolvedNoneT293072 Refactor Popups WebdriverIO tests from sync to async mode
 DuplicateBUG REPORTzeljkofilipinT331063 Popups browser tests failing with `08:25:51 node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed.`
 ResolvedOsamaahmed17T293073 Refactor Echo WebdriverIO tests from sync to async mode
 ResolvedzeljkofilipinT293074 Refactor GlobalWatchlist WebdriverIO tests from sync to async mode
 ResolvedNoneT293076 Refactor Math WebdriverIO tests from sync to async mode
 ResolvedNoneT293078 Refactor Newsletter WebdriverIO tests from sync to async mode
 ResolvedKrinkleT293079 Refactor ProofreadPage WebdriverIO tests from sync to async mode
 OpenNoneT293080 Refactor Wikibase WebdriverIO tests from sync to async mode
 ResolvedOllie.Shotton_WMDET343886 Refactor generic Wikibase repo WebdriverIO tests from sync to async mode
 ResolvedJakob_WMDET300807 Refactor Termbox WebdriverIO tests from sync to async mode
 StalledNoneT293081 [LEX] Refactor WikibaseLexeme WebdriverIO tests from sync to async mode
 ResolvedOsamaahmed17T293082 Refactor WikiLambda WebdriverIO tests from sync to async mode
 ResolvedvaughnwaltersT293084 Refactor MinervaNeue WebdriverIO tests from sync to async mode
 ResolvedzeljkofilipinT293258 Push a commit to Gerrit
 ResolvedzeljkofilipinT293374 Amend existing commit in Gerrit
 ResolvedzeljkofilipinT293381 Create a Wikimedia developer account
 ResolvedzeljkofilipinT293748 Introduce yourself in WebdriverIO topic in Zulip
 ResolvedkostajhT299102 Refactor GrowthExperiments WebdriverIO tests from sync to async mode
 ResolvedOsamaahmed17T299756 Refactor VisualEditor WebdriverIO tests from sync to async mode
 ResolvedOsamaahmed17T299684 Refactor ElectronPdfService WebdriverIO tests from sync to async mode
 OpenNoneT300808 Refactor wikidata/query/gui WebdriverIO tests from sync to async mode
 ResolvedpwangaiT300790 Refactor AbuseFilter WebdriverIO tests from sync to async mode
 ResolvedWMDE-FischT300791 Refactor AdvancedSearch WebdriverIO tests from sync to async mode
 ResolvedNoneT338793 Condense AdvancedSearch browser tests suite
 ResolvedOsamaahmed17T300212 Refactor CentralNotice WebdriverIO tests from sync to async mode
 ResolvedGehelT300793 Refactor CirrusSearch WebdriverIO tests from sync to async mode
 ResolvedpwangaiT300196 Refactor Cite WebdriverIO tests from sync to async mode
 ResolvedNoneT300205 Refactor CodeMirror WebdriverIO tests from sync to async mode
 InvalidpwangaiT300794 Refactor EntitySchema WebdriverIO tests from sync to async mode
 ResolvedNoneT300535 Refactor FileImporter WebdriverIO tests from sync to async mode
 InvalidNoneT300796 Refactor MobileFrontend WebdriverIO tests from sync to async mode
 ResolvedOsamaahmed17T300797 Refactor RelatedArticles WebdriverIO tests from sync to async mode
 ResolvedvaughnwaltersT300798 Refactor RevisionSlider WebdriverIO tests from sync to async mode
 ResolvedpwangaiT300208 Refactor TemplateWizard WebdriverIO tests from sync to async mode
 ResolvedNoneT300800 Refactor TwoColConflict WebdriverIO tests from sync to async mode
 InvalidNoneT300809 Refactor Deploy WebdriverIO tests from sync to async mode
 ResolvedOllie.Shotton_WMDET300811 Refactor Wdio-Wikibase WebdriverIO tests from sync to async mode
 ResolvedDreamy_JazzT321904 Refactor CheckUser WebdriverIO tests from sync to async mode
 OpenNoneT337463 Refactor wdio-mediawiki from sync to async mode

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
srishakatux removed a subscriber: srishakatux.Mar 21 2023, 7:24 AM
zeljkofilipin updated the task description. (Show Details)Mar 21 2023, 2:38 PM
pwangai changed the status of subtask T300790: Refactor AbuseFilter WebdriverIO tests from sync to async mode from Open to In Progress.Mar 21 2023, 5:28 PM
vaughnwalters moved this task from Backlog to In Progress on the User-vaughnwalters board.Mar 22 2023, 7:48 PM
pwangai closed subtask T300790: Refactor AbuseFilter WebdriverIO tests from sync to async mode as Resolved.Mar 28 2023, 3:43 PM
pwangai added a project: User-pwangai.Mar 28 2023, 3:47 PM
pwangai moved this task from Backlog to In Progress on the User-pwangai board.
pwangai updated the task description. (Show Details)
pwangai added a subscriber: pwangai.
pwangai reopened subtask T300790: Refactor AbuseFilter WebdriverIO tests from sync to async mode as In Progress.Mar 30 2023, 7:33 AM
pwangai closed subtask T300790: Refactor AbuseFilter WebdriverIO tests from sync to async mode as Resolved.Mar 30 2023, 5:12 PM
pwangai reopened subtask T300790: Refactor AbuseFilter WebdriverIO tests from sync to async mode as Open.Mar 30 2023, 5:59 PM
vaughnwalters updated the task description. (Show Details)Apr 3 2023, 5:02 PM
vaughnwalters closed subtask T300798: Refactor RevisionSlider WebdriverIO tests from sync to async mode as Resolved.
Daimona closed subtask T300790: Refactor AbuseFilter WebdriverIO tests from sync to async mode as Resolved.Apr 4 2023, 6:26 PM
pwangai updated the task description. (Show Details)Apr 5 2023, 1:33 PM
pwangai changed the status of subtask T300800: Refactor TwoColConflict WebdriverIO tests from sync to async mode from Open to In Progress.Apr 5 2023, 6:01 PM
vaughnwalters updated the task description. (Show Details)Apr 6 2023, 6:25 PM
vaughnwalters updated the task description. (Show Details)
vaughnwalters updated the task description. (Show Details)Apr 8 2023, 9:33 PM
vaughnwalters closed subtask T293084: Refactor MinervaNeue WebdriverIO tests from sync to async mode as Resolved.Apr 11 2023, 4:02 PM
vaughnwalters updated the task description. (Show Details)
pwangai updated the task description. (Show Details)Apr 11 2023, 4:05 PM
vaughnwalters updated the task description. (Show Details)Apr 11 2023, 4:06 PM
vaughnwalters updated the task description. (Show Details)Apr 11 2023, 8:31 PM
vaughnwalters updated the task description. (Show Details)Apr 13 2023, 4:10 PM
Jrbranaa moved this task from Test engineering to Test Infrastructure on the Quality-and-Test-Engineering-Team board.Apr 25 2023, 9:21 PM
Jrbranaa edited projects, added Quality-and-Test-Engineering-Team (Test Infrastructure); removed Quality-and-Test-Engineering-Team (Test engineering).
pwangai updated the task description. (Show Details)May 8 2023, 5:19 PM
zeljkofilipin claimed this task.May 19 2023, 9:09 AM
zeljkofilipin added a project: Wikimedia-Hackathon-2023.
zeljkofilipin moved this task from Backlog to Hacking projects on the Wikimedia-Hackathon-2023 board.
pwangai changed the status of subtask T300800: Refactor TwoColConflict WebdriverIO tests from sync to async mode from In Progress to Open.May 22 2023, 8:01 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.May 24 2023, 2:31 PM
zeljkofilipin removed a project: Wikimedia-Hackathon-2023.
pwangai updated the task description. (Show Details)Jun 6 2023, 9:39 AM
WMDE-Fisch updated the task description. (Show Details)Jun 6 2023, 11:28 AM
thiemowmde added a project: WMDE-TechWish-Maintenance-2023.Jun 7 2023, 12:19 PM
thiemowmde added a project: Epic.
WMDE-Fisch moved this task from Backlog to Watching / Epic on the WMDE-TechWish-Maintenance-2023 board.Jun 7 2023, 12:27 PM
WMDE-Fisch closed subtask T300205: Refactor CodeMirror WebdriverIO tests from sync to async mode as Resolved.Jun 13 2023, 8:19 AM
WMDE-Fisch closed subtask T300800: Refactor TwoColConflict WebdriverIO tests from sync to async mode as Resolved.
hashar mentioned this in T330380: Wikibase CI failing due to Node.js v16 incompatibility.Jun 14 2023, 12:59 PM
hashar mentioned this in T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.Jun 14 2023, 1:02 PM
zeljkofilipin mentioned this in Blog Post: Wikimedia Hackathon 2023, Athens, Greece.Jun 30 2023, 1:50 PM
Jbol added a subscriber: Jbol.Jul 12 2023, 1:12 PM
zeljkofilipin updated the task description. (Show Details)Jul 14 2023, 1:58 PM
zeljkofilipin mentioned this in T324766: Upgrade WebdriverIO to v8 in core.Jul 17 2023, 3:40 PM
zeljkofilipin closed subtask T300791: Refactor AdvancedSearch WebdriverIO tests from sync to async mode as Resolved.Jul 17 2023, 4:18 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jul 17 2023, 4:23 PM
zeljkofilipin updated the task description. (Show Details)Jul 17 2023, 4:28 PM
zeljkofilipin updated the task description. (Show Details)
WMDE-Fisch closed subtask T300535: Refactor FileImporter WebdriverIO tests from sync to async mode as Resolved.Jul 18 2023, 8:03 AM
pwangai updated the task description. (Show Details)Jul 18 2023, 2:54 PM
zeljkofilipin updated the task description. (Show Details)Jul 18 2023, 3:17 PM
vaughnwalters updated the task description. (Show Details)Jul 18 2023, 5:53 PM
WMDE-Fisch closed subtask T293072: Refactor Popups WebdriverIO tests from sync to async mode as Resolved.Jul 18 2023, 8:29 PM
pwangai updated the task description. (Show Details)Jul 18 2023, 8:45 PM
zeljkofilipin updated the task description. (Show Details)Jul 19 2023, 9:57 AM
zeljkofilipin closed subtask T300794: Refactor EntitySchema WebdriverIO tests from sync to async mode as Invalid.Jul 20 2023, 10:56 AM
gerritbot added a comment.Jul 26 2023, 1:38 PM

Change 941935 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/config@master] zuul: Comment-out CirrusSearch and ProofreadPage from wmf_gate

https://gerrit.wikimedia.org/r/941935

gerritbot added a project: Patch-For-Review.Jul 26 2023, 1:38 PM
gerritbot added a comment.Jul 26 2023, 1:51 PM

Change 941935 abandoned by Krinkle:

[integration/config@master] zuul: Comment-out CirrusSearch and ProofreadPage from wmf_gate

Reason:

Doesn't work because CirrusSearch is also pulled into other repos that are in the case as dependency (e.g. WikibaseCirrusSearch) where the same tests would still be discovered and run on node16. I'll try to disable them in-repo instead.

https://gerrit.wikimedia.org/r/941935

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2023, 2:10 PM
Krinkle added a comment.EditedAug 2 2023, 3:13 PM

Remaining, according to this Codeseach query:

  • ProofreadPage

Fixed in . If for some reason after Quibble upgrade this fails, I will update the patch to instead to temporarily rename selenium-test to @selenium-test in package.json, which makes CI skip the job (since it only runs the wdio tests in repos that have a script named exactly selenium-test).

  • CirrusSearch

This is already been disabled from WMF CI since 2019 (change 525647) and again this year (change 911347), so this shouldn't block. I did briefly try to upgrade Cirrus to async, but the amount of abstraction and utilities this project has made it infeasible for me to "quickly" upgrade this project as external contributor.

  • Wikibase
  • WikibaseLexeme

Similarly, I will attempt a 30-min timeboxed window to "just" upgrade these, and otherwise disable them through the above mechanism. Maintainers can then start a patch that removes the @ to re-enable them and iterate until it passes in their own time.

Beyond that, the task description does mention a few more repos, but afaik those run tests by means other than Quibble. While those are in need of migration just as well, those don't block my current work dependency chain:

  • Quibble CI moving from Node 14 to Node 16,
    • Node 16 upgrading from npm 7 to npm 8,
      • T331181: Adding Node 18 images,
        • T337647: Releasing Fresh with Node 18 support and npm 9 support.
Krinkle closed subtask T293079: Refactor ProofreadPage WebdriverIO tests from sync to async mode as Resolved.Aug 2 2023, 5:17 PM
Jdforrester-WMF updated the task description. (Show Details)Aug 2 2023, 5:19 PM
gerritbot added a comment.Aug 2 2023, 5:47 PM

Change 944967 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Wikibase@master] tests: Temporarily disable automatic running of Wdio tests in CI

https://gerrit.wikimedia.org/r/944967

gerritbot added a project: Patch-For-Review.Aug 2 2023, 5:47 PM

Change 944969 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/WikibaseLexeme@master] tests: Temporarily disable automatic running of Wdio tests in CI

https://gerrit.wikimedia.org/r/944969

gerritbot added a comment.Aug 7 2023, 7:11 PM

Change 944967 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Temporarily disable automatic running of Wdio tests in CI

https://gerrit.wikimedia.org/r/944967

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 7 2023, 8:00 PM
gerritbot added a comment.Aug 7 2023, 8:50 PM

Change 944969 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] tests: Temporarily disable automatic running of Wdio tests in CI

https://gerrit.wikimedia.org/r/944969

Maintenance_bot removed a project: Patch-For-Review.Aug 7 2023, 9:11 PM
Michael added a subscriber: Michael.Aug 8 2023, 9:45 AM
dcausse updated the task description. (Show Details)Aug 10 2023, 8:20 PM
Gehel closed subtask T300793: Refactor CirrusSearch WebdriverIO tests from sync to async mode as Resolved.Aug 11 2023, 9:34 AM
zeljkofilipin updated the task description. (Show Details)Aug 11 2023, 11:35 AM
Michael mentioned this in T344140: [LEX] [TECH] Decide on how to move forward with daily Lexeme browser tests.Aug 14 2023, 8:57 AM
zeljkofilipin mentioned this in T344682: Run Selenium tests targeting available local and remote testing environments.Aug 22 2023, 12:58 PM
Jakob_WMDE closed subtask T300807: Refactor Termbox WebdriverIO tests from sync to async mode as Resolved.Aug 23 2023, 10:45 AM
zeljkofilipin updated the task description. (Show Details)Aug 23 2023, 4:38 PM
zeljkofilipin added a subtask: T343886: Refactor generic Wikibase repo WebdriverIO tests from sync to async mode.Aug 23 2023, 4:44 PM
zeljkofilipin updated the task description. (Show Details)
Ollie.Shotton_WMDE closed subtask T300811: Refactor Wdio-Wikibase WebdriverIO tests from sync to async mode as Resolved.Aug 23 2023, 5:12 PM
zeljkofilipin updated the task description. (Show Details)Aug 24 2023, 12:55 PM
zeljkofilipin updated the task description. (Show Details)Aug 24 2023, 1:03 PM
zeljkofilipin removed a subtask: T293081: [LEX] Refactor WikibaseLexeme WebdriverIO tests from sync to async mode.Aug 24 2023, 1:08 PM
zeljkofilipin mentioned this in T344754: Browser tests video capture is shared between tests.Aug 24 2023, 1:20 PM
hashar added a subscriber: hashar.Aug 31 2023, 1:19 PM

Migrate out of sync mode in favor of async was to get rid of wdio-sync and fibers which is no more supported on NodeJS 16.

As part of T314470: Upgrade all CI jobs for WMF-deployed projects from Node 14 to Node 16, the Quibble jobs have been migrated from NodeJS 14 to 16 (the task is still open cause we have to migrate the other npm test jobs, but for Selenium that is done). Talking with James, looks like all tests got fixed and the few repositories left over (sub task of this task) had their tests disabled.

So essentially it is done with sub tasks being the long tail left over things to fix up / restore.

vaughnwalters moved this task from In Progress to Backlog on the User-vaughnwalters board.Sep 1 2023, 5:39 AM
Krinkle removed a subscriber: Krinkle.Sep 1 2023, 10:39 PM
WMDE-Fisch removed a project: WMDE-TechWish-Maintenance-2023.Oct 11 2023, 12:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL