Page MenuHomePhabricator
Create Task
Maniphest T294675

Some global preference values will not save
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enable and set a global pref value for example fields: showhiddencats, allowemail
  • Save
  • Attempt to toggle the on/off value
  • Save

What happens?:
*The new value is not saved

What should have happened instead?:
*The new value should be saved

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Screenshot:

image.png (544×753 px, 17 KB)

Uncheck the RIGHT checkbox, click save -- the value is NOT saved.

This is breaking things that are set globally (such as allow me to be emailed) that users have not configured locally.

Details

SubjectRepoBranchLines +/-
Change the way of fetching global preferences for Special:GlobalPreferencesmediawiki/extensions/GlobalPreferencesREL1_37+12 -73
Fix support for setting local exceptions on CheckMatrix fieldsmediawiki/extensions/GlobalPreferencesmaster+1 -1
Change the way of fetching global preferences for Special:GlobalPreferencesmediawiki/extensions/GlobalPreferencesmaster+12 -73
Customize query in gerrit

Related Objects

Event Timeline

Xaosflux created this task.Oct 29 2021, 11:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2021, 11:50 PM
Xaosflux added a comment.Oct 29 2021, 11:56 PM

Possible relation to: T289931 , T250379 , T286271 , T262879 ? Is there a much larger problem going on with global preferences such that we should be bannering the preferences page to warn users to not rely on them for anything?

Xaosflux added a project: MediaWiki-extensions-GlobalPreferences.Oct 29 2021, 11:57 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptOct 29 2021, 11:57 PM
IKhitron subscribed.Oct 30 2021, 12:09 AM
Dylsss subscribed.Oct 30 2021, 12:17 AM

I cannot reproduce simply following those steps, I can enable and set a new global preference field and toggle it on/off fine, however if I then edit any local preference, those global preferences I just edited become in a stuck state like observed in this task.

What's weird is that they only become stuck in that wiki, so I can go to another wiki and edit that global preference, and now I have different global preferences on different wikis. It makes global preferences almost unusable IMO.

Xaosflux added a comment.Oct 30 2021, 12:29 AM

@Dylsss - thank you for the additional information - I'm quite sure some of my global prefs simply "stopped inheriting" locally when I saved something unrelated locally - for example was wondering "why can't I see hidden categories on this project anymore" - and it was this situation.

Xaosflux mentioned this in T286271: Globally set preferences no longer greyed out in local preferences.Nov 2 2021, 4:40 PM
Func subscribed.Nov 9 2021, 1:43 PM

It seems that after setting any local exception once, checkboxes in Special:GlobalPreferences were controlled by the local preferences, whether the checkbox of "set a local exception" is checked or not. Fortunately, it wouldn't affect the global database.

I set the global preferences on mediawikiwiki and monitor them on metawiki where I haven't set a local exception yet, the Special:GlobalPreferences on mediawikiwiki works, but wouldn't represent correct checkboxes after saving.

gerritbot added a comment.Nov 10 2021, 7:57 AM

Change 737698 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GlobalPreferences@master] Change the way of fetching global preferences for special pages

https://gerrit.wikimedia.org/r/737698

gerritbot added a project: Patch-For-Review.Nov 10 2021, 7:57 AM
MusikAnimal mentioned this in T262879: Global Preferences can not be saved any more.Nov 10 2021, 8:39 PM
MusikAnimal merged a task: T262879: Global Preferences can not be saved any more.
MusikAnimal added subscribers: MusikAnimal, Samwilson, ifried and 2 others.
gerritbot added a comment.Nov 11 2021, 7:50 AM

Change 737698 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Change the way of fetching global preferences for Special:GlobalPreferences

https://gerrit.wikimedia.org/r/737698

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 11 2021, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 11 2021, 8:10 AM
MusikAnimal added a comment.Nov 18 2021, 9:14 PM

The issue as described seems to be fixed now, but I'm finding some global preferences cannot be given local exceptions. I've filed T296028: Unable to set a local override for some Global Preferences for that.

Func closed this task as Resolved.Nov 19 2021, 3:04 PM
Func claimed this task.
Ericliu1912 subscribed.Nov 19 2021, 3:05 PM
Xaosflux added a comment.EditedNov 19 2021, 5:20 PM

Is this resolved in that the condition should no longer be occurring in WMF production wikis, or just that software that will eventually make this work is ready?

Because I'm still seeing problems in production.

Xaosflux added a comment.Nov 19 2021, 5:24 PM

Steps to reproduce:

  1. Go to preferences: https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-watchlist
  2. View the value of "Use non-JavaScript interface" (currently UNCHECKED, local exception box: UNCHECKED)
  3. Go to global preferences: https://en.wikipedia.org/wiki/Special:GlobalPreferences#mw-prefsection-watchlist
  4. See "Use non-Javascript interface" current state (currently GLOBAL checked, value:unchecked)
  5. Click value to CHECKED
  6. Click SAVE
  7. Page reloads - FAIL

Result: "Use non-Javascript interface" is still (currently GLOBAL checked, value:unchecked)

Expected Result: "Use non-Javascript interface" is still (currently GLOBAL checked, value:checked)

Xaosflux reopened this task as Open.Nov 19 2021, 5:24 PM

Screen shot:

image.png (151×769 px, 7 KB)

Xaosflux added a comment.Nov 19 2021, 5:26 PM

Note: uncheck global, save, recheck both global and value, save: also fails in to same state: global:on,value:off

JJMC89 closed this task as Resolved.Nov 19 2021, 5:28 PM
JJMC89 subscribed.

The fix is in 1.38.0-wmf.9, but enwiki is on 1.38.0-wmf.7.

Xaosflux added a comment.Nov 19 2021, 5:30 PM

Thanks - will check again in 2 releases - as I continue to ruminate on why we don't have an incident management system......

Aklapper added a comment.Nov 19 2021, 5:55 PM

@Xaosflux: I'd say we have some incident management systems (but that term likely depends on definitions and expectations).
If you would like to elaborate a bit, that would probably be a good fit for the wikitech-l mailing list.

Legoktm subscribed.Nov 19 2021, 8:59 PM

If it cleanly cherry-picks, it should probably be backported to wmf.7 as the fate of wmf.9 is still up in the air.

MusikAnimal merged a task: T274066: User Gender is not correctly set sometimes.Nov 22 2021, 10:34 PM
MusikAnimal added subscribers: LaMagiaaa, Tacsipacsi.
Func mentioned this in T294554: New Vector skin conflicts with custom user settings.Dec 15 2021, 3:22 AM
gerritbot added a comment.Dec 15 2021, 4:18 PM

Change 747477 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GlobalPreferences@master] Fix support for setting local exceptions on CheckMatrix fields

https://gerrit.wikimedia.org/r/747477

gerritbot added a project: Patch-For-Review.Dec 15 2021, 4:18 PM
Func mentioned this in T297859: Convert the GlobalPreferences\Storage class to GlobalUserOptionsManager or something compatible with UserOptionsManager.Dec 16 2021, 3:53 AM
Ericliu1912 mentioned this in T298426: Structured Discussions workflow is not associated with talk page.Jan 1 2022, 5:51 PM
Func mentioned this in T298614: "Notify me about these events" ignores global preferences settings, even unable to change via Global Preferences.Jan 8 2022, 3:40 PM
gerritbot added a comment.Jan 8 2022, 4:07 PM

Change 747477 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Fix support for setting local exceptions on CheckMatrix fields

https://gerrit.wikimedia.org/r/747477

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2022, 4:10 PM
gerritbot added a comment.Jan 11 2022, 3:11 PM

Change 753067 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GlobalPreferences@REL1_37] Change the way of fetching global preferences for Special:GlobalPreferences

https://gerrit.wikimedia.org/r/753067

gerritbot added a project: Patch-For-Review.Jan 11 2022, 3:11 PM
gerritbot added a comment.Jan 12 2022, 3:27 PM

Change 753067 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@REL1_37] Change the way of fetching global preferences for Special:GlobalPreferences

https://gerrit.wikimedia.org/r/753067

Func merged a task: T294554: New Vector skin conflicts with custom user settings.Jan 15 2022, 2:07 AM
Func added subscribers: Unite_together, Jdlrobson.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits