Page MenuHomePhabricator

Rendering difference between legacy and Parsoid with <translate> tags around a heading
Closed, ResolvedPublicBUG REPORT

Description

Given

<translate>==test==</translate>

When rendered with the legacy parser, "test" is a heading (since the translate tags are stripped by the translate extension).
When rendered with Parsoid, we get

<p data-parsoid='{"dsr":[0,31,0,0]}'><meta typeof="mw:Annotation/translate" data-parsoid='{"dsr":[0,11,null,null]}' data-mw='{"rangeId":"mwa0","extendedRange":false,"wtOffsets":[0,11]}'/>==test==<meta typeof="mw:Annotation/translate/End" data-parsoid='{"dsr":[19,31,null,null]}' data-mw='{"wtOffsets":[19,31]}'/></p>

in which ==test== is a paragraph.

Related Objects

StatusSubtypeAssignedTask
OpenReleaseNone
OpenNone
OpenNone
OpenNone
OpenFeatureNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedEsanders
OpenFeatureNone
Resolvedihurbain
Resolvedihurbain
ResolvedBUG REPORTihurbain

Event Timeline

This syntax is discouraged, even with legacy parser, because it breaks section editing.
So I think Parsoid doesn’t need to support it.

Aha ... okay then!

@Nikerabbit, @Pols12, why is == <translate>Culture</translate> == discouraged? If anything, to me, that seems like the ideal way to mark a section title for translation.

The page seems to indicate

<translate>

Heading

</translate>

Right. I am asking why the inline form ==<translate>foo</translate>== is discouraged.

Two reasons:

  1. It used to break edit section links - this might have been fixed these days
  2. In "page translation view" you can see the headings as such. See e.g. https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-Help%3AContents&action=page&filter=&language=fi

Change 764805 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Do not break heading detection on annotations

https://gerrit.wikimedia.org/r/764805

Change 764805 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Do not break heading detection on annotations

https://gerrit.wikimedia.org/r/764805

Change 768825 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a23

https://gerrit.wikimedia.org/r/768825

Change 768825 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a23

https://gerrit.wikimedia.org/r/768825