From the last attempt at T315353. 157 occurrences in ~10 minutes before we reverted: https://logstash.wikimedia.org/goto/a734c099589019f597dc3e7b34813884
Sample errors:
Error 1062: Duplicate entry 'h-Tech_News:_2021-07' for key 'itid_itemid'
Error 1062: Duplicate entry 'h-EranBot-2021-03-06T21:20:00.000Z' for key 'it_itemname'
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T314973 Improve Topic Subscription support for discussions that are merged, moved, or deleted | |||
| Open | None | T315050 Enable people to visit the page the discussion they were subscribed to has been moved to | |||
| Open | None | T318449 [Tracking] Improve the sharing of MediaWiki content | |||
| Open | None | T318446 [Tracking] Improve sharing link functionality of pages | |||
| Open | None | T315507 Introduce support for topic and comment permanent links within the Android and iOS apps | |||
| Open | None | T349353 Expose comment/topic permanent links on Special:Contributions | |||
| Open | None | T265269 Assist with linking to other comments within the Reply Tool | |||
| Open | None | T302011 [Release Ticket] Introduce permalinks on wikitext talk pages | |||
| Open | DLynch | T365974 Deploy talk page permalinks to en.wiki | |||
| Resolved | matmarex | T315353 Create database tables for permalinks in production wikis, and enable the feature | |||
| Resolved | matmarex | T322701 Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry '…' for key 'itid_itemid' / 'it_itemname' |
Change 854647 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] ThreadItemStore: Handle race conditions when finding/inserting outside of transaction
What slightly worries me is that in five minutes it had 70 cases, it is possible to have race conditions but not that many. Maybe we can work on deduplicating the job if a newer edit happens and takes care of it?
Indeed, I was not really expecting this to happen at all. I don't control the jobs though, there could be a deeper issue here but I don't very much want to get into it (I'm not even sure what kind of a job it is, our code just uses the RevisionDataUpdates hook). It could also just have been a fluke, caused by identical content being transcluded on different pages that were processed at (almost) the same time.
Change 854647 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ThreadItemStore: Handle race conditions when finding/inserting outside of transaction
Change 855744 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.8] ThreadItemStore: Handle race conditions when finding/inserting outside of transaction
Change 855744 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.8] ThreadItemStore: Handle race conditions when finding/inserting outside of transaction
Mentioned in SAL (#wikimedia-operations) [2022-11-14T14:14:24Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:856550|Use legacy DiscussionTools heading markup except on beta cluster (T314714)]], [[gerrit:855744|ThreadItemStore: Handle race conditions when finding/inserting outside of transaction (T322701)]], [[gerrit:855745|persistRevisionThreadItems: Print time taken]]
Mentioned in SAL (#wikimedia-operations) [2022-11-14T14:14:44Z] <taavi@deploy1002> taavi and matmarex: Backport for [[gerrit:856550|Use legacy DiscussionTools heading markup except on beta cluster (T314714)]], [[gerrit:855744|ThreadItemStore: Handle race conditions when finding/inserting outside of transaction (T322701)]], [[gerrit:855745|persistRevisionThreadItems: Print time taken]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmn
Mentioned in SAL (#wikimedia-operations) [2022-11-14T14:20:39Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:856550|Use legacy DiscussionTools heading markup except on beta cluster (T314714)]], [[gerrit:855744|ThreadItemStore: Handle race conditions when finding/inserting outside of transaction (T322701)]], [[gerrit:855745|persistRevisionThreadItems: Print time taken]] (duration: 06m 14s)