"Duplicate entry '0-XXX' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`"
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	matmarex
	Nov 14 2022, 10:09 PM

Description

(The latest deployment of DiscussionTools permalinks backend to group1 wikis T315353#8392662 has resulted in some new errors, although a lot less numerous this time. It really is a gift that keeps on giving.)

There are a few occurrences of "Duplicate entry '0-XXX' for key 'itr_itemid_id_revision_id'" (where "0" is in fact always 0, and "XXX" is different revision IDs).

https://logstash.wikimedia.org/goto/acc9b5e141d0d86a3ca1e940c4178c5c

This looks like a bug in our code – that value should not be zero.

(This is distinct from T323080: "Duplicate entry 'XXX-YYY' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`")

Related Objects
Search...

Status	Assigned	Task
Open	None	T249579 [EPIC] Usability improvements: make the actions, activity and content within talk pages easier to understand
Open	None	T269950 [EPIC] Topic Containers
Open	None	T295431 Enable Special:TopicSubscriptions Contents to Update Automatically
Open	None	T314973 Improve Topic Subscription support for discussions that are merged, moved, or deleted
Open	None	T315050 Enable people to visit the page the discussion they were subscribed to has been moved to
Open	None	T294592 [EPIC] Ensure Talk Pages Project "Phase 1" work is easy to maintain, build upon, and learn from
Open	None	T315507 Introduce support for topic and comment permanent links within the Android and iOS apps
Open	None	T318449 [Tracking] Improve the sharing of MediaWiki content
Open	None	T318446 [Tracking] Improve sharing link functionality of pages
Open	None	T302011 [Release Ticket] Introduce permalinks on wikitext talk pages
Open	nayoub	T275729 Comment permalinks: design and implement user experience
Open	None	T306373 Update Special:TopicSubscriptions to use permalinks
Open	None	T273341 Topic permalinks: design and implement user experience
Resolved	matmarex	T274685 Comment IDs that reliably identify the comment across revisions/pages (comment names)
Open	matmarex	T315510 Start maintenance script to backfill talk page comment database
Open	matmarex	T315353 Create database tables for permalinks in production wikis, and enable the feature
Resolved	matmarex	T296801 Introduce a data structure for tracking talk page comments
Resolved	matmarex	T303295 DBA review: data structure for storing permalinks
Open	None	T323079 "Duplicate entry '0-XXX' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`"

Event Timeline

matmarex created this task.Nov 14 2022, 10:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2022, 10:09 PM

matmarex updated the task description. (Show Details)Nov 14 2022, 10:11 PM

matmarex mentioned this in T323080: "Duplicate entry 'XXX-YYY' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`".

matmarex added a project: Wikimedia-production-error.

matmarex added a parent task: T315353: Create database tables for permalinks in production wikis, and enable the feature.

This seems to be caused by the fix for T322701 (rEDTO08e1073f58b6: ThreadItemStore: Handle race conditions when finding/inserting outside of…).

The only way for the code to try inserting 0 into itr_itemid_id is if the insertId() call after the upsert() returns 0. I thought that it would return the ID of the inserted/updated row. Is that not the case?

brennen added a project: User-brennen.Nov 15 2022, 5:39 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Nov 17 2022, 4:08 PM

ppelberg added a project: Editing-team.

ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.

Krinkle moved this task from Untriaged to Nov 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:54 PM