Page MenuHomePhabricator
Create Task
Maniphest T323079

"Duplicate entry '0-XXX' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`"
Closed, ResolvedPublic
Actions

Description

(The latest deployment of DiscussionTools permalinks backend to group1 wikis T315353#8392662 has resulted in some new errors, although a lot less numerous this time. It really is a gift that keeps on giving.)

There are a few occurrences of "Duplicate entry '0-XXX' for key 'itr_itemid_id_revision_id'" (where "0" is in fact always 0, and "XXX" is different revision IDs).

https://logstash.wikimedia.org/goto/acc9b5e141d0d86a3ca1e940c4178c5c

image.png (523×2 px, 50 KB)

This looks like a bug in our code – that value should not be zero.

(This is distinct from T323080: "Duplicate entry 'XXX-YYY' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`")

Related Objects
Search...

Event Timeline

matmarex created this task.Nov 14 2022, 10:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2022, 10:09 PM
matmarex updated the task description. (Show Details)Nov 14 2022, 10:11 PM
matmarex mentioned this in T323080: "Duplicate entry 'XXX-YYY' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`".
matmarex added a project: Wikimedia-production-error.
matmarex added a parent task: T315353: Create database tables for permalinks in production wikis, and enable the feature.
matmarex added a comment.Nov 14 2022, 10:37 PM

This seems to be caused by the fix for T322701 (rEDTO08e1073f58b6: ThreadItemStore: Handle race conditions when finding/inserting outside of…).

The only way for the code to try inserting 0 into itr_itemid_id is if the insertId() call after the upsert() returns 0. I thought that it would return the ID of the inserted/updated row. Is that not the case?

brennen added a project: User-brennen.Nov 15 2022, 5:39 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Nov 17 2022, 4:08 PM
ppelberg added a project: Editing-team.
ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.
Krinkle moved this task from Untriaged to Nov 2022 on the Wikimedia-production-error board.Nov 17 2022, 4:54 PM
matmarex mentioned this in T339882: Bad rows in discussiontools_item_pages, discussiontools_item_revisions with itp_items_id, itr_itemid_id, itr_items_id equal to 0.Jun 19 2023, 9:04 PM
Krinkle mentioned this in T341811: DBQueryError: "Duplicate entry … for key 'itp_items_id_page_id'" in "INSERT INTO `discussiontools_item_pages`".Jul 13 2023, 3:23 PM
matmarex closed this task as Resolved.Jul 31 2023, 12:09 PM
matmarex claimed this task.

Resolved by the fix for T339882 in last week's deployment:

https://logstash.wikimedia.org/goto/c635a356997ebc55ae75e8dd10b811d2

image.png (529×2 px, 87 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits