Page MenuHomePhabricator
Create Task
Maniphest T330210

1.41.0-wmf.4 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
hashar
Release Version
1.41.0-wmf.4
Release Date
Apr 10 2023, 12:00 AM

2023 week 15 1.41-wmf.4 Changes wmf/1.41.0-wmf.4

This MediaWiki Train Deployment is scheduled for the week of Monday, April 10th:

Monday April 10thTuesday, April 11thWednesday, April 12thThursday, April 13thFriday
Backports only.Branch wmf.4 and deploy to Group 0 Wikis.Deploy wmf.4 to Group 1 Wikis.Deploy wmf.4 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.4 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.3
Next: 1.41.0-wmf.5
SubjectRepoBranchLines +/-
all wikis to 1.41.0-wmf.4operations/mediawiki-configmaster+328 -328
group2 wikis to 1.41.0-wmf.3operations/mediawiki-configmaster+328 -328
all wikis to 1.41.0-wmf.4operations/mediawiki-configmaster+328 -328
group2 wikis to 1.41.0-wmf.3operations/mediawiki-configmaster+328 -328
group2 wikis to 1.40.1-wmf.3operations/mediawiki-configmaster+328 -328
all wikis to 1.41.0-wmf.4operations/mediawiki-configmaster+328 -328
group1 wikis to 1.41.0-wmf.4operations/mediawiki-configmaster+542 -542
group0 wikis to 1.41.0-wmf.4operations/mediawiki-configmaster+129 -129
testwikis wikis to 1.41.0-wmf.4operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.41.0-wmf.4mediawiki/corewmf/1.41.0-wmf.4+991 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Feb 21 2023, 5:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2023, 5:57 PM
thcipriani assigned this task to • demon.Mar 24 2023, 9:48 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: hashar.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Ladsgroup added a subtask: T333966: message keys shown on beta and group0 wikis (test Wikidata, etc.).Apr 4 2023, 5:25 PM
Jdforrester-WMF closed subtask T333966: message keys shown on beta and group0 wikis (test Wikidata, etc.) as Resolved.Apr 4 2023, 8:14 PM
hashar subscribed.Apr 8 2023, 6:50 AM

The train branch bot has cut a wmf/branch_cut_pretest which caused multiple issue in the previous train. I have gathered them at T334322: wmf/branch_cut_pretest branch on mediawiki/core causes multiple problems.

At least the Tuesday branch cut should be solved

gerritbot added a comment.Apr 11 2023, 2:08 AM

Change 906704 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.4] Branch commit for wmf/1.41.0-wmf.4

https://gerrit.wikimedia.org/r/906704

gerritbot added a project: Patch-For-Review.Apr 11 2023, 2:08 AM
gerritbot added a comment.Apr 11 2023, 2:24 AM

Change 906704 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.4] Branch commit for wmf/1.41.0-wmf.4

https://gerrit.wikimedia.org/r/906704

gerritbot added a comment.Apr 11 2023, 3:01 AM

Change 907560 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/907560

gerritbot added a comment.Apr 11 2023, 3:02 AM

Change 907560 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/907560

Stashbot added a comment.Apr 11 2023, 3:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-04-11T03:02:31Z] <mwpresync@deploy2002> Started scap: testwikis wikis to 1.41.0-wmf.4 refs T330210

Stashbot added a comment.Apr 11 2023, 3:52 AM

Mentioned in SAL (#wikimedia-operations) [2023-04-11T03:52:28Z] <mwpresync@deploy2002> Finished scap: testwikis wikis to 1.41.0-wmf.4 refs T330210 (duration: 49m 57s)

jcrespo subscribed.Apr 11 2023, 2:10 PM

Potential file upload breakage? https://wikitech.wikimedia.org/wiki/File:Dbbackups_dashboard_status.png I think that is group 0, after uploading a file, it consistently says the file doesn't exist, but if I try to overwrite it, it say it is duplicate. Not 100% sure it is train related, just a guess. Asking for help/opinions if it merits reporting it as a blocker.

jcrespo added a comment.Apr 11 2023, 2:25 PM

I cannot reproduce it on testwiki: https://test.wikipedia.org/wiki/File:Screenshot_20230411_155210.png so it must be something else.

thcipriani added a comment.Apr 11 2023, 2:47 PM
In T330210#8771393, @jcrespo wrote:

Potential file upload breakage? https://wikitech.wikimedia.org/wiki/File:Dbbackups_dashboard_status.png I think that is group 0, after uploading a file, it consistently says the file doesn't exist, but if I try to overwrite it, it say it is duplicate. Not 100% sure it is train related, just a guess. Asking for help/opinions if it merits reporting it as a blocker.

Wikitech is a group1 wiki (labswiki), so it will get the new version on Wednesday (only testwiki has wmf.4 at the moment—https://versions.toolforge.org/ is the easiest way to check).

So, either breakage from last week (wmf.3) that no one noticed. Or something else entirely.

Probably worth filing for wikitech.wikimedia.org as something to investigate.

jcrespo added a comment.Apr 11 2023, 3:00 PM
In T330210#8771551, @thcipriani wrote:
In T330210#8771393, @jcrespo wrote:

Potential file upload breakage? https://wikitech.wikimedia.org/wiki/File:Dbbackups_dashboard_status.png I think that is group 0, after uploading a file, it consistently says the file doesn't exist, but if I try to overwrite it, it say it is duplicate. Not 100% sure it is train related, just a guess. Asking for help/opinions if it merits reporting it as a blocker.

Wikitech is a group1 wiki (labswiki), so it will get the new version on Wednesday (only testwiki has wmf.4 at the moment—https://versions.toolforge.org/ is the easiest way to check).

So, either breakage from last week (wmf.3) that no one noticed. Or something else entirely.

Probably worth filing for wikitech.wikimedia.org as something to investigate.

Thanks.

jcrespo added a comment.Apr 11 2023, 3:32 PM

Done at https://phabricator.wikimedia.org/T334487

gerritbot added a comment.Apr 11 2023, 6:31 PM

Change 907941 had a related patch set uploaded (by TrainBranchBot; author: Chad Horohoe):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/907941

gerritbot added a comment.Apr 11 2023, 6:32 PM

Change 907941 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/907941

Stashbot added a comment.Apr 11 2023, 6:38 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-11T18:38:47Z] <demon@deploy2002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.4 refs T330210

hashar added a subtask: T334551: action=help&toc=1: Caught exception of type TypeError.Apr 12 2023, 10:12 AM

Added T334551: action=help&toc=1: Caught exception of type TypeError as a potential train blocker. It has a low frequency but I don't know anything about its potential impact :)

gerritbot added a comment.Apr 12 2023, 6:02 PM

Change 908314 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/908314

gerritbot added a comment.Apr 12 2023, 6:03 PM

Change 908314 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/908314

Stashbot added a comment.Apr 12 2023, 6:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-12T18:10:27Z] <dancy@deploy2002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.4 refs T330210

Stashbot added a comment.Apr 12 2023, 6:16 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-12T18:16:29Z] <dancy@deploy2002> Synchronized php: group1 wikis to 1.41.0-wmf.4 refs T330210 (duration: 06m 02s)

• ssastry removed a subtask: T334551: action=help&toc=1: Caught exception of type TypeError.Apr 12 2023, 6:25 PM
gerritbot added a comment.Apr 13 2023, 6:24 PM

Change 908613 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] all wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/908613

gerritbot added a comment.Apr 13 2023, 6:25 PM

Change 908613 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/908613

Stashbot added a comment.Apr 13 2023, 6:34 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-13T18:34:18Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: all wikis to 1.41.0-wmf.4 refs T330210

gerritbot added a comment.Apr 13 2023, 6:42 PM

Change 908615 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.40.1-wmf.3

https://gerrit.wikimedia.org/r/908615

gerritbot added a comment.Apr 13 2023, 6:42 PM

Change 908615 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.40.1-wmf.3

https://gerrit.wikimedia.org/r/908615

gerritbot added a comment.Apr 13 2023, 6:46 PM

Change 908616 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.3

https://gerrit.wikimedia.org/r/908616

gerritbot added a comment.Apr 13 2023, 6:46 PM

Change 908616 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.3

https://gerrit.wikimedia.org/r/908616

Stashbot added a comment.Apr 13 2023, 7:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-13T19:03:27Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.3 refs T330210

gerritbot added a comment.Apr 13 2023, 7:49 PM

Change 908623 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] all wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/908623

gerritbot added a comment.Apr 13 2023, 7:50 PM

Change 908623 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/908623

Stashbot added a comment.Apr 13 2023, 7:55 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-13T19:55:16Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: all wikis to 1.41.0-wmf.4 refs T330210

gerritbot added a comment.Apr 13 2023, 7:57 PM

Change 908624 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.3

https://gerrit.wikimedia.org/r/908624

gerritbot added a comment.Apr 13 2023, 7:58 PM

Change 908624 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.3

https://gerrit.wikimedia.org/r/908624

brennen added a subtask: T334699: Links cannot be clicked while logged in on English Wikipedia at 1.41.0-wmf.4.Apr 13 2023, 8:09 PM
Stashbot added a comment.Apr 13 2023, 8:15 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-13T20:15:08Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.3 refs T330210

gerritbot added a comment.Apr 13 2023, 9:04 PM

Change 908630 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] all wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/908630

gerritbot added a comment.Apr 13 2023, 9:05 PM

Change 908630 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.41.0-wmf.4

https://gerrit.wikimedia.org/r/908630

Stashbot added a comment.Apr 13 2023, 9:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-13T21:10:25Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: all wikis to 1.41.0-wmf.4 refs T330210

brennen closed this task as Resolved.Apr 13 2023, 9:31 PM
brennen closed subtask T334699: Links cannot be clicked while logged in on English Wikipedia at 1.41.0-wmf.4 as Resolved.
brennen subscribed.

Logs look good, blockers resolved.

Krinkle mentioned this in T321634: Re-evaluate need for "cool-off bounce" in WANObjectCache.Apr 17 2023, 6:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL