Page MenuHomePhabricator
Create Task
Maniphest T372709

Missing cite error message and category
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ihurbain
Authored By
Quiddity
Aug 17 2024, 6:29 PM
Project Tags
Referenced Files
F57278320: image.png
Aug 17 2024, 6:29 PM
Subscribers
Aklapper
awight
Johannes_Richter_WMDE
Lina_Farid_WMDE
Quiddity
thiemowmde

Description

Steps to replicate the issue:

or a simpler test-case at

What happens?:
Citation errors aren't shown, nor is the category.

image.png (1,723×1,359 px, 574 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Serialize errors as DataMwError instead of MessageValuemediawiki/extensions/Citemaster+54 -56
[POC] Drop extra error about list-defined ref without contentmediawiki/extensions/Citemaster+12 -15
Add error spans on referencesmediawiki/extensions/Citemaster+30 -1
Display Cite error messages in Parsoidmediawiki/extensions/Citemaster+198 -48
Handle MessageValue as parameters of I18nInfomediawiki/coremaster+48 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Quiddity created this task.Aug 17 2024, 6:29 PM
Restricted Application added a project: Parsoid. · View Herald TranscriptAug 17 2024, 6:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ssastry added a project: Content-Transform-Team.Aug 20 2024, 8:34 PM
thiemowmde added projects: WMDE-TechWish-Sprint-2024-08-13, WMDE-References-FocusArea.Aug 21 2024, 7:50 AM
thiemowmde moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2024-08-13 board.
thiemowmde added subscribers: thiemowmde, Lina_Farid_WMDE, awight, WMDE-Fisch.
thiemowmde added a project: WMDE-TechWish-Sprint-2024-08-21.Aug 21 2024, 12:20 PM
thiemowmde moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2024-08-21 board.
gerritbot added a comment.Aug 22 2024, 12:26 PM

Change #1064745 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Cite@master] Add error spans on references

https://gerrit.wikimedia.org/r/1064745

gerritbot added a project: Patch-For-Review.Aug 22 2024, 12:26 PM
MSantos edited projects, added: Content-Transform-Team-WIP; removed: Content-Transform-Team.Aug 22 2024, 2:19 PM
MareikeHeuerWMDE moved this task from Incoming to In progress on the WMDE-References-FocusArea board.Aug 23 2024, 8:32 AM
MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Aug 29 2024, 2:31 PM
MSantos edited projects, added: Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed: Parsoid-Read-Views.
ihurbain claimed this task.Sep 10 2024, 4:28 PM
awight moved this task from In progress to Watching on the WMDE-References-FocusArea board.Sep 18 2024, 1:03 PM
gerritbot added a comment.Sep 19 2024, 5:02 PM

Change #1071914 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Cite@master] Display Cite error messages in Parsoid

https://gerrit.wikimedia.org/r/1071914

SLopes-WMF moved this task from Needs Triage to Missing Functionality on the Parsoid board.Sep 26 2024, 2:20 PM
WMDE-Fisch unsubscribed.Oct 7 2024, 11:19 AM
ihurbain moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Oct 15 2024, 2:28 PM
gerritbot added a comment.Oct 15 2024, 2:41 PM

Change #1080303 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] WIP: handle MessageValue as parameters of I18nInfo

https://gerrit.wikimedia.org/r/1080303

ssastry mentioned this in T378229: Roll out Parsoid readviews on dagwiki.Oct 25 2024, 8:28 PM
ssastry added a parent task: T378477: [EPIC] Roll-out Parsoid to Incubator Wikis and newly created wikis.Oct 30 2024, 3:13 PM
ssastry added a parent task: T378229: Roll out Parsoid readviews on dagwiki.
gerritbot added a comment.Nov 7 2024, 10:07 AM

Change #1068770 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] [POC] Drop extra error about list-defined ref without content

https://gerrit.wikimedia.org/r/1068770

gerritbot added a comment.Nov 7 2024, 2:02 PM

Change #1088295 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] [POC] Drop error message when running out of backlink labels

https://gerrit.wikimedia.org/r/1088295

gerritbot added a comment.Nov 9 2024, 3:02 AM

Change #1080303 merged by jenkins-bot:

[mediawiki/core@master] Handle MessageValue as parameters of I18nInfo

https://gerrit.wikimedia.org/r/1080303

gerritbot added a comment.Nov 9 2024, 3:10 AM

Change #1071914 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Display Cite error messages in Parsoid

https://gerrit.wikimedia.org/r/1071914

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Nov 9 2024, 4:00 AM
cscott moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.Nov 12 2024, 3:16 PM
cscott moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.
ihurbain closed this task as Resolved.Nov 15 2024, 5:46 PM
ihurbain closed subtask T378386: Create tracking category cite-tracking-category-cite-diffing-error as Resolved.
ihurbain added a subtask: T380153: Multiple identical errors reported in Cite with Parsoid.Nov 18 2024, 12:49 PM
ihurbain closed subtask T380153: Multiple identical errors reported in Cite with Parsoid as Resolved.Nov 25 2024, 4:13 PM
gerritbot added a comment.Dec 16 2024, 3:21 PM

Change #1064745 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/extensions/Cite@master] Add error spans on references

Reason:

In favor of Ifeb3b21

https://gerrit.wikimedia.org/r/1064745

ihurbain added a subtask: T381182: Cite error reporting discrepancy (for auto-generated references section with a group attribute) between Parsoid & legacy versions.Jan 9 2025, 10:08 AM
gerritbot added a comment.Feb 13 2025, 10:01 AM

Change #1068770 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] [POC] Drop extra error about list-defined ref without content

https://gerrit.wikimedia.org/r/1068770

ihurbain closed subtask T380045: Cite error messages contain escaped HTML as Resolved.Feb 18 2025, 9:35 AM
ihurbain closed subtask T380152: Cite error discrepancy between legacy parser and parsoid on ukwikipedia (wikidata-related?) as Resolved.Feb 24 2025, 9:26 AM
ssastry mentioned this in T353080: Parsoid's cite implementation does't check 'cite_error_ref*_too_many_keys' in all cases where it needs to be.Apr 10 2025, 2:25 AM
ssastry closed subtask T381182: Cite error reporting discrepancy (for auto-generated references section with a group attribute) between Parsoid & legacy versions as Resolved.Apr 11 2025, 7:34 PM
thiemowmde mentioned this in T398402: Remaining feature parity issues between the two Cite parsers.Jul 2 2025, 8:22 AM
gerritbot added a comment.Jul 16 2025, 10:28 AM

Change #1170115 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Serialize errors as DataMwError instead of MessageValue

https://gerrit.wikimedia.org/r/1170115

gerritbot added a comment.Aug 6 2025, 7:39 AM

Change #1170115 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Serialize errors as DataMwError instead of MessageValue

https://gerrit.wikimedia.org/r/1170115

thiemowmde mentioned this in T418766: Tracking category "Pages that use sub-references" is not added when using Parsoid.Mar 2 2026, 6:50 PM
Johannes_Richter_WMDE subscribed.Mar 2 2026, 6:58 PM
ihurbain closed subtask T383141: Replace cite-tracking-category-cite-diffing-error category by an entry in the ParserLimit report as Resolved.Apr 13 2026, 3:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits