Page MenuHomePhabricator

Media viewer fails to give credit to all people in specific circumstances
Open, LowPublic

Description

The Media viewer fails to give credit to all people listed under author in situations where:

  1. There is a {{Creator:Foo}} template used for one of the authors, but
  2. Other authors are listed below said tag.

For example, Mathew_B._Brady_-_William_Sidney_Mount.jpg, if viewed in media viewer, will only credit Mathew Brady, leaving out credit to myself.

Not every creator has a template, and it's not uncommon for a templated and untemplated creator to both be responsible for a work, even outside of restoration work.


Version: unspecified
Severity: normal

Details

Reference
bz66606

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:10 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz66606.
bzimport added a subscriber: Unknown Object (MLST).

This is true. I'm not sure how to best solve this, that is up to the multimedia team.

I would however advise you start using a template for your own creditline, that makes it easier to retroactively make it compatible with future generations of machine readable data.

When the author field has an author template, we discard all input outside it. We could just keep it instead; I don't think that could cause problems.

That said, it won't look particularly good (something like "Mathew Brady Restoration: Adam Cuerden"). That's the limitation of how much meaning can be extracted from templates currently; Wikidata will provide nicer ways.

Gilles triaged this task as Medium priority.Nov 24 2014, 2:43 PM
Gilles added a subscriber: Gilles.
Tgr set Security to None.

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Jdlrobson changed the task status from Open to Stalled.Feb 3 2016, 8:26 PM
Jdlrobson added a subscriber: Jdlrobson.

Not clear how to proceed with this task right now without structured meta data.

Retaining text outside the hcard would be a fairly simple change in CommonsMetadata but I am not sure it would be beneficial all the time.

Well, we agree it's bad to leave out one of the credits, right?

@AdamCuerden, Yes, but I think tgr's point is that he fears that by improving a small set of problem files (0.1% or something), there is the potential to add a much bigger group of new problem files that would get significantly 'worse quality', non-readable, non-understandable author information than we have right now. And that will be hard to assess, without reparsing all the file pages, which takes long, and equally as long to undo. etc..

Jdlrobson lowered the priority of this task from Medium to Low.Nov 24 2016, 7:03 PM

I agree that we don't want to potentially hurt the credit on most files for a tiny use case - and I agree that we should try to fix this once structured data makes it easier for us to credit creators. Leaving stalled, but we definitely want to fix this as soon as is practicable.

simon04 added a subscriber: simon04.

According to above comments a solution is not so easy and thus no good first bug…

In T68606#3218037, MarkTraceur wrote:

I agree that we should try to fix this once structured data makes it easier for us to credit creators.

Is there a task tracking structured data for author credits (which this task should have as a subtask)?

Is there a task tracking structured data for author credits (which this task should have as a subtask)?

Not sure about tasks (T585 would have been relevant but it was declined; T68108 is probably the relevant epic but it has no related subtask) but there is a Commons project page.

In T68606#683872, @Tgr wrote:

That said, it won't look particularly good (something like "Mathew Brady Restoration: Adam Cuerden"). That's the limitation of how much meaning can be extracted from templates currently; Wikidata will provide nicer ways.

Can you replace newline with " | "? ("Mathew Brady | Restoration: Adam Cuerden")

The code to change is TemplateParser::parseFieldArtist, if someone wants to take a shot at this. IMO the energy would be better spent working on storing authors as structured data, or at a minimum on templates which output them in a sane machine-readable way.

Aklapper changed the task status from Stalled to Open.Nov 1 2020, 10:14 PM

Structured metadata is in the making nowadays, hence resetting task status. (If this depends on a specific task, please make that task a subtask.)