Page MenuHomePhabricator
Create Task
Maniphest T78424

P4. Spike - Figure out causes of mention notification not being sent (missing pings)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

A variety of "Notification wasn't sent" reports in the last few weeks. E.g. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_133#Missed_pings

Bob K31416 says:

Someone recently used {{u}} with my user name and I didn't get any notification. diff

I can't see any potential or known problems in that diff, so filing as a new bug. (I even tried changing my signature to use the same code as Cwobeel, and it still worked in a test).

See also: T68078: Indicate mentions in edit preview and in "Your edit was saved" message

Details

SubjectRepoBranchLines +/-
Pass title along to signature parsermediawiki/extensions/Echowmf/1.25wmf17+1 K -25
Pass title along to signature parsermediawiki/extensions/Echowmf/1.25wmf16+1 K -25
Pass title along to signature parsermediawiki/extensions/Echomaster+1 K -25
Improve signature detectionmediawiki/extensions/Echowmf/1.25wmf16+260 -161
Improve signature detectionmediawiki/extensions/Echomaster+260 -161
Improve signature detectionmediawiki/extensions/Echowmf/1.25wmf15+260 -161
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
FriedhelmW added a comment.Jan 29 2015, 4:12 PM

A valid signature consists of a mandatory link to the user page and an optional link to the talk page. All other signatures do not generate a notification.

FriedhelmW added a comment.Jan 29 2015, 4:34 PM

When the signature contains unbalanced HTML tags no notification is generated.

Perhelion updated the task description. (Show Details)Jan 29 2015, 4:48 PM
Perhelion added a comment.Jan 29 2015, 5:03 PM
In T78424#1000943, @FriedhelmW wrote:

A valid signature consists of a mandatory link to the user page and an optional link to the talk page. All other signatures do not generate a notification.

Those are the normal required conditions to trigger a notification, except of link to the talk page (which is not necessary).

In T78424#1000964, @FriedhelmW wrote:

When the signature contains unbalanced HTML tags no notification is generated.

What means "unbalanced HTML" exactly? It seems many user using "balanced HTML".
Anyway this bug seems to have a bit sporadically characteristics, because there are also fully normal edits and signatures.
Anyway there is task T75366: New comments are not generating mention notifications when signature is non-standard (which you linked, with priority High).

FriedhelmW added a comment.Jan 29 2015, 5:10 PM

<span> without matching </span> is an unbalanced HTML tag.

Perhelion added a comment.EditedJan 29 2015, 5:46 PM
In T78424#1000994, @FriedhelmW wrote:

<span> without matching </span> is an unbalanced HTML tag.

This is not very plausible, because the signature preferences have an HTML tidy syntax check (You get: Invalid raw signature. Check HTML tags.). Except the user use a very old own signature syntax. Anyway I can't see a direct relation to this report here.

Aklapper added a comment.Jan 29 2015, 7:47 PM

Could this get higher priority and an assignee, please?

(Problem also brought up in https://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia&oldid=138296051#Echo_funktioniert_nicht )

Schnark closed subtask T76961: Echo Mentions should trigger, if a signature only contains a usertalkpage link, and not a userpage link as Invalid.Jan 30 2015, 9:00 AM
Schnark added a comment.Jan 30 2015, 9:04 AM
In T78424#1000943, @FriedhelmW wrote:

A valid signature consists of a mandatory link to the user page and an optional link to the talk page. All other signatures do not generate a notification.

This is not true (e.g. https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion%3ASchnark&diff=138274729&oldid=137934707 worked), but even if it were true: https://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia&diff=138029126&oldid=138028556 failed though that signature is a standard signature.

In T78424#1000964, @FriedhelmW wrote:

When the signature contains unbalanced HTML tags no notification is generated.

This is not true, as I proved in https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion%3ASchnark&diff=138274875&oldid=138274729

• DannyH renamed this task from [2] Spike - Figure out causes of mention notification not being sent (missing pings) to [2] P4. Spike - Figure out causes of mention notification not being sent (missing pings).Jan 30 2015, 6:37 PM
• Elitre subscribed.Jan 31 2015, 5:08 PM
Ricordisamoa added a comment.Feb 1 2015, 12:14 AM

I did not receive a notification for this mention.

matthiasmullie claimed this task.Feb 2 2015, 6:33 PM
matthiasmullie moved this task from Sprint P - ends Feb 11 to In Development on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.
• DannyH renamed this task from [2] P4. Spike - Figure out causes of mention notification not being sent (missing pings) to P4. Spike - Figure out causes of mention notification not being sent (missing pings).Feb 3 2015, 6:52 PM
matthiasmullie added a comment.EditedFeb 4 2015, 10:08 AM

https://gerrit.wikimedia.org/r/#/c/187850/ refactors how signatures are extracted. Let's see if that helps.

matthiasmullie moved this task from In Development to Code Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Feb 4 2015, 10:08 AM
gerritbot added a project: Patch-For-Review.Feb 4 2015, 11:27 AM
gerritbot subscribed.

Change 187850 had a related patch set uploaded (by Matthias Mullie):
Improve signature detection

https://gerrit.wikimedia.org/r/187850

Patch-For-Review

Technical13 subscribed.Feb 5 2015, 6:18 PM
gerritbot added a comment.Feb 6 2015, 1:21 AM

Change 187850 merged by jenkins-bot:
Improve signature detection

https://gerrit.wikimedia.org/r/187850

matthiasmullie mentioned this in rECHO58e1c765d63f: Improve signature detection.Feb 6 2015, 1:21 AM
matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Feb 6 2015, 1:49 PM
matej_suchanek unsubscribed.Feb 6 2015, 2:42 PM
• DannyH subscribed.Feb 6 2015, 10:15 PM

Figured it out; we're planning to cherry-pick the fixes on Monday.

• DannyH closed this task as Resolved.Feb 6 2015, 10:15 PM
• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.
• DannyH closed subtask T75426: Comments containing diacritics does not generate notifications as Resolved.Feb 6 2015, 10:26 PM
Quiddity mentioned this in T72329: Message notifications not working.Feb 9 2015, 7:56 PM
Quiddity merged a task: T72329: Message notifications not working.
Quiddity added subscribers: SebastianHelm, EBernhardson, • Cmcmahon and 3 others.
gerritbot added a comment.Feb 9 2015, 8:18 PM

Change 189548 had a related patch set uploaded (by EBernhardson):
Improve signature detection

https://gerrit.wikimedia.org/r/189548

Patch-For-Review

gerritbot added a comment.Feb 9 2015, 8:19 PM

Change 189548 merged by jenkins-bot:
Improve signature detection

https://gerrit.wikimedia.org/r/189548

EBernhardson mentioned this in rECHO8d5261d71ce9: Improve signature detection.Feb 9 2015, 8:19 PM
gerritbot added a comment.Feb 9 2015, 8:21 PM

Change 189549 had a related patch set uploaded (by EBernhardson):
Improve signature detection

https://gerrit.wikimedia.org/r/189549

Patch-For-Review

gerritbot added a comment.Feb 9 2015, 8:22 PM

Change 189549 merged by jenkins-bot:
Improve signature detection

https://gerrit.wikimedia.org/r/189549

EBernhardson mentioned this in rECHO4298fb345f09: Improve signature detection.Feb 9 2015, 8:22 PM
EBernhardson closed subtask T87852: No notification is sent when signature contains links to subpages in user namespace in addition to the required link to the user page itself as Resolved.Feb 9 2015, 8:28 PM
EBernhardson closed subtask T75366: New comments are not generating mention notifications when signature is non-standard as Resolved.
SebastianHelm unsubscribed.Feb 9 2015, 8:58 PM
Quiddity mentioned this in T88853: Echo is disabled for blocked users.Feb 9 2015, 11:48 PM
Betacommand subscribed.Feb 10 2015, 12:04 AM
Schnark reopened subtask T87852: No notification is sent when signature contains links to subpages in user namespace in addition to the required link to the user page itself as Open.Feb 10 2015, 9:03 AM
Quiddity reopened this task as Open.Feb 12 2015, 5:09 PM

Fresh report of this edit not sending a notification: https://en.wikipedia.org/w/index.php?diff=646792804
(report)

• Mattflaschen-WMF subscribed.Feb 12 2015, 7:12 PM

Maybe it's getting confused by:

[[User talk:PatHadley#top|talk]]</code>

Schnark closed subtask T87852: No notification is sent when signature contains links to subpages in user namespace in addition to the required link to the user page itself as Resolved.Feb 13 2015, 8:48 AM
Quiddity added a comment.Feb 16 2015, 7:46 PM
In T78424#1034841, @Mattflaschen wrote:

Maybe it's getting confused by:

[[User talk:PatHadley#top|talk]]</code>

Another report of this edit not triggering a ping, and he also has a #top in his signature: [[User talk:Kudpung#top|talk]]

Redrose64 subscribed.Feb 17 2015, 2:01 AM

The default (uncustomised) signature has #top in the talk page link.

Redrose64 mentioned this in T89690: Longer Maniphest tasks not fully displayed (as Phabricator defines a result set limit as 100 rows).Feb 17 2015, 2:16 AM
Liuxinyu970226 subscribed.Feb 17 2015, 3:11 AM
Quiddity added a comment.Feb 17 2015, 6:39 AM
In T78424#1042739, @Redrose64 wrote:

The default (uncustomised) signature has #top in the talk page link.

Wha?? oh, since 2007 at enwiki https://en.wikipedia.org/w/index.php?title=MediaWiki%3ASignature&diff=176507985&oldid=176229132
and since April 2013 at mediawikiwiki and meta. Since 2008 at commons.
I checked another 10 large projects/languages, and all others used the default.

Quiddity added a project: Collaboration-Team-Sprint-Q-2015-02-25.Feb 17 2015, 6:40 AM
gerritbot added a comment.Feb 17 2015, 10:51 AM

Change 191011 had a related patch set uploaded (by Matthias Mullie):
Pass title along to signature parser

https://gerrit.wikimedia.org/r/191011

Patch-For-Review

matthiasmullie added a comment.Feb 17 2015, 10:53 AM

The #top thingy was indeed the culprit.

We re-generate a signature for whoever we think we've found. However, that Mediawiki:signature is different on regular pages (which Echo code assumed) than it is on own user talk pages (where it adds #top) - causing us not to pick up the signature.

Above patch should fix that.

Jdlrobson unsubscribed.Feb 17 2015, 12:10 PM
matthiasmullie moved this task from Sprint Q - ends Feb 25 to Code Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 17 2015, 1:06 PM
Quiddity added a comment.Feb 17 2015, 5:52 PM

Sidenote: Please update any changes to the signature detection code, at https://www.mediawiki.org/wiki/Manual:Echo#Mentions. Thanks :)

gerritbot added a comment.Feb 17 2015, 7:29 PM

Change 191011 merged by jenkins-bot:
Pass title along to signature parser

https://gerrit.wikimedia.org/r/191011

EBernhardson mentioned this in rECHO0dee3d3587ed: Pass title along to signature parser.Feb 17 2015, 7:31 PM
gerritbot added a comment.Feb 17 2015, 7:33 PM

Change 191113 had a related patch set uploaded (by EBernhardson):
Pass title along to signature parser

https://gerrit.wikimedia.org/r/191113

Patch-For-Review

gerritbot added a comment.Feb 17 2015, 7:38 PM

Change 191117 had a related patch set uploaded (by EBernhardson):
Pass title along to signature parser

https://gerrit.wikimedia.org/r/191117

Patch-For-Review

gerritbot added a comment.Feb 17 2015, 7:40 PM

Change 191117 merged by jenkins-bot:
Pass title along to signature parser

https://gerrit.wikimedia.org/r/191117

EBernhardson mentioned this in rECHO04ba5b428c11: Pass title along to signature parser.Feb 17 2015, 7:40 PM
gerritbot added a comment.Feb 17 2015, 7:42 PM

Change 191113 merged by jenkins-bot:
Pass title along to signature parser

https://gerrit.wikimedia.org/r/191113

EBernhardson mentioned this in rECHO555f95409cf6: Pass title along to signature parser.Feb 17 2015, 7:42 PM
EBernhardson moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 17 2015, 8:02 PM

Patches have been cherry-picked forward, will go out to all wikis in four to five hours.

• DannyH closed this task as Resolved.Feb 18 2015, 12:02 AM
Liuxinyu970226 unsubscribed.Feb 18 2015, 2:14 AM
matthiasmullie added a comment.Feb 18 2015, 4:48 PM

@Quiddity: notes about signature detection have been updated as well

matthiasmullie changed the status of subtask T76961: Echo Mentions should trigger, if a signature only contains a usertalkpage link, and not a userpage link from Invalid to Resolved.Mar 3 2015, 5:04 PM
Diffusion mentioned this in rMEXT0f49d93f7d8a: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Mar 11 2015, 6:26 AM
matthiasmullie mentioned this in rMEXTa54a73857fdd: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Mar 11 2015, 6:26 AM
RandomDSdevel awarded a token.Mar 29 2015, 10:14 PM
Quiddity removed a project: Patch-For-Review.May 6 2015, 10:31 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 6 2015, 10:31 PM
• DannyH moved this task from Team discussion to Resolved on the Collaboration-Team-Triage board.May 8 2015, 11:00 PM
He7d3r mentioned this in T118458: Echo did not trigger mention notification when user was linked.Nov 12 2015, 12:12 PM
SebastianHelm reopened this task as Open.Jan 15 2016, 6:30 PM
SebastianHelm subscribed.

Sadly, it seems this is still happening. It just happened twice at [[w:en:User_talk:Eteethan#Why_remove_tag.2C_instead_of_using_a_template.3F]].

• Mattflaschen-WMF closed this task as Resolved.Jan 15 2016, 8:40 PM

Please link the diffs you're referring to.

If you mean https://en.wikipedia.org/w/index.php?title=User_talk:Eteethan&diff=699715723&oldid=699715390 , it's because it was unsigned.

And https://en.wikipedia.org/w/index.php?title=User_talk:Eteethan&diff=699717972&oldid=699717906 didn't work because it didn't add a signature (I believe they have to be in the same edit).

This spike was about figuring out causes, which is done. See T66778: Echo: Remove the signature-requirement for Mention notifications for discussion on possible solutions.

SebastianHelm added a comment.Jan 15 2016, 8:49 PM

Thank you very much for your diligent look into this and the great explanation. That explains my observations.

Eteethan subscribed.Jan 15 2016, 9:51 PM

Oh, yeah. That was completely my fault.

• DannyH unsubscribed.Jan 15 2016, 10:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL