Page MenuHomePhabricator

Echo: Remove the signature-requirement for Mention notifications
Open, HighPublic

Description

Removing the signature requirement was discussed in T55132: Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces.

I believe that aspect stalled, because of these concerns:

(In reply to Quiddity from T55132#577605)

(In reply to comment 16)

My recommendation would be that we remove the requirement that a signature be
included before a mention notification is sent, as stated here:
[...]

Regarding "remove the requirement that a signature be included before a
mention notification is sent", which I'm generally in favour of...
I just saw Bug 54639 ("Echo is not triggering notifications when a mention
is made while reorganizing comments in the page") which makes me worry that
(if the signature-requirement is taken away) mass notifications will be
accidentally sent when threads are shuffled/split/merged or archived.
Just worrying out-loud; I might have understood the details incorrectly.

and

(In reply to Bartosz Dziewoński from T55132#577614)

Good point. Luckily I think we could easily avoid that issue by just
counting the number of mentions for each user in the old and new wikitext
and only sending a notification is the number increased.

and

(In reply to Wikifram@gmail.com (Account disabled) from T55132#577622)

A) I would support the removal of the need to sign a comment before a "ping"
works (I wasn't aware of this requirement, and thought that my "ping"
remained unanswered until JdForrester nicely explained this to me)
but...
B) I have the habit to archive my talk page by using "copy-paste", I
wouldn't want people to get unwanted notifications when I do this though.
I fear that A and B are mutually exclusive requirements...

Copying here, for easier access, and further/later investigation.


Version: unspecified
Severity: normal

Details

Reference
bz64778

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:09 AM
bzimport added a project: Notifications.
bzimport set Reference to bz64778.
bzimport added a subscriber: Unknown Object (MLST).
Quiddity created this task.May 3 2014, 12:40 AM
Pine added a comment.May 25 2014, 9:32 PM

See also https://bugzilla.wikimedia.org/show_bug.cgi?id=58034

And I was not notified when a user signed their posts without using four tildes.

I am changing the priority from enhancement to normal, because the user who mentioned me in the most recent case seems to have intended to ping me and I wanted to know about the pings. Since user intentions weren't followed I think this should be categorized as a bug. I am changing importance from normal to high because I think the impact of this unexpected behavior is significant for users.

He7d3r added a subscriber: He7d3r.Nov 30 2014, 7:24 PM
He7d3r updated the task description. (Show Details)Nov 30 2014, 7:26 PM
He7d3r set Security to None.

If we do this, we need to somehow make sure there's virtually no chance of false positives, since false positives will lead users to disable mention notifications, and that'd be bad for everyone involved.

If we do this, we need to somehow make sure there's virtually no chance of false positives, since false positives will lead users to disable mention notifications, and that'd be bad for everyone involved.

Agreed. Before considering this, we would need to carefully specify the behavior. Bartosz's idea (see description) seems workable if it can be done performantly.

Sampayu removed a subscriber: Sampayu.Feb 6 2015, 12:10 PM
Legoktm moved this task from Backlog to Needs code on the Notifications board.Jul 6 2015, 8:31 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 6 2015, 8:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2015, 2:18 PM
4nn1l2 added a subscriber: 4nn1l2.Nov 22 2015, 12:20 PM

Bartosz:

Good point. Luckily I think we could easily avoid that issue by just counting the number of mentions for each user in the old and new wikitext and only sending a notification is the number increased.

I don't think this would handle manual archiving. When comments are moved to the archive page, the edit expanding the archive page will increase the number of mentions on that page. (There is an offsetting edit removing mentions on the other page, but I don't think it's feasible to link those.).

This could be addressed by having a way to mark archive pages so mentions there were ignored. Flow has some ways of keeping track of archive page title conventions, but it's not complete.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 4 2018, 2:26 PM
4nn1l2 removed a subscriber: 4nn1l2.Oct 25 2018, 2:21 PM
kostajh added a subscriber: kostajh.

We discussed in triage this week, we don't have time to prioritize working on this in the short-to-medium term.

Ayack added a subscriber: Ayack.Dec 10 2018, 5:36 PM
This comment was removed by Ayack.