[Epic] Make the forms come from one template
Closed, ResolvedPublic
Actions

Description

Right now the forms are a mess, this should help.

This is production-ready when (not necessarily this task, could be a parent task), the template handles:

Screen-reader support.
I18n of text.
L10n of amounts, dates, and other numbers, by language and country.
Form variations by country, e.g. Fiscal Number (CPF) in Brazil.
A/B testing of form variations. This might have to go deeper than CSS, and allow us to swap out partials, etc.
All gateways.
All payment methods.
Displays server-side validation errors.
Performs client-side validation.

Details

Subject	Repo	Branch	Lines +/-
Remove RapidHTML	mediawiki/extensions/DonationInterface	deployment	+17 -8 K
Remove RapidHTML	mediawiki/extensions/DonationInterface	master	+18 -8 K
WIP Mustache for legacy WorldPay	mediawiki/extensions/DonationInterface	master	+54 -205
Clean up has_x flags in Mustache forms	mediawiki/extensions/DonationInterface	master	+7 -11
Localize card label alt/title attributes	mediawiki/extensions/DonationInterface	master	+9 -9
Remove FormDir and filename for Mustache forms	mediawiki/extensions/DonationInterface	master	+1 -22
Initial reorganization of js for new forms	mediawiki/extensions/DonationInterface	master	+202 -127
Fix maintenance form display	mediawiki/extensions/DonationInterface	master	+17 -23

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	XenoRyet	T86214 Change errors on GC forms from popup to red text
Open	None	T86942 Provide a country switching form on payments.wmo
Open	None	T87667 Triage accessibility for donor-facing Fundraising components
Resolved	None	T86248 [Epic] Make the forms come from one template
Resolved	awight	T95951 Add mustache templating engine gateway form renderer
Open	None	T96440 We need a way to debug which form partials are being loaded in mustache forms
Resolved	Ejegg	T97056 Make form for Astropay Brazilian credit cards
Resolved	Ejegg	T97149 Mustache renderer needs to support i18n
Resolved	Ejegg	T123002 Convert GlobalCollect credit card forms from RapidHTML to Mustache
Resolved	• cwdent	T140138 Convert BPay to mustache
Resolved	Ejegg	T123001 Convert PayPal interstitial form from RapidHTML to Mustache
Resolved	Ejegg	T131995 Render rapidfail error forms with mustache

Event Timeline

• atgo created this task.Jan 8 2015, 10:18 PM

• atgo raised the priority of this task from to Medium.

• atgo updated the task description. (Show Details)

• atgo added a project: Fundraising-Backlog-Old.

• atgo moved this task from Backlog to DI Refactor on the Fundraising-Backlog-Old board.

• atgo subscribed.

awight added a subtask: T86251: Move any remaining controller logic out of the form classes.Feb 5 2015, 7:20 AM

I might be wrong, but I've marked this as blocked by the jumbled controller and display logic, because currently it seems painful to slip the generalized template rendering code between pieces of the GatewayForm subclasses.

awight added a project: MediaWiki-extensions-DonationInterface.Mar 5 2015, 6:33 PM

awight added a subtask: T91673: Spike: Choose new template engine for DonationInterface and plan integration.Mar 5 2015, 6:38 PM

awight added a project: Wikimedia-Fundraising.

Let's keep Wikimedia-Fundraising to user-facing features

We want to roll this out incrementally if possible, one gateway-payment method at a time.

awight closed subtask T86251: Move any remaining controller logic out of the form classes as Resolved.Mar 12 2015, 9:31 PM

• pizzzacat claimed this task.Apr 13 2015, 8:41 PM

• pizzzacat edited a custom field.

• pizzzacat edited subtasks, added: T95951: Add mustache templating engine gateway form renderer; removed: T91673: Spike: Choose new template engine for DonationInterface and plan integration, T86251: Move any remaining controller logic out of the form classes.

• pizzzacat edited projects, added Fundraising Sprint House of Pain; removed Fundraising-Backlog-Old.

• pizzzacat merged a task: T95949: Make one form template for each form type to render from.Apr 13 2015, 8:45 PM

• pizzzacat moved this task from Backlog to Doing on the Fundraising Sprint House of Pain board.

• pizzzacat added subscribers: gerritbot, K4-713, • pizzzacat.

awight updated the task description. (Show Details)Apr 14 2015, 7:25 AM

awight updated the task description. (Show Details)

awight added a parent task: T86942: Provide a country switching form on payments.wmo.Apr 14 2015, 9:13 PM

awight added a parent task: T87667: Triage accessibility for donor-facing Fundraising components.Apr 14 2015, 9:24 PM

• pizzzacat added a project: Fundraising Sprint Indigo Girls.Apr 15 2015, 10:20 PM

• pizzzacat moved this task from Backlog to Doing on the Fundraising Sprint Indigo Girls board.

awight closed subtask T95951: Add mustache templating engine gateway form renderer as Resolved.Apr 20 2015, 6:31 PM

@pizzzacat: I noticed yesterday that this task is not quite the right one to describe this first step of the UI project, the first step is more like "Write Astropay forms using the Mustache template renderer". The goal of "make forms use one template" is sort of an epic tracking task which will be blocked by each form we integrate into Mustache-land.