Mustache renderer needs to support i18n
Closed, ResolvedPublic
Actions

Description

The AstroPay forms will be translated into several languages. We should have MW i18n available, including parameterized messages, plural, and grammar. The obvious way to do this is to use template helper functions.

We're not using the MediaWiki-core renderer yet, so we're free to play with the lightncandy extensions--at the risk of becoming incompatible with future MW-core. Hopefully, we can work out what's needed, and add it to the MW-core templating engine.

Whatever is done should also be compatible with client-side rendering. I assume this will use the [ https://www.mediawiki.org/wiki/Milkshake | Milkshake ] library somehow.

See the following solution, for the Flow extension:

10:10 < ejegg> Flow uses extensions via lightncandy to do their i18n: https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/includes/TemplateHelper.php#L141

Details

	Subject	Repo	Branch	Lines +/-
	l10n for mustache	mediawiki/extensions/DonationInterface	master	+108 -73

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	XenoRyet	T86214 Change errors on GC forms from popup to red text
Open	None	T86942 Provide a country switching form on payments.wmo
Open	None	T87667 Triage accessibility for donor-facing Fundraising components
Resolved	None	T86248 [Epic] Make the forms come from one template
Resolved	None	T94284 Fundraise in Brazil (as soon as Astropay is ready)
Resolved	Ejegg	T97056 Make form for Astropay Brazilian credit cards
Resolved	Ejegg	T97149 Mustache renderer needs to support i18n

Event Timeline

awight created this task.Apr 24 2015, 5:25 PM

awight assigned this task to • pizzzacat.

awight raised the priority of this task from to Medium.

awight updated the task description. (Show Details)

awight added projects: Fundraising Sprint Indigo Girls, MediaWiki-extensions-DonationInterface, I18n, MediaWiki-Templates.

awight added subscribers: • pizzzacat, K4-713, gerritbot and 5 others.

awight added a parent task: T97056: Make form for Astropay Brazilian credit cards.Apr 25 2015, 12:03 AM

Ejegg added a project: Fundraising Sprint James Brown.Apr 29 2015, 10:45 PM

Ejegg set Security to None.

• atgo edited projects, added Fundraising-Backlog-Old; removed Fundraising Sprint James Brown.Apr 30 2015, 10:33 PM

To throw an exciting wrench in, we have a special requirement for Fundraising, that we can l10n messages per-country. We currently kludge this in DonationInterface by searching for <msgkey>-<countrycode>, then falling back to plain <msgkey>.

This wouldn't have to be implemented in mw-core, but it would be nice if there were a simple override which would allow us to add the extra layer.

Change 212243 had a related patch set uploaded (by Ejegg):
l10n for mustache

https://gerrit.wikimedia.org/r/212243

gerritbot added a project: Patch-For-Review.May 21 2015, 8:45 PM

Change 212243 merged by jenkins-bot:
l10n for mustache

https://gerrit.wikimedia.org/r/212243

Ejegg mentioned this in rEDOI914d8f7fb8f1: l10n for mustache.May 21 2015, 10:17 PM

Diffusion mentioned this in rMEXT6944445f8980: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….May 21 2015, 10:18 PM

@Ejegg this one is blocking T97056 - should we put it int he sprint or close it or...?

Ejegg claimed this task.May 27 2015, 5:34 PM

Ejegg added a project: Fundraising Sprint Kraftwerk.May 27 2015, 5:41 PM

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Kraftwerk board.May 27 2015, 5:46 PM