Page MenuHomePhabricator

Update colors in Dark theme to meet color contrast requirements
Closed, ResolvedPublic

Description

Problem

There are many areas of text in dark mode that do not meet the minimum color contrast requirements. The following updated Dark theme colors address the contrast issues from previous tickets filed.

Contrast issues

1. Article text
Text should probably be changed to whiter Base90 color on the dark background to help readability (or at least make the grey lighter). We've received a number of requests for this on the email queue.
Requested in:
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8969931#
+ New ticket where background color on Amazon device is also
showing as blue-gray: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=10059782
2. Link text - per T163461
Color of link text should be changed from the existing #36c to be higher contrast when in dark mode screens to the Accent75 dark mode link color.

3. Button/Action text – per T166453
Color of actions text and icons should be in a higher contrast than the existing #36c blue. Change to Accent75 dark mode link color.

4. Heading text - T150787
Color of actions text and icons should be in a higher contrast than the existing #36c blue. Change to Accent75 dark mode link color.

5. Bottom navigation toolbar - T146385
Color of bottom toolbar nav items should utilize #FFF instead of #36c.

6. Login and Join Wikipedia banner background - T169117

Dark theme color palette

Android Light and Dark color palette.png (3×3 px, 596 KB)

Theme assets

Android dark and light theme.png (2×1 px, 331 KB)

Example: screens

Example light and dark screens.png (1×3 px, 2 MB)

Related Objects

Event Timeline

Mdann52 raised the priority of this task from to Needs Triage.
Mdann52 updated the task description. (Show Details)
Mdann52 added a subscriber: Mdann52.
Deskana added a subscriber: Deskana.
Florian added a subscriber: Florian.

Also requested in: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8969931#

Btw.: I also would expect a much lighter grey or white for a black theme (~high contrast theme) :)

The user clarified the request: The main problem are the headings which seems to be in another grey as the text itself. And the headings aren't readable easily on AMOLED displays only :/

RHo renamed this task from Update text colors in Dark theme to meet color contrast requirements to Update colors in Dark theme to meet color contrast requirements.Jul 5 2017, 3:35 PM
RHo updated the task description. (Show Details)

@RHo In your mock of "Article (dark)" you're using a link color of #5482ff, but in the mock of "Article bottom (dark)" the color is #6699ff. Is this correct, or should they both be one or the other?

@Dbrant – hmm it's only the one color #6699FF – perhaps the color picker is not providing the accurate hex for you?

I just checked and looks like some exporting quirk to Zeplin – this is from Sketch:

image.png (992×1 px, 440 KB)

@RHo The design looks great!

I had a suggestion to make (as an observer). In the dark theme, the home page of the app looks a little outlandish due to the blue color in the app bar. It doesn't seem to be fitting well with the rest of the screen which bear different shades of grey. It would be nice if some other color (possibly #000000 as the material design suggests) was used in place of the blue.

I know the Wikimedia foundation has something to do with blue but it doesn't seem to fit well in this place. This is only my opinion, though.

Note : Examples of apps which have good dark themes are,

hey @Kaartic – I see your point and agree that perhaps having the bottom nav in dark mode as blue makes it stand out a little much. However, am keeping the dark blue on the app bar to carry through the brand accent color in dark mode, and also helping to emphasize the visual hierarchy is whereby app bar layer sits on top is a lighter color. Have updated the mocks in the description, and think it works better :)

I rather liked the blue background in the dark rendition of the navigation bar...

A few things I noticed in the mocks,

  1. The tab icon seems to be missing in a dark theme mock (fifth one from the left)
  2. There doesn't seem to be any distinction between the app bar and the background of the search bar in both dark and light theme mocks (fourth from the left). It's not an issue. I just wanted to know if it's something that's about to be done. I'm asking this as I don't see this behaviour in the recent alpha (11 Jul 2017).

Change 365022 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Update accent, background, and toolbar colors for dark and light mode.

https://gerrit.wikimedia.org/r/365022

Change 365022 merged by jenkins-bot:
[apps/android/wikipedia@master] Update accent, background, and toolbar colors for dark and light mode.

https://gerrit.wikimedia.org/r/365022

A few things I noticed in the mocks,

  1. The tab icon seems to be missing in a dark theme mock (fifth one from the left)
  • Hiya, hah yes this is a mock only (though of course it is possible for this to occur if no articles happen to be open)
  1. There doesn't seem to be any distinction between the app bar and the background of the search bar in both dark and light theme mocks (fourth from the left). It's not an issue. I just wanted to know if it's something that's about to be done. I'm asking this as I don't see this behaviour in the recent alpha (11 Jul 2017).
  • Yes, this is the expected, I've filed a task on this UX-debt item here T170831

I rather liked the blue background in the dark rendition of the navigation bar...

  • Ah, I do think the gray bottom nav does work better and is more aligned with the light mode...

Only part 3 of this task is still showing a darker color than the expected #6699ff color on the link preview text:

Artboard.png (1×1 px, 310 KB)

Else the rest looks good:

Article text and link
main-MainActivity-08092017163107.png (1×1 px, 1 MB)
Section headers
main-MainActivity-08092017182731.png (1×1 px, 166 KB)
Dark mode feed bottom nav icon color
main-MainActivity-08022017164402.png (1×1 px, 596 KB)

Tested using Nexus 5 (6.0.1) on Wikipedia v2.6.200-alpha-2017-08-08

Hey @RHo, it looks like the link preview overlay button text color is currently #6699ff. Maybe this was fixed in an intervening change.

hi @Mholloway - can we make the text color at 100% opacity as well and then will be good to go!

image.png (538×1 px, 636 KB)

Change 377901 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Ensure link preview overlay view button text is fully opaque

https://gerrit.wikimedia.org/r/377901

Change 377901 merged by jenkins-bot:
[apps/android/wikipedia@master] Ensure link preview overlay button text is fully opaque

https://gerrit.wikimedia.org/r/377901

In T95080#3605677, @RHo wrote:

hi @Mholloway - can we make the text color at 100% opacity as well and then will be good to go!

This should now be live in the latest alpha build.