@Hanna_Petruschat_WMDE the non-expandable problem is likely to be the result of a problem we faced with termbox in production yesterday. Sent out a short incident report to Wikidata Campsite mailing list.

@Hanna_Petruschat_WMDE yeap apologies I forgot to add this AC eventhough we talked about it before. Adding it to task description now and will work on it asap

Updated parent task with findings and the current solution we agreed on. Let's get the first iteration of these edit summaries out soon and then we can try to increase our limit a lot as a follow up.

As we discovered in T224014: Figure out the limits in which versions fallback to the next one .. we decided to change the way we fall back between different versions T224014: Figure out the limits in which versions fallback to the next one .. updating task description

It isn't as it appears in the code so far. it is hard coded in the class and used directly .. perhaps that's something we can do later and make it configurable?

patches for white background for input fields, and wider vertical spacing are up

@Lydia_Pintscher this is for product review :)

So as for now, I propose to do the following:

1. Use 480 as a limit for the generated summary.
2. If we have <= 5 terms changed, we generate expanded version. Then if it is below the limit, we stop and use it.
3. If we have <= 50 languages changed, we generate shortend version. Then if it is below the limit, we stop and use it.
4. If we reach here, we just generate fallback version and use it.

Nevermind me .. I confused the date in previous comments

Talked to @Hanna_Petruschat_WMDE and we decided to include in this task scope:

• white background for input fields
• fix vertical spacing according to Figma mockups

Talked to @Hanna_Petruschat_WMDE and we decided to include in this task scope:
[ ] white background for input fields
[ ] fix vertical spacing according to Figma mockups

Applying white backgrounds to input fields would look like this.

I see .. you also did create T235069: Termbox in labs should be able to recover crashes for that too 👍

The part that should reduce dead-locks is done and synced to production. It might take few more hours for the new config to get picked so we will wait another day and look at the logs again to check if this improved the situation.

I see .. I was fooled by the drop of errors this evening.. must have waited on it a bit esp. knowing that it took longer to publish config changes last time too. Then I'll keep this in Done and open to look at it tomorrow

Thanks @Ladsgroup for taking care of this. Is there a commit/patch somewhere that encodes the fix in our history?

So trying to save the above example of long version, it ended up in database in comment table (comment_text column) as:
/* wbsetclaim-create:2||en, label, "Frame of Notre-Dame de Paris"|fr, alias, Marie|es, description, ""this is a loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong description"|en, description, "this is a much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo...

Error rate increases again. Problem was not really solved

Error rate dropped .. hinting that new page creations seems to have been the added load on term terms written to new store.

Deployment of switching the limit for write both is scheduled for today https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20191009T1100

Testing storing necessary comment arguments for the following examples of each version (if all can be stored succesfully, then the simple count limits we have in the parent task is more than sufficient:

@jcrespo understood thank you

Indeed looking at different graphs does not show anything that immediately suggests any reason for this.

@Hanna_Petruschat_WMDE this can be tested on beta now

@Hanna_Petruschat_WMDE this can be tested on beta now

Another patch for review this depends on:

Some browser tests need fixing after this change (failed CI)

Tested on beta https://en.wikipedia.beta.wmflabs.org/wiki/Draft:Wikidata_Test .. works fine

On its way to beta for testing

On its way to beta for testing

@Hanna_Petruschat_WMDE so it will be easier than I thought and will do it quickly so that we release it with this change

Worked a bit on this trying to fix the tests.. but apparently a day was not enough, and what I thought was a solution (basically setting up the sites needed for relevant tests relevant tests which made them pass) caused other tests to fail.

@Hanna_Petruschat_WMDE right I didn't notice that thanks. I will check how easy it is to do that and let you know

In T232595#5529181, @alaa_wmde wrote:

@Hanna_Petruschat_WMDE

from AC

When the "All entered languages" section is collapsed the button used to expand becomes a collapsing button, labeled "Fewer languages" and styled like in mocks.

not sure I get this correctly (probably the first "collapsed" in the sentence must be "expanded", then it sounds sound to me, or?)

Does it mean that the same button at the top "All entered languages" that is used to also changes to the same "^ Fewer Languages" like the one that will be added to the bottom to (resulting in both buttons being identical), when the All entered languages section is collapsed expanded ?

@Jakob_WMDE (as you have reviewed this before)

Discussed @raja_wmde and we agreed for now to apply the padding in the other way around.