Hooks.php on line 957
Closed, ResolvedPublic
Actions

Description

Catchable fatal error: Argument 1 passed to FlowHooks::isTalkpageManagerUser() must be an instance of User, null given in /srv/mediawiki/php-1.26wmf18/extensions/Flow/Hooks.php on line 957

Details

Subject	Repo	Branch	Lines +/-
Cleanup debugging code for isTalkpageManagerUser	mediawiki/extensions/Flow	master	+1 -8
Add debugging code to detect and workaround type hint failure	mediawiki/extensions/Flow	wmf/1.26wmf18	+19 -1
Add debugging code to detect and workaround type hint failure	mediawiki/extensions/Flow	master	+19 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• santhosh	T108559 While publishing, 'parsererror' is returned, even if publishing succeeds, tags are missing for such articles
		Resolved		• Mattflaschen-WMF	T109063 Catchable fatal error: Argument 1 passed to FlowHooks::isTalkpageManagerUser() must be an instance of User, null given in /srv/mediawiki/php-1.26wmf18/extensions/Flow/Hooks.php on line 957

Event Timeline

Reedy created this task.Aug 14 2015, 12:28 PM

Reedy raised the priority of this task from to Needs Triage.

Reedy updated the task description. (Show Details)

Reedy added projects: StructuredDiscussions, Wikimedia-production-error.

Reedy subscribed.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 14 2015, 12:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Aug 14 2015, 12:30 PM

We'll need to get the trace to figure out which hook it's coming from. That one is called by three places.

I believe there wasn't one listed in logstash when I pulled this out :(

fatals don't have stacktraces...T89169

Change 231700 had a related patch set uploaded (by Mattflaschen):
Add debugging code to detect and workaround type hint failure

https://gerrit.wikimedia.org/r/231700

gerritbot added a project: Patch-For-Review.Aug 14 2015, 10:31 PM

Change 231700 merged by jenkins-bot:
Add debugging code to detect and workaround type hint failure

https://gerrit.wikimedia.org/r/231700

• Mattflaschen-WMF mentioned this in rEFLW9ce602e6fb65: Add debugging code to detect and workaround type hint failure.Aug 18 2015, 12:09 AM

Diffusion mentioned this in rMEXT7e323fb03e93: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Aug 18 2015, 12:10 AM

• Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 19 2015, 6:02 AM

Nikerabbit added a parent task: T108559: While publishing, 'parsererror' is returned, even if publishing succeeds, tags are missing for such articles.Aug 19 2015, 12:49 PM

• santhosh subscribed.Aug 19 2015, 12:51 PM

Based on T108559: While publishing, 'parsererror' is returned, even if publishing succeeds, tags are missing for such articles, one source is most likely coming from BeforeEchoEventInsert, see CX code where we do not specify "agent".

• santhosh mentioned this in rMEXT1866910bd361: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Aug 19 2015, 1:15 PM

• santhosh mentioned this in rECTXa64d657b26bb: Temporarily disable notifications.

• demon triaged this task as Medium priority.Aug 19 2015, 3:52 PM

• demon subscribed.

KartikMistry mentioned this in rECTXfd96794f8082: Temporarily disable notifications.Aug 19 2015, 3:53 PM

• santhosh mentioned this in rMWcbc992b345e2: Updated mediawiki/core Project: mediawiki/extensions/ContentTranslation….Aug 19 2015, 3:53 PM

KartikMistry mentioned this in rECTXf10da558c7bf: Temporarily disable notifications.Aug 19 2015, 4:00 PM

• santhosh mentioned this in rMWfe264c2a3c2a: Updated mediawiki/core Project: mediawiki/extensions/ContentTranslation….Aug 19 2015, 4:00 PM

• santhosh mentioned this in rMW87876cce4474: Updated mediawiki/core Project: mediawiki/extensions/ContentTranslation….

• Mattflaschen-WMF claimed this task.Aug 19 2015, 7:11 PM

• Mattflaschen-WMF added a project: Collaboration-Team-Archive-2015-2016.

• Mattflaschen-WMF moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.

Change 232567 had a related patch set uploaded (by Mattflaschen):
Add debugging code to detect and workaround type hint failure

https://gerrit.wikimedia.org/r/232567

Sorry, we missed that getAgent() is allowed to be null. The debugging/workaround patch should prevent any negative symptoms, but is not yet on all WMF wikis. So I've scheduled an evening SWAT to put it on 1.26wmf18 (it is on 1.26wmf19 already).

After that is deployed (or simultaneously), you should be able to re-enable notifications.

Change 232576 had a related patch set uploaded (by Mattflaschen):
Cleanup debugging code for isTalkpageManagerUser

https://gerrit.wikimedia.org/r/232576

That most recent patch (232576) doesn't need to be SWAT-ed.

• Mattflaschen-WMF moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Aug 19 2015, 7:46 PM

Change 232567 merged by jenkins-bot:
Add debugging code to detect and workaround type hint failure

https://gerrit.wikimedia.org/r/232567

• Mattflaschen-WMF mentioned this in rMW2fe455bef574: Updated mediawiki/core Project: mediawiki/extensions/Flow….Aug 19 2015, 11:08 PM

• Mattflaschen-WMF mentioned this in rMW1cfbdfc0097f: Updated mediawiki/core Project: mediawiki/extensions/Flow….

• Mattflaschen-WMF mentioned this in rEFLW815aa3294d65: Add debugging code to detect and workaround type hint failure.

• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 20 2015, 12:00 AM

Catrope removed a project: Collaboration-Team-Triage.Aug 20 2015, 12:01 AM