Page MenuHomePhabricator

[Task] Refactor Special:Recentchanges to use WatchedItemStore
Open, Stalled, MediumPublic3 Story Points

Details

Related Gerrit Patches:

Event Timeline

Addshore added a comment.EditedApr 13 2016, 12:45 PM

Mainly this bit of code which could probably be swapped out for something in WatchedItemStore straight away

						$dbr->selectField(
							'watchlist',
							'COUNT(*)',
							[
								'wl_namespace' => $obj->rc_namespace,
								'wl_title' => $obj->rc_title,
							],
							__METHOD__ . '-watchers'
						);

Change 283385 had a related patch set uploaded (by Addshore):
Use WatchedItemStore for SP:RC watchers countm

https://gerrit.wikimedia.org/r/283385

So there is some stuff in there which selects with joins on the RC table.
I still don't know what the best approach there is and it may be worth leaving it

@Addshore I have not looked closely, but my intuition is this: Don't move the compelx queries into WatchedItemStore, but into a separate class, WatchedItemQuery or some such. Also split out the UI bit into RCView or ChagnesView or something. The special page should then just glue the view to the query service, and handle parameters. Not sure whether the form should be defiend by the view or the special page itself though.

Addshore claimed this task.Apr 14 2016, 9:20 AM
Addshore moved this task from Doing to Review on the TCB-Team-Sprint-2016-04-13 board.

Change 283385 merged by jenkins-bot:
Use WatchedItemStore for SP:RC watchers count

https://gerrit.wikimedia.org/r/283385

Other than the RC watchlist crossover stuff mentioned above this is all done so moving to done.
The RC / watchlist stuff should likely be done seperatly.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 10:02 PM
Addshore changed the task status from Open to Stalled.Mar 21 2017, 11:50 AM

Stalled pending resuming work here once wl_id is deployed on wmf sites (T130067).

Addshore removed Addshore as the assignee of this task.Jan 12 2018, 12:07 PM

wl_id now exists but this is still stalled.

Unassigning myself for now.

Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 17 2019, 4:58 PM
JTannerWMF moved this task from Inbox to External on the Growth-Team board.Jan 17 2019, 9:08 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptOct 25 2019, 7:56 PM