Languages that have variants are shown as a gray interlanguage link in the Wikipedia in the same language
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Amire80
	Jun 23 2016, 2:31 PM

Description

To reproduce:

Define Chinese as an Accept-Language in your browser.
Enable the Content Translation beta feature in the Chinese Wikipedia
Open https://zh.wikipedia.org/wiki/ASCII

Observed: Gray interlanguage link to "中文" appears on top of the interlanguage links list.

Expected: "中文" is Chinese itself, so it must not appear there.

I debugged this a bit, and found that the reason for it is that we are filtering out wgPageContentLanguage, and for languages with variants it's not equal to the primary language code. For Chinese, the primary language code is "zh", but wgPageContentLanguage is "zh-hant", "zh-hk", "zh-hans", etc.

We need to use something other than wgPageContentLanguage or to cut the suffix from these languages—zh, sr, ku, uz, tg, ug.

Reported at https://www.mediawiki.org/wiki/Topic:T4bamtsslf4y1b0y

High prio because it affects several major languages.

Details

	Subject	Repo	Branch	Lines +/-
	Fix gray interlanguage links for languages with variants	mediawiki/extensions/ContentTranslation	master	+1 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T102107 Enable Content Translation in Catalan Wikipedia for all logged-in users
Open	None	T116533 ContentTranslation issues that affect people who aren't editors or translators (tracking)
Open	None	T126916 ContentTranslation gray interlanguage links issues (tracking)
Open	None	T105577 use geolocation to show the gray interlanguage link in ContentTranslation
Open	None	T105578 Incorrect language code handling in ContentTranslation (tracking)
Resolved	• Petar.petkovic	T138494 Languages that have variants are shown as a gray interlanguage link in the Wikipedia in the same language

Event Timeline

Amire80 created this task.Jun 23 2016, 2:31 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 23 2016, 2:31 PM

Amire80 triaged this task as High priority.Jun 23 2016, 2:33 PM

Amire80 added a project: Essential-Work.

Amire80 updated the task description. (Show Details)

Amire80 moved this task from Needs Triage to Bugs on the ContentTranslation board.

C933103 subscribed.Jul 7 2016, 2:54 PM

Liuxinyu970226 subscribed.Aug 10 2016, 1:00 AM

Shizhao added a project: Chinese-Sites.Dec 27 2016, 8:39 AM

Restricted Application added a subscriber: Stang. · View Herald TranscriptDec 27 2016, 8:39 AM

If UI language from zh set as wuu, yue, zh-classical in chinnese wikipedia, a gray interlanguage link to "吴语", "粵語", "文言" appears on top of the interlanguage links list. and reset to zh, still not disappear. but if UI language from zh set as zh-hans, zh-hant, zh-tw etc, working ok. clean cookies is working ok.

Shizhao added a project: UniversalLanguageSelector.Jan 9 2017, 12:37 PM

• Nikerabbit removed a project: UniversalLanguageSelector.Jan 10 2017, 5:07 AM

Since this can only be reproduced on wikis with MediaWiki-Language-converter

Liuxinyu970226 updated the task description. (Show Details)Feb 18 2017, 1:19 AM

Liuxinyu970226 mentioned this in T116401: qug, pt-br, en-gb, dty, zh-hant, frc and other irrelevant languages appear in the ContentTranslation suggestions language selector.

In T138494#2927764, @Shizhao wrote:

If UI language from zh set as wuu, yue, zh-classical in chinnese wikipedia, a gray interlanguage link to "吴语", "粵語", "文言" appears on top of the interlanguage links list. and reset to zh, still not disappear. but if UI language from zh set as zh-hans, zh-hant, zh-tw etc, working ok. clean cookies is working ok.

As you even used yue, why zh-classical instead of lzh?

Because that's the wikipedia site name assignment, and human may or may not
know to actually check the option values…

In T138494#3039257, @Arthur2e5 wrote:

Because that's the wikipedia site name assignment, and human may or may not
know to actually check the option values…

Please see T30443 for my concern about zh-classical

Liuxinyu970226 added a parent task: T105578: Incorrect language code handling in ContentTranslation (tracking).Feb 20 2017, 12:42 AM

Liuxinyu970226 awarded a token.Mar 9 2017, 12:19 PM

Amire80 lowered the priority of this task from High to Medium.Apr 9 2017, 2:19 PM

Amire80 added a project: ContentTranslation-out-of-beta.

Amire80 moved this task from Bugs to Out of Beta on the ContentTranslation board.May 9 2017, 5:45 PM

Liuxinyu970226 mentioned this in T166872: Chinese transcription link in Chinese wikipedia.Jun 2 2017, 11:43 AM

Liuxinyu970226 merged a task: T166872: Chinese transcription link in Chinese wikipedia.

Liuxinyu970226 added subscribers: Yannmaco, TTO.

Is there any progression on this topic ...... ?

Amire80 moved this task from Backlog to Non-CX users on the ContentTranslation-out-of-beta board.Jun 25 2017, 4:49 PM

Bugreporter merged a task: T173667: ContentTranslation: Chinese is shown as an option on the Chinese Wikipedia.Aug 20 2017, 2:56 PM

Bugreporter added a subscriber: Jc86035.

Amire80 mentioned this in T183648: CLL has the problem when displaying gray links for languages with variants.Jan 17 2018, 11:11 AM

• Petar.petkovic merged a task: T183648: CLL has the problem when displaying gray links for languages with variants.Feb 9 2018, 1:27 AM

• Petar.petkovic added subscribers: • Petar.petkovic, santhosh, • Nikerabbit.

Change 409194 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix gray interlanguage links for languages with variants

https://gerrit.wikimedia.org/r/409194

gerritbot added a project: Patch-For-Review.Feb 9 2018, 1:38 AM

santhosh assigned this task to • Petar.petkovic.Feb 9 2018, 4:06 AM

santhosh added a project: Language-2018-Jan-Mar.

Change 409194 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix gray interlanguage links for languages with variants

https://gerrit.wikimedia.org/r/409194

santhosh moved this task from Backlog to QA on the Language-2018-Jan-Mar board.Feb 9 2018, 4:58 AM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 9 2018, 5:00 AM

• Petar.petkovic removed a project: Patch-For-Review.Feb 9 2018, 11:47 AM

Thanks for fixing.

Tested in production. Looks good to me, but I'd appreciate it if more people will test it, because these languages with variants often display elusive bugs :)

@Yannmaco, @Liuxinyu970226, @Arthur2e5, can you test please? Thank you!

Amire80 moved this task from QA to Done on the Language-2018-Jan-Mar board.Feb 15 2018, 9:00 PM

Checked in zh wmf.21 (Accept-language- zh-TW,zh; (also tried with zh,zh-TW;) - the issue seems to be fixed. Agree with @Amire80 - would be great if more people will look at it.

Etonkovidova moved this task from Done to Blocked on the Language-2018-Jan-Mar board.Feb 15 2018, 10:22 PM

Arrbee moved this task from Blocked to QA on the Language-2018-Jan-Mar board.Feb 16 2018, 7:04 AM

Tested and working on srwiki.
This was really annoying issue, glad it is resolved.

Etonkovidova closed this task as Resolved.Feb 16 2018, 11:49 PM

Confirmed in Kazakh, Kurdish (Kurmanci), Uzbek as fixed too.

Liuxinyu970226 unsubscribed.Feb 17 2018, 1:18 AM

• Petar.petkovic moved this task from QA to Done on the Language-2018-Jan-Mar board.Feb 17 2018, 11:16 AM

Shizhao moved this task from Backlog to Closed on the Chinese-Sites board.Feb 23 2018, 2:49 AM

Amire80 mentioned this in T105062: Investigate publishing errors where source language = target language.Mar 4 2018, 9:34 AM

Stang unsubscribed.Nov 1 2021, 8:14 PM

Winston_Sung moved this task from Backlog to Extensions/Skins on the MediaWiki-Language-converter board.Dec 27 2023, 6:25 PM

	F5260328: 捕获.PNG
	Jan 9 2017, 12:34 PM

Languages that have variants are shown as a gray interlanguage link in the Wikipedia in the same languageClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Languages that have variants are shown as a gray interlanguage link in the Wikipedia in the same language
Closed, ResolvedPublic
Actions

Related Objects
Search...