Page MenuHomePhabricator

Send one, get three: Duplication of Wikilove barnstar
Open, Needs TriagePublicBUG REPORT

Description

See https://www.mediawiki.org/wiki/User_talk:IKhitron

I clicked once.

Based on testing at https://www.mediawiki.org/wiki/User_talk:Quiddity_(WMF)#A_barnstar_for_you.21 the steps to reproduce might be:

  1. Go to Quiddity's talk page on mw.org
  2. Open Wikilove. Choose a barnstar from the drop-down menu.
  3. Press Esc to cancel. (Go do something else, e.g., scroll down the page or open a link in another tab.) (If you skip this step, then Wikilove works normally.)
  4. Open Wikilove again. Choose a barnstar from the drop-down menu.
  5. Press Esc to cancel. (Go do something else, e.g., scroll down the page or open a link in another tab.)
  6. Open Wikilove a third time. Choose a barnstar (maybe needs to be the same as the first one?) from the drop-down menu.
  7. Fill in the box.
  8. Send Wikilove.
  9. See two identical barnstars on the page.
  10. Refresh the page.
  11. See three identical barnstars on the page.

I've only tested this in Flow.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

And I thought you just like me so much... ;-)

And @Quiddity, you are going to get a lot of stars...

But, who wouldn't want to wake up in the morning to a pile of good-faith barnstars? ;-)

The bug happens only if a user does not navigate away from the page.

Izno changed the subtype of this task from "Task" to "Bug Report".Oct 13 2024, 9:48 PM

I re-checked the steps on testwiki wmf.2 - the issue was not reproducible.
The following items from the issue description are not applicable anymore:

  • the issue was happening on Flow-based or wikitext-based User talk pages; presently, Flow-based User talk pages are in read-only mode. The new User talk pages do not show the issue
  • the issue description refers to "Press Esc to cancel" the wikilove popup - presently it's not possible to dismiss the popup with the Esc button
  • no duplicate Echo notifications are sent
  • no duplicate wikilove messages are displayed on User talk page.

As far as I could see, the issue is not reproducible anymore - if there are some steps (or environment) that I missed, please let me know.

The only issue that is remained - a unnecessary red warning appears when a wikilove is sent; repeated clicks on the Send button will display repeated warnings (the screenshot is from https://phabricator.wikimedia.org/T210883#5362071). The warnings are showed only momentarily.

Screen Shot 2019-06-12 at 3.59.22 PM.png (525×1 px, 286 KB)

Flow-based User talk pages are in read-only mode

only true on some wikis. Flow is still editable on MediaWiki.org where there are thousands of talk page messages.

But at the same time Flow is dying so if there truly is a Flow-specific bug here it's not worth fising.

Flow-based User talk pages are in read-only mode

only true on some wikis. Flow is still editable on MediaWiki.org where there are thousands of talk page messages.

But at the same time Flow is dying so if there truly is a Flow-specific bug here it's not worth fising.

Thank you, @Pppery ! Adding Editing team for possible follow-ups.