Page MenuHomePhabricator
Create Task
Maniphest T155147

Do not initialise the database in tests when not needed
Closed, ResolvedPublic
Actions

Description

In the unit tests, the database is initialized in MediaWikiTestCase::run(). Since e638075, it is initialized "once" per class type (whatever is the result of needsDB() because it’s a OR) or when needsDB() is true.

On classes where no database is needed, the database is initialised anyway, it shouldn’t. This makes the tests unnecessarily take a bit longer. The change https://gerrit.wikimedia.org/r/#/c/328718 was meant to fix this thing, but an additional issue appeared: the test database is the object property $db, but its state is controlled by a static variable ($dbSetup) which is not kept in sync with $db, because when the object is destroyed the $db is unset but $dbSetup remains. In the next test, the $db is not initialized (since $dbSetup is true) but the test expects it is and $this->db->whatever() fails.

In MediaWikiTestCase::run() there is a TODO comment indicating the DB setup should be done in setUpBeforeClass. If this is chosen, all DB-related variables will be static and should be consistently initialized and destroyed.

This bug is created to track the small refactoring/rewrite of the part of code used to initialise and destruct the database in the tests, in order to finally submit the proposed patch https://gerrit.wikimedia.org/r/#/c/328718 without any error. It will also improve T93556. Possibly, if the code is moved in setUpBeforeClass, it should be checked that this new setup is supported by major extensions.

Details

SubjectRepoBranchLines +/-
phpunit: Use StaticUserOptionsLookup when storage is disabledmediawiki/coremaster+13 -14
Mark AccessTokenEndpointTest as needing the DBmediawiki/extensions/OAuthmaster+1 -0
phpunit: Do not setup the test DB for tests that don't need itmediawiki/coremaster+63 -12
Avoid DB access in non-database testsmediawiki/extensions/CirrusSearchmaster+113 -17
session: Do not save user token in non-database testsmediawiki/coremaster+5 -0
Make WikiPageConfigLoader a no-op in non-database integration testsmediawiki/extensions/GrowthExperimentsmaster+33 -7
tests: Fix invalid user in HomepageModuleRegistryTestmediawiki/extensions/GrowthExperimentsmaster+8 -5
Throw exception in getTestUser etc. if the test doesn't need the DBmediawiki/coremaster+14 -0
tests: Avoid DB access in non-Database testsmediawiki/extensions/AbuseFiltermaster+15 -14
Avoid DB access in non-database testsmediawiki/coremaster+103 -16
Avoid DB access in more non-Database testsmediawiki/coremaster+44 -20
Avoid DB access in non-database testsmediawiki/extensions/GeoDatamaster+37 -14
Avoid DB access in non-Database testsmediawiki/extensions/Mathmaster+22 -2
Avoid DB access in non-database testsmediawiki/skins/MinervaNeuemaster+23 -2
LogFormatterTestCase: avoid database accessmediawiki/coremaster+116 -5
tests: Add `@group Database` to tests that need itmediawiki/extensions/Translatemaster+18 -3
tests: Avoid database usage when possiblemediawiki/coremaster+40 -43
tests: Add `@group Database` where neededmediawiki/extensions/TimedMediaHandlermaster+2 -0
Avoid loading gadgets if the storage backend is disabled in testsmediawiki/extensions/Gadgetsmaster+7 -0
Deprecate MediaWikiIntegrationTestCase::$usersmediawiki/coremaster+82 -53
phpunit: Do not call addCoreDBData if the test doesn't need the DBmediawiki/coremaster+13 -5
[WIP] Do not setup the test database for tests which don't need itmediawiki/coremaster+52 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
daniel added a comment.Sep 11 2018, 5:10 PM

For the record: as Tim said on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/377041#message-e2b7cc4df2aae9c6b8d307a854e9bd8af7e00352, we need to make sure that no test can ever write to the real DB, and thus need to set up a fake DB before running any test.

It would make sense to set up a dysfunctional DB for tests that don't declare to need a database. One simple way to do that is to set the table prefix to nensense until we hit a test that has needsDb() set to true, at which point a functional prefix with fake tables would be set up.

Tgr mentioned this in T201290: CentralAuth causes DBAccessError in non-database phpunit suite.Dec 7 2018, 11:38 PM
Krinkle raised the priority of this task from Medium to High.Dec 8 2018, 10:01 PM
Krinkle added a parent task: T201290: CentralAuth causes DBAccessError in non-database phpunit suite.

Raising priority per T201290.

Jdforrester-WMF subscribed.Dec 10 2018, 6:32 PM
Krinkle mentioned this in T200709: MediaWiki phpunit databaseless fails, because it's trying to access the database.Jun 9 2019, 4:48 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:01 PM
Ammarpad merged a task: T268170: Unit tests without database group can still have access to the database.Nov 20 2020, 2:49 AM
Ammarpad added a subscriber: Umherirrender.
Umherirrender added a comment.Nov 20 2020, 12:59 PM

This can have a big impact, I was playing with it in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/618757

DannyS712 added a project: Technical-Debt.Dec 10 2020, 9:29 PM
DannyS712 subscribed.
Umherirrender unsubscribed.Feb 27 2021, 9:43 PM
Tgr merged a task: T301643: All MediaWikiIntegrationTestCase tests set up the database.Feb 13 2022, 11:35 PM
gerritbot added a comment.Feb 14 2022, 12:42 AM

Change 377041 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] [WIP] Do not setup the test database for tests which don't need it

https://gerrit.wikimedia.org/r/377041

Tgr mentioned this in T298751: Reduce db queries in load.php calls.Feb 14 2022, 3:27 AM
gerritbot added a comment.Feb 2 2023, 7:34 AM

Change 377041 abandoned by Gergő Tisza:

[mediawiki/core@master] [WIP] Do not setup the test database for tests which don't need it

Reason:

https://gerrit.wikimedia.org/r/377041

Daimona subscribed.Jul 15 2023, 4:37 PM

This really needs to be done. Aside from all the things already mentioned in this task, I tried running paratest on MW core for integration tests (no-database ones!) and I got some random DB-related failures. This is surprising to say the least. I'll take a stab at this as part of the broader PHPUnit refactoring for T227900 etc.

Daimona added a parent task: T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.Jul 15 2023, 4:54 PM
Daimona added a comment.Jul 15 2023, 4:59 PM

Also, re making sure that no tests access the real database: before running any tests (e.g., in setUpBeforeClass or similar) we could disable the DBLoadBalancerFactory, and perhaps for good measure set the DB credential globals to something random.

gerritbot added a comment.Jul 15 2023, 8:16 PM

Change 377041 restored by Daimona Eaytoy:

[mediawiki/core@master] [WIP] Do not setup the test database for tests which don't need it

https://gerrit.wikimedia.org/r/377041

gerritbot added a comment.Jul 15 2023, 8:17 PM

Change 377041 abandoned by Daimona Eaytoy:

[mediawiki/core@master] [WIP] Do not setup the test database for tests which don't need it

Reason:

Actually, it's probably better to start over and link to this patch instead.

https://gerrit.wikimedia.org/r/377041

gerritbot added a comment.Jul 15 2023, 8:58 PM

Change 938387 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] phpunit: Do not setup the test DB for tests that don't need it

https://gerrit.wikimedia.org/r/938387

Daimona added a comment.Jul 15 2023, 10:50 PM

I was looking at the failures of the patch above. I'm generally not scared when there's a lot of stuff to fix, but here there's really a lot of stuff to fix. I couldn't even find any low hanging fruits to cut down cleverly (i.e., not by just adding @group Database) on the failures. One of the biggest offenders seems to be ResourceLoader (because it has lots of tests, but also an unconditional wfGetDB call). Another one is the service instantiator of ExternalStoreFactory (used indirectly by several services), which calls LoadBalancer::getLocalDomainID(). I'll maybe try and fix something, but fixing all tests is really hard, unless we want to just put all the failing ones in the database group and then have some automatic check to flag database tests that don't actually need the database to move them back when possible.

gerritbot added a comment.Jul 16 2023, 12:25 AM

Change 938406 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] tests: Avoid database usage when possible

https://gerrit.wikimedia.org/r/938406

gerritbot added a comment.Jul 16 2023, 12:48 PM

Change 938440 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] phpunit: Do not call addCoreDBData if the test doesn't need the DB

https://gerrit.wikimedia.org/r/938440

gerritbot added a comment.Jul 16 2023, 9:36 PM

Change 938463 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Throw exception in getTestUser etc. if the test doesn't need the DB

https://gerrit.wikimedia.org/r/938463

gerritbot added a comment.Jul 16 2023, 10:17 PM

Change 938464 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Deprecate MediaWikiIntegrationTestCase::$users

https://gerrit.wikimedia.org/r/938464

Daimona added a comment.Jul 17 2023, 1:59 PM

I was thinking about this, and I think we should allow calls to simple methods like LBFactory::getLocalDomainID for now, but mock their return value. As long as the tests don't make any queries, it should be fine. getLocalDomainID is used a lot in ServiceWiring and other places that simply try to figure out what's the local wiki. I think this is fine, and it would avoid the majority of the failures I've seen.

daniel added a comment.EditedJul 17 2023, 3:24 PM
In T155147#9019721, @Daimona wrote:

I was thinking about this, and I think we should allow calls to simple methods like LBFactory::getLocalDomainID for now, but mock their return value. As long as the tests don't make any queries, it should be fine. getLocalDomainID is used a lot in ServiceWiring and other places that simply try to figure out what's the local wiki. I think this is fine, and it would avoid the majority of the failures I've seen.

Using getLocalDomainID() to get the logical wiki IDs seems backwards, we should provide a better way to do this.

We currently don't have a great place for this info, but I could live with MediaWikiServices::getWikiID(). This matches the idea that eventually (tm), we want to be able to have multiple instance of MediaWikiServices, each configured for a different wiki, happily coexisting.

gerritbot added a comment.Jul 17 2023, 4:11 PM

Change 938886 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] LogFormatterTestCase: avoid database access

https://gerrit.wikimedia.org/r/938886

Daimona added a comment.Jul 17 2023, 11:22 PM
In T155147#9020194, @daniel wrote:
In T155147#9019721, @Daimona wrote:

I was thinking about this, and I think we should allow calls to simple methods like LBFactory::getLocalDomainID for now, but mock their return value. As long as the tests don't make any queries, it should be fine. getLocalDomainID is used a lot in ServiceWiring and other places that simply try to figure out what's the local wiki. I think this is fine, and it would avoid the majority of the failures I've seen.

Using getLocalDomainID() to get the logical wiki IDs seems backwards, we should provide a better way to do this.

We currently don't have a great place for this info, but I could live with MediaWikiServices::getWikiID(). This matches the idea that eventually (tm), we want to be able to have multiple instance of MediaWikiServices, each configured for a different wiki, happily coexisting.

I agree, and more generally, anything related to obtaining a wiki ID seems confusing at the moment. For now though, I'd really just like to get this task done, doing whatever it takes to make everything pass but without bigger refactorings if possible.

Also, FTR: another big offender is getTestUser (& friends). I'm restricting those to DB tests only, and I think r938463 will pass once all the patches I've created for extensions are merged. Then there are many more failures, but I'll get to them eventually.

Daimona mentioned this in T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel.Jul 18 2023, 1:08 AM
Daimona mentioned this in T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.Jul 20 2023, 8:23 PM
Ladsgroup subscribed.Jul 20 2023, 11:40 PM
Daimona added a subtask: T342428: Avoid creating a page and user for every PHPUnit Database test.Jul 21 2023, 12:14 PM
Daimona removed a subtask: T342428: Avoid creating a page and user for every PHPUnit Database test.
Daimona added a parent task: T342428: Avoid creating a page and user for every PHPUnit Database test.
Daimona mentioned this in T342428: Avoid creating a page and user for every PHPUnit Database test.
Daimona mentioned this in T342301: Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking.Jul 21 2023, 12:38 PM
gerritbot added a comment.Jul 25 2023, 12:31 PM

Change 938440 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Do not call addCoreDBData if the test doesn't need the DB

https://gerrit.wikimedia.org/r/938440

gerritbot added a comment.Jul 25 2023, 12:58 PM

Change 938464 merged by jenkins-bot:

[mediawiki/core@master] Deprecate MediaWikiIntegrationTestCase::$users

https://gerrit.wikimedia.org/r/938464

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 25 2023, 1:00 PM
gerritbot added a comment.Jul 29 2023, 12:45 PM

Change 942763 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Gadgets@master] Avoid loading gadgets if the storage backend is disabled in tests

https://gerrit.wikimedia.org/r/942763

gerritbot added a comment.Jul 30 2023, 8:32 PM

Change 942763 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Avoid loading gadgets if the storage backend is disabled in tests

https://gerrit.wikimedia.org/r/942763

gerritbot added a comment.Jul 30 2023, 11:34 PM

Change 942818 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/TimedMediaHandler@master] tests: Add `@group Database` where needed

https://gerrit.wikimedia.org/r/942818

gerritbot added a comment.Jul 30 2023, 11:43 PM

Change 942819 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Translate@master] tests: Add `@group Database` to tests that need it

https://gerrit.wikimedia.org/r/942819

gerritbot added a comment.Jul 31 2023, 12:04 AM

Change 942820 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] session: Do not save user token in non-database tests

https://gerrit.wikimedia.org/r/942820

gerritbot added a comment.Jul 31 2023, 1:10 AM

Change 942821 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/AbuseFilter@master] tests: Avoid DB access in non-Database tests

https://gerrit.wikimedia.org/r/942821

gerritbot added a comment.Jul 31 2023, 3:57 AM

Change 942818 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] tests: Add `@group Database` where needed

https://gerrit.wikimedia.org/r/942818

gerritbot added a comment.Aug 1 2023, 12:58 AM

Change 943649 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Avoid DB access in non-database tests

https://gerrit.wikimedia.org/r/943649

gerritbot added a comment.Aug 1 2023, 7:11 AM

Change 942819 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] tests: Add `@group Database` to tests that need it

https://gerrit.wikimedia.org/r/942819

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 1 2023, 8:00 AM
gerritbot added a comment.Aug 1 2023, 9:07 AM

Change 938406 merged by jenkins-bot:

[mediawiki/core@master] tests: Avoid database usage when possible

https://gerrit.wikimedia.org/r/938406

gerritbot added a comment.Aug 1 2023, 3:06 PM

Change 938886 merged by jenkins-bot:

[mediawiki/core@master] LogFormatterTestCase: avoid database access

https://gerrit.wikimedia.org/r/938886

gerritbot added a comment.Aug 1 2023, 6:04 PM

Change 944301 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/skins/MinervaNeue@master] Avoid DB access in non-database tests

https://gerrit.wikimedia.org/r/944301

gerritbot added a comment.Aug 2 2023, 1:08 AM

Change 944356 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CirrusSearch@master] Avoid DB access in non-database tests

https://gerrit.wikimedia.org/r/944356

gerritbot added a comment.Aug 2 2023, 6:01 PM

Change 944970 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/GrowthExperiments@master] Make WikiPageConfigLoader a no-op in non-database integration tests

https://gerrit.wikimedia.org/r/944970

gerritbot added a comment.Aug 2 2023, 6:41 PM

Change 944301 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Avoid DB access in non-database tests

https://gerrit.wikimedia.org/r/944301

Daimona mentioned this in T343500: Add test to verify that tests in the Database group actually use the database.Aug 4 2023, 1:01 AM
gerritbot added a comment.Aug 4 2023, 1:18 AM

Change 945695 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/GeoData@master] Avoid DB access in non-database tests

https://gerrit.wikimedia.org/r/945695

gerritbot added a comment.Aug 4 2023, 2:53 PM

Change 945814 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Math@master] Avoid DB access in non-Database tests

https://gerrit.wikimedia.org/r/945814

Daimona claimed this task.Aug 4 2023, 7:42 PM

This is relatively close to completion now. With all the patches currently in review (probably around 15-20), there should be <50 failures in core + gated extensions and skins. One thing to note is that tests for extensions not in the gate might be broken by the core patch. The quickest fix is to simply add @group Database, although in some cases it can be avoided in favour of mocks.

gerritbot added a comment.Aug 5 2023, 6:12 PM

Change 945814 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Avoid DB access in non-Database tests

https://gerrit.wikimedia.org/r/945814

gerritbot added a comment.Aug 5 2023, 11:04 PM

Change 945918 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Avoid DB access in more non-Database tests

https://gerrit.wikimedia.org/r/945918

gerritbot added a comment.Aug 6 2023, 7:34 AM

Change 945695 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Avoid DB access in non-database tests

https://gerrit.wikimedia.org/r/945695

gerritbot added a comment.Aug 6 2023, 4:24 PM

Change 945918 merged by jenkins-bot:

[mediawiki/core@master] Avoid DB access in more non-Database tests

https://gerrit.wikimedia.org/r/945918

gerritbot added a comment.Aug 6 2023, 11:16 PM

Change 943649 merged by jenkins-bot:

[mediawiki/core@master] Avoid DB access in non-database tests

https://gerrit.wikimedia.org/r/943649

Daimona added a comment.Aug 7 2023, 12:42 AM

I ran

composer phpunit:entrypoint -- --exclude-group Broken,ParserFuzz,Stub,Database,Standalone

(same command used in CI) in my MediaWiki-Docker setup with a bunch of extensions enabled, first with r942820 checked out (patch immediately before the ones that removes the redundant DB setup), and then with r938387 (patch that removes the redundant setup). Here are the results; you can ignore the failure, it's caused by T342193.

Before:

Time: 02:47.812, Memory: 927.50 MB

FAILURES!
Tests: 28483, Assertions: 283078, Failures: 1, Skipped: 172.

After:

Time: 02:27.406, Memory: 935.50 MB

FAILURES!
Tests: 28483, Assertions: 283078, Failures: 1, Skipped: 172.

Which means about 20 seconds saved (YMMV, of course). I should also note that saving time was not the main goal of this task though, so I would consider this a nice bonus.

gerritbot added a comment.Aug 7 2023, 1:13 PM

Change 942821 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] tests: Avoid DB access in non-Database tests

https://gerrit.wikimedia.org/r/942821

gerritbot added a comment.Aug 7 2023, 1:13 PM

Change 938463 merged by jenkins-bot:

[mediawiki/core@master] Throw exception in getTestUser etc. if the test doesn't need the DB

https://gerrit.wikimedia.org/r/938463

gerritbot added a comment.Aug 13 2023, 12:47 AM

Change 948223 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/GrowthExperiments@master] tests: Fix invalid user in HomepageModuleRegistryTest

https://gerrit.wikimedia.org/r/948223

gerritbot added a comment.Aug 13 2023, 7:54 PM

Change 948223 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Fix invalid user in HomepageModuleRegistryTest

https://gerrit.wikimedia.org/r/948223

gerritbot added a comment.Aug 15 2023, 7:08 PM

Change 948194 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] phpunit: Use StaticUserOptionsLookup when storage is disabled

https://gerrit.wikimedia.org/r/948194

Daimona merged a task: T200709: MediaWiki phpunit databaseless fails, because it's trying to access the database.Aug 19 2023, 4:56 PM
Daimona added a subscriber: • Imarlier.
Daimona mentioned this in T243947: light Integration tests without DB.Aug 19 2023, 5:59 PM
gerritbot added a comment.Aug 20 2023, 1:33 AM

Change 944970 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Make WikiPageConfigLoader a no-op in non-database integration tests

https://gerrit.wikimedia.org/r/944970

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 29 2023, 10:01 PM
gerritbot added a comment.Aug 31 2023, 1:11 PM

Change 942820 merged by jenkins-bot:

[mediawiki/core@master] session: Do not save user token in non-database tests

https://gerrit.wikimedia.org/r/942820

gerritbot added a comment.Aug 31 2023, 3:19 PM

Change 944356 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Avoid DB access in non-database tests

https://gerrit.wikimedia.org/r/944356

gerritbot added a comment.Aug 31 2023, 3:19 PM

Change 938387 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Do not setup the test DB for tests that don't need it

https://gerrit.wikimedia.org/r/938387

Daimona closed this task as Resolved.Aug 31 2023, 3:19 PM
Daimona removed a project: Patch-For-Review.
gerritbot added a comment.Sep 5 2023, 7:41 PM

Change 954987 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/OAuth@master] Mark AccessTokenEndpointTest as needing the DB

https://gerrit.wikimedia.org/r/954987

gerritbot added a project: Patch-For-Review.Sep 5 2023, 7:41 PM
gerritbot added a comment.Sep 5 2023, 8:21 PM

Change 954987 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Mark AccessTokenEndpointTest as needing the DB

https://gerrit.wikimedia.org/r/954987

Daimona removed a project: Patch-For-Review.Sep 5 2023, 8:24 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.26; 2023-09-12); removed MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 5 2023, 9:00 PM
gerritbot added a comment.Mar 27 2024, 8:40 AM

Change #948194 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Use StaticUserOptionsLookup when storage is disabled

https://gerrit.wikimedia.org/r/948194

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 27 2024, 9:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL