Page MenuHomePhabricator
Create Task
Maniphest T177260

Rewrite disabled MobileFrontend browser tests to phpunit tests and Node.js browser tests
Closed, DeclinedPublic8 Estimated Story Points
Actions

Description

Our browser tests for MobileFrontend were broken and disabled. This task deals with the cleanup related to restoring them in the MobileFrontend extension.

Following an audit, new guidelines https://www.mediawiki.org/wiki/Reading/Web/QA#What_are_browser_tests_for and discussion of that audit and suggested guidelines it has been proposed that the remaining browser tests are either deleted or reimplemented as phpunit tests, since they do not test behaviour - they test page content.

Acceptance criteria

  • Add new job selenium-daily-beta-MobileFrontend
  • new job selenium-daily-beta-MobileFrontend should be green and passing
  • All tests should run starting from the desktop domain (T130429). This has caused issues historically and should be avoided when rewriting them.
  • special_contributions.feature has been rewritten as a PHPUnit test (and associated code refactored)
  • special_watchlist.feature and special_watchlist_editors.feature have been rewritten as a Node.js test (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/506592/)
  • user_page.feature has been rewritten as a Node.js test
  • special_history.feature and special_history_nojs.feature has been rewritten as a PHPUnit test (and associated code refactored)
  • special_watchlist_newuser.feature has been rewritten as a PHPUnit test (and associated code refactored) - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/506591/1
  • switch_views.feature has been rewritten as a Node.js test
  • Disable the Ruby job in integration/config for daily builds and for commits
  • While working on this, do an audit as originally proposed in T148973 of what we are testing. Remove unnecessary tests and document missing tests. At the end, summarise the browser test for each extension.

Sign off steps

  • Ensure the user_page test has been restored (T221860)

Note: It was skipped indefinitely. The value was not worth the hassle.

Details

SubjectRepoBranchLines +/-
WIP: Rewrite watchlist tests in Node.jsmediawiki/extensions/MobileFrontendmaster+82 -9
Audit: Remove unnecessary browser testsmediawiki/extensions/MobileFrontendmaster+96 -36
Delete selenium-MobileFrontend Jenkins jobintegration/configmaster+0 -5
🏗 Remove Ruby browser testsmediawiki/extensions/MobileFrontendmaster+0 -276
WIP: Rewrite MobileFronted Ruby tests to NodeJSmediawiki/extensions/MobileFrontendmaster+491 -109
Drop Selenium Ruby jobs from Jenkins on MobileFrontendintegration/configmaster+0 -2
Add wdio-mocha-framework to package.jsonmediawiki/extensions/MobileFrontendmaster+1 -0
Migrate browser tests from Ruby to Node.jsmediawiki/extensions/MobileFrontendmaster+609 -621
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson mentioned this in T174018: Port Minerva's 7 Ruby-based browser tests to Selenium Node.js.Feb 7 2018, 7:14 PM
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.
• bmansurov unsubscribed.Feb 7 2018, 8:02 PM
zeljkofilipin added a project: User-zeljkofilipin.Jun 19 2018, 4:27 PM
zeljkofilipin moved this task from Deep work 🌊 to Backlog 🪒 on the User-zeljkofilipin board.
zeljkofilipin updated the task description. (Show Details)Jun 28 2018, 6:17 PM
Jdlrobson updated the task description. (Show Details)Jun 28 2018, 11:41 PM
Jdlrobson merged a task: T130429: Run browser tests on beta cluster from desktop domain.
Jdlrobson added subscribers: • jhobs, • Jhernandez, hashar.
zeljkofilipin mentioned this in T183162: Patches in Gerrit deleting Selenium+Ruby tests for repositories that still have them.Jul 13 2018, 12:05 PM
Jdlrobson renamed this task from Rewrite MobileFrontend's browser tests to Rewrite MobileFrontend's browser tests from Ruby to Node.Aug 14 2018, 9:43 PM
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Nov 20 2018, 3:48 PM
gerritbot added a comment.Apr 10 2019, 10:02 PM

Change 502907 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Migrate browser tests from Ruby to Node.js

https://gerrit.wikimedia.org/r/502907

gerritbot added a comment.Apr 16 2019, 1:20 PM

Change 502907 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Migrate browser tests from Ruby to Node.js

https://gerrit.wikimedia.org/r/502907

gerritbot added a comment.Apr 16 2019, 1:32 PM

Change 504328 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/MobileFrontend@master] Add wdio-mocha-framework to package.json

https://gerrit.wikimedia.org/r/504328

gerritbot added a comment.Apr 16 2019, 2:27 PM

Change 504328 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add wdio-mocha-framework to package.json

https://gerrit.wikimedia.org/r/504328

MBinder_WMF unsubscribed.Apr 16 2019, 3:51 PM
Jdlrobson changed the task status from Stalled to Open.Apr 23 2019, 8:04 AM
Jdlrobson removed the point value for this task.
Jdlrobson updated the task description. (Show Details)Apr 23 2019, 8:10 AM
Jdlrobson moved this task from Upcoming to Needs Prioritization on the Web-Team-Backlog board.

Quite possible we're want to break this down into smaller tasks.

gerritbot added a comment.Apr 25 2019, 4:18 AM

Change 506343 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[integration/config@master] Drop Selenium Ruby jobs from Jenkins on MobileFrontend

https://gerrit.wikimedia.org/r/506343

gerritbot added a comment.Apr 25 2019, 1:42 PM

Change 506343 merged by jenkins-bot:
[integration/config@master] Drop Selenium Ruby jobs from Jenkins on MobileFrontend

https://gerrit.wikimedia.org/r/506343

gerritbot added a comment.Apr 25 2019, 2:14 PM

Change 506427 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] 🏗 Remove Ruby browser tests

https://gerrit.wikimedia.org/r/506427

Jdlrobson updated the task description. (Show Details)Apr 25 2019, 3:01 PM
gerritbot added a comment.Apr 26 2019, 6:49 AM

Change 506591 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Audit: Remove unnecessary browser tests

https://gerrit.wikimedia.org/r/506591

gerritbot added a comment.Apr 26 2019, 6:49 AM

Change 506592 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] WIP: Rewrite watchlist tests in Node.js

https://gerrit.wikimedia.org/r/506592

Jdlrobson added a comment.Apr 26 2019, 6:49 AM

After looking into this, I think we should not bother with most of the Selenium browser tests. Testing behaviour seems important, but not

Let's estimate the work involved to:

  1. Port the watchlist tests I've highlighted as being useful to Node.js
  2. Rewriting the tests I identified in my audit to phpunit
  3. Cleaning up the repo. e.g. https://gerrit.wikimedia.org/r/506427
Jdlrobson moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.Apr 26 2019, 6:49 AM
Jdlrobson renamed this task from Rewrite MobileFrontend's browser tests from Ruby to Node to Rewrite remaining MobileFrontend's Ruby browser tests to phpunit tests and Node.js browser tests.May 1 2019, 8:37 PM
Jdlrobson removed phuedx as the assignee of this task.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson mentioned this in T219920: CI tests disabled: Steps that require login are disabled and should be restored..
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.May 2 2019, 2:11 PM
ovasileva set the point value for this task to 8.May 8 2019, 4:58 PM
zeljkofilipin removed a project: User-zeljkofilipin.May 10 2019, 10:49 AM
gerritbot added a comment.May 24 2019, 2:19 PM

Change 392026 abandoned by Pmiazga:
WIP: Rewrite MobileFronted Ruby tests to NodeJS

https://gerrit.wikimedia.org/r/392026

gerritbot added a comment.Jul 8 2019, 11:32 PM

Change 506427 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] 🏗 Remove Ruby browser tests

https://gerrit.wikimedia.org/r/506427

Jdlrobson removed a project: Patch-For-Review.Jul 8 2019, 11:42 PM
Jdlrobson updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 9 2019, 12:00 AM
hashar unsubscribed.Jul 9 2019, 8:58 AM
zeljkofilipin added a comment.Jul 9 2019, 1:52 PM

Should this task be resolved? There's nothing left in tests/browser.

Jdlrobson added a comment.Jul 9 2019, 2:48 PM

No there are 4 open checkboxes on this ticket. Ruby tests were deleted but not all the tests got ported.

Jdlrobson renamed this task from Rewrite remaining MobileFrontend's Ruby browser tests to phpunit tests and Node.js browser tests to Rewrite disabled MobileFrontend browser tests to phpunit tests and Node.js browser tests.Jul 9 2019, 2:48 PM
gerritbot added a comment.Jul 12 2019, 2:44 PM

Change 522488 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Delete selenium-MobileFrontend Jenkins job

https://gerrit.wikimedia.org/r/522488

gerritbot added a project: Patch-For-Review.Jul 12 2019, 2:44 PM
gerritbot added a comment.Jul 12 2019, 2:47 PM

Change 522488 merged by jenkins-bot:
[integration/config@master] Delete selenium-MobileFrontend Jenkins job

https://gerrit.wikimedia.org/r/522488

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Jul 23 2019, 6:36 PM
Jdlrobson lowered the priority of this task from High to Medium.Jul 31 2019, 4:24 PM
Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Jul 31 2019, 8:34 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
Jdlrobson edited projects, added MobileFrontend (MobileFrontend and MinervaNeue architecture); removed MobileFrontend.
Jdlrobson moved this task from Backlog to Misc on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.Jul 31 2019, 8:40 PM
Jdlrobson mentioned this in T162256: [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions.Aug 1 2019, 8:22 PM
• Jhernandez unsubscribed.Aug 7 2019, 6:48 PM
gerritbot added a comment.Dec 19 2019, 9:34 PM

Change 506591 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Audit: Remove unnecessary browser tests

https://gerrit.wikimedia.org/r/506591

Jdlrobson removed a project: Patch-For-Review.Dec 19 2019, 9:40 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 19 2019, 10:00 PM
gerritbot added a comment.Jun 26 2020, 10:40 PM

Change 506592 abandoned by Jdlrobson:
WIP: Rewrite watchlist tests in Node.js

https://gerrit.wikimedia.org/r/506592

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Tracking).May 4 2021, 11:20 PM
Jdlrobson assigned this task to ovasileva.May 4 2021, 11:48 PM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
Stashbot mentioned this in T280901: MinervaNeue legacy ruby browser tests need to be updated to work on buster/ruby2.5.May 14 2021, 2:16 AM

Mentioned in SAL (#wikimedia-releng) [2021-05-14T02:16:53Z] <James_F> Zuul: [mediawiki/skins/MinervaNeue] Drop Ruby-based selenium job T174018 T177260 T280901

Jdforrester-WMF subscribed.May 14 2021, 2:22 AM

Note: These tests still exist in the repo, but are no longer run.

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Jun 2 2021, 8:18 PM
Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Jun 8 2021, 5:27 PM
Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Jul 15 2021, 10:52 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
zeljkofilipin added a project: Ruby.Sep 17 2021, 10:09 AM
Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Sep 30 2021, 9:23 PM
LGoto removed a project: Web-Team-Backlog (Tracking).Nov 9 2021, 4:23 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking), MobileFrontend; removed Ruby, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend (MobileFrontend and MinervaNeue architecture).Nov 30 2021, 5:55 PM
Jdlrobson removed a project: Web-Team-Backlog (Tracking).Dec 2 2021, 6:53 PM
zeljkofilipin added a comment.Feb 22 2023, 10:24 AM

Is this still relevant, since MobileFrontend doesn't have WebdriverIO tests since 859535?

Jdlrobson edited projects, added MobileFrontend (MobileFrontend Special Pages); removed MobileFrontend.Feb 28 2023, 9:32 PM

it's still relevant in the sense, this ticket was about rewriting some tests that were previously in Selenium to PHPUnit. However now it's likely a sunken cost and the time might be better spent removing these pages e.g. T109277

Aklapper removed ovasileva as the assignee of this task.Nov 21 2023, 8:20 AM

@ovasileva: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Jdlrobson closed this task as Declined.Dec 13 2023, 10:03 PM

The code in question will be removed in T305113 and T266065

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL