WikibaseClient resources are broken in WMF
Closed, ResolvedPublic
Actions

Description

on hewiki for example

Execute on console:

mw.loader.load('wikibase.client.getMwApiForRepo')

Result:

columnNumber: 205
fileName: "https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy"
lineNumber: 159
message: "Unknown dependency: wikibase.api.getLocationAgnosticMwApi"
stack: "sortDependencies@https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:159:205\nsortDependencies@https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:160:35\nresolveStubbornly@https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:160:353\nload@https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:170:963\n@debugger eval code:1:1\n"

Details

Subject	Repo	Branch	Lines +/-
Load Wikibase view on clients as well	mediawiki/extensions/Wikibase	wmf/1.31.0-wmf.8	+8 -0
Manually applied: Load Wikibase view on clients as well	mediawiki/extensions/Wikidata	wmf/1.31.0-wmf.8	+8 -0
Load Wikibase view on clients as well	mediawiki/extensions/Wikibase	master	+8 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Addshore	T173818 [Epic] Kill the Wikidata build step
Resolved	Release	• demon	T178635 1.31.0-wmf.8 deployment blockers
Resolved		Addshore	T180727 WikibaseClient resources are broken in WMF

Event Timeline

eranroz created this task.Nov 16 2017, 6:54 PM

Restricted Application added projects: Wikidata, Performance-Team. · View Herald TranscriptNov 16 2017, 6:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

eranroz triaged this task as Unbreak Now! priority.Nov 16 2017, 6:55 PM

eranroz updated the task description. (Show Details)

Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptNov 16 2017, 6:56 PM

Change 391883 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Load Wikibase API JavaScript on clients as well

https://gerrit.wikimedia.org/r/391883

gerritbot added a project: Patch-For-Review.Nov 16 2017, 7:14 PM

This at least breaks the client link item widget, also probably user scripts.

Due to other problems right now, we can't backport the fix now… but we can probably do that tomorrow or early next week.

Change 391883 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Load Wikibase view on clients as well

https://gerrit.wikimedia.org/r/391883

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 16 2017, 8:00 PM

@hoo does thisneed to be backported to .7 or .8?

Addshore added a project: User-Addshore.Nov 16 2017, 9:11 PM

Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.

Addshore added a parent task: T173818: [Epic] Kill the Wikidata build step.

Sjoerddebruin mentioned this in T180704: "Add links" under "Languages" for newly created pages only shows "An unknown error occured".Nov 16 2017, 10:14 PM

Robby subscribed.Nov 16 2017, 10:16 PM

IKhitron subscribed.Nov 16 2017, 11:17 PM

Krinkle moved this task from Inbox, needs triage to Radar on the Performance-Team board.Nov 17 2017, 2:53 AM

Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.

This needs to be backported to .8 for the Wikidata build and Wikibase extension.

Change 392015 had a related patch set uploaded (by Addshore; owner: Hoo man):
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.8] Load Wikibase view on clients as well

https://gerrit.wikimedia.org/r/392015

Addshore added a parent task: T178635: 1.31.0-wmf.8 deployment blockers.Nov 17 2017, 9:49 AM

Change 392016 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikidata@wmf/1.31.0-wmf.8] Manually applied: Load Wikibase view on clients as well

https://gerrit.wikimedia.org/r/392016

So, the required backports are:

https://gerrit.wikimedia.org/r/392015 which will be a noop in production for now as nothing runs this code.
https://gerrit.wikimedia.org/r/392016 fix the issue for clients on .8 (group0 & group1 currently)

These should block further rollout of .8 to all wikis.

Addshore mentioned this in T178635: 1.31.0-wmf.8 deployment blockers.Nov 17 2017, 9:55 AM

Change 392015 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.8] Load Wikibase view on clients as well

https://gerrit.wikimedia.org/r/392015

Change 392016 merged by jenkins-bot:
[mediawiki/extensions/Wikidata@wmf/1.31.0-wmf.8] Manually applied: Load Wikibase view on clients as well

https://gerrit.wikimedia.org/r/392016