Page MenuHomePhabricator
Create Task
Maniphest T184791

Make rc_patrolled 3-state instead of 2-state to distinguish autopatrolled edits
Closed, ResolvedPublic
Actions

Assigned To
Ladsgroup
Authored By
kaldari
Jan 12 2018, 10:54 AM
Tags
Referenced Files
None
Subscribers
Aklapper
ArielGlenn
Catrope
gerritbot
kaldari
Ladsgroup
MGChecker
View All 9 Subscribers
Tokens
"Orange Medal" token, awarded by Krinkle.

Description

Per T184485#3890167, we should start storing patrolled status as 0 (unpatrolled), 1 (manually patrolled), or 2 (autopatrolled), rather than just 0 (unpatrolled) or 1 (patrolled).

We will also need to update ChangesListSpecialPage::reviewStatusFilterGroupDefinition, various APIs (watchlist, usercontribs, recentchanges), and other ancillary code.

No database schema changes should be necessary. The MSSQL schema will need to be updated.

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Use PRC_AUTOPATROLLED for rollbacks and revdelmediawiki/coremaster+3 -3
Use PRC_AUTOPATROLLED for log entries and category entriesmediawiki/coremaster+2 -2
Consider injected RC records as autopatrolled and not manually patrolledmediawiki/extensions/Wikibasemaster+6 -6
Make autopatrol third option in rc_patrolled and use it in APImediawiki/coremaster+85 -11
Mark autopatrolled RC entries use the right numbermediawiki/extensions/Flowmaster+1 -1
Do not assume rc_patrolled is binarymediawiki/extensions/Newsmaster+1 -1
Do not assume rc_patrolled is binary in ChangesListSpecialPagemediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

kaldari created this task.Jan 12 2018, 10:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2018, 10:54 AM
kaldari added a parent task: T184485: Stop logging autopatrol actions.Jan 12 2018, 10:54 AM
Aklapper added a project: MediaWiki-Patrolling.Jan 12 2018, 10:57 AM
gerritbot mentioned this in T184485: Stop logging autopatrol actions.Jan 12 2018, 2:15 PM
ArielGlenn subscribed.Jan 12 2018, 2:52 PM
Krinkle awarded a token.Jan 12 2018, 10:17 PM
Krinkle added a project: MediaWiki-Recent-changes.Jan 12 2018, 10:29 PM
Krinkle added a project: MediaWiki-Action-API.
Krinkle moved this task from Unsorted to Needs Code on the MediaWiki-Action-API board.
MGChecker subscribed.Jan 13 2018, 12:15 AM
Anomie moved this task from Needs Code to Needs details or plan on the MediaWiki-Action-API board.Jan 16 2018, 3:12 PM
Anomie subscribed.Jan 16 2018, 3:18 PM

various APIs (watchlist, usercontribs, recentchanges)

Since these API modules currently output this field as a boolean, this will need some consideration as to how to best do this without breaking clients, both formatversion=1 clients that use missing for false and empty-string for true and formatversion=2 clients that use actual JSON or PHP booleans. The simplest solution might be to add a second boolean: the existing 'patrolled' response field would be false for rc_patrolled == 0 and true otherwise, with an 'autopatrolled' boolean to differentiate rc_patrolled == 1 and rc_patrolled == 2.

Some thought might also be needed for the existing "show=patrolled" / "show=!patrolled" options. Again, perhaps, "show=autopatrolled" / "show=!autopatrolled" might work.

No database schema changes should be necessary.

The MSSQL schema defines the field as a "bit" datatype, which can only store 0 and 1.

Comments in the other schemas should also be updated (which isn't a schema change).

SBisson subscribed.Jan 16 2018, 6:34 PM
Nirmos subscribed.Jan 31 2018, 12:44 PM
Krinkle triaged this task as Medium priority.Feb 21 2018, 9:15 PM
Ladsgroup mentioned this in T188425: Investigate implementing T184485 (Disable autopatrol logging).Feb 28 2018, 12:05 PM
kaldari updated the task description. (Show Details)Mar 5 2018, 11:24 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Ministry-Of-Magic.Mar 13 2018, 3:26 PM
Ladsgroup claimed this task.Mar 22 2018, 12:52 PM
Ladsgroup moved this task from Tasks to In Progress on the Wikidata-Ministry-Of-Magic board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 22 2018, 12:52 PM
gerritbot subscribed.Mar 22 2018, 12:58 PM

Change 421277 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Do not assume rc_patrolled is binary in ChangesListSpecialPage

https://gerrit.wikimedia.org/r/421277

gerritbot added a project: Patch-For-Review.Mar 22 2018, 12:58 PM
SBisson mentioned this in T190408: Update patrolled RCFilter to distinguish between unpatrolled, autopatrolled, manually patrolled.Mar 22 2018, 2:09 PM
gerritbot added a comment.Mar 22 2018, 2:19 PM

Change 421291 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] [WIP] Make autopatrol thrid option in rc_patrolled and use it in API

https://gerrit.wikimedia.org/r/421291

gerritbot added a comment.Mar 22 2018, 2:25 PM

Change 421293 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Flow@master] Mark autopatrolled RC entries use the right number

https://gerrit.wikimedia.org/r/421293

gerritbot added a comment.Mar 22 2018, 2:26 PM

Change 421294 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/News@master] Do not assume rc_patrolled is binary

https://gerrit.wikimedia.org/r/421294

gerritbot added a comment.Mar 22 2018, 6:35 PM

Change 421277 merged by jenkins-bot:
[mediawiki/core@master] Do not assume rc_patrolled is binary in ChangesListSpecialPage

https://gerrit.wikimedia.org/r/421277

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 22 2018, 7:00 PM
Ladsgroup moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.Mar 22 2018, 8:55 PM
• Jonas moved this task from Needs Review to In Progress on the Wikidata-Ministry-Of-Magic board.Mar 26 2018, 9:47 AM
Ladsgroup moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.Mar 26 2018, 11:34 AM
gerritbot added a comment.Mar 27 2018, 10:40 AM

Change 421294 merged by jenkins-bot:
[mediawiki/extensions/News@master] Do not assume rc_patrolled is binary

https://gerrit.wikimedia.org/r/421294

hoo updated the task description. (Show Details)Mar 28 2018, 12:55 PM
gerritbot added a comment.Apr 3 2018, 4:56 PM

Change 421291 merged by jenkins-bot:
[mediawiki/core@master] Make autopatrol third option in rc_patrolled and use it in API

https://gerrit.wikimedia.org/r/421291

gerritbot added a comment.Apr 3 2018, 4:56 PM

Change 421293 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Mark autopatrolled RC entries use the right number

https://gerrit.wikimedia.org/r/421293

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)); removed MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Apr 3 2018, 5:00 PM
hoo closed this task as Resolved.Apr 3 2018, 5:25 PM
hoo removed a project: Patch-For-Review.
hoo updated the task description. (Show Details)
hoo moved this task from Needs Review to Done on the Wikidata-Ministry-Of-Magic board.
gerritbot added a comment.Apr 4 2018, 1:19 PM

Change 423908 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Consider injected RC records as autopatrolled and not manually patrolled

https://gerrit.wikimedia.org/r/423908

gerritbot added a project: Patch-For-Review.Apr 4 2018, 1:19 PM
gerritbot added a comment.Apr 5 2018, 11:50 AM

Change 423908 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Consider injected RC records as autopatrolled and not manually patrolled

https://gerrit.wikimedia.org/r/423908

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)); removed MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)).Apr 5 2018, 12:00 PM
eranroz mentioned this in T192198: Wikidata doesn't update recentchanges.Apr 14 2018, 5:10 AM
Catrope subscribed.Apr 18 2018, 8:03 PM

There's a question about how unpatrollable things like log entries should be marked: T190408#4128556

gerritbot added a comment.Apr 24 2018, 7:51 PM

Change 428728 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Use PRC_AUTOPATROLLED for all automatic things

https://gerrit.wikimedia.org/r/428728

gerritbot added a comment.Apr 26 2018, 6:24 PM

Change 429249 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Use PRC_AUTOPATROLLED for rollbacks and revdel

https://gerrit.wikimedia.org/r/429249

gerritbot added a comment.Apr 27 2018, 10:36 AM

Change 428728 merged by jenkins-bot:
[mediawiki/core@master] Use PRC_AUTOPATROLLED for log entries and category entries

https://gerrit.wikimedia.org/r/428728

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 27 2018, 11:00 AM
• 238482n375 removed Ladsgroup as the assignee of this task.Jun 15 2018, 8:03 AM
• 238482n375 lowered the priority of this task from Medium to Lowest.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: Ladsgroup, • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper assigned this task to Ladsgroup.Jun 15 2018, 1:00 PM
Aklapper raised the priority of this task from Lowest to Medium.Jun 15 2018, 1:02 PM
Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.
Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.
gerritbot added a comment.Feb 6 2019, 5:42 PM

Change 429249 merged by jenkins-bot:
[mediawiki/core@master] Use PRC_AUTOPATROLLED for rollbacks and revdel

https://gerrit.wikimedia.org/r/429249

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 6 2019, 6:00 PM
Ladsgroup mentioned this in T217388: Use a 4th constant in rc_patrolled for unpatrollable log entries and categorization changes.Mar 1 2019, 7:55 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL