Page MenuHomePhabricator

Pinging users from edit summary should send success/fail mention notification
Open, LowPublic

Description

Acceptance criteria

  • If a user has the 'Failed mention' notification preference enabled and they type a nonexistent username in an edit summary, they should receive a failed mention notification.
  • If a user has the 'Successful mention' notification preference enabled and they type a valid username in an edit summary, they should receive a successful mention notification
  • As only the first 5 usernames in an edit summary should send a mention, the 6th and subsequent usernames should not trigger fail/success mention notifications
  • The existing bundling logic for success/fail notifications should be respected
  • The existing notification icons and copy should be used (screenshot and specification below)
  • The notification should link to the diff page of the mention
  • These notifications do not trigger emails

Existing success/failure notifications

Screen Shot 2018-02-21 at 3.11.20 PM.png (161×700 px, 23 KB)


Basic information

  • Purpose of the notification: Let a user know when they have sent a failed or successful mention in an edit summary
  • Notification name: Edit summary mention success/failure
  • What triggers notification?: Linking to their username in an edit summary (e.g. Made an edit that [[User:Apples]] and I discussed on the talk page.)
  • "Notice" or "Alert"?: Alert
  • Notification type (standard, bundled, expandable bundle): Expandable bundled

Wording

For success:

  • Header: Your mention of username was sent.
  • Body: n/a

For failure:

  • Header: Your mention of username was not sent because the user was not found.
  • Body: n/a

Links

  • Primary link target: Diff page of the edit
  • #1 secondary link target: Page where edit was page
  • #1 secondary link label: Pagename where edit was made

Event Timeline

TBolliger changed the task status from Open to Stalled.Feb 13 2018, 10:44 PM
TBolliger triaged this task as Medium priority.
TBolliger created this task.
TBolliger moved this task from New & TBD Tickets to Bug backlog on the Community-Tech board.
TBolliger changed the task status from Stalled to Open.Feb 21 2018, 11:20 PM
TBolliger removed TBolliger as the assignee of this task.
TBolliger lowered the priority of this task from Medium to Low.
TBolliger updated the task description. (Show Details)
TBolliger moved this task from Bug backlog to Product backlog on the Community-Tech board.

Change #1062775 had a related patch set uploaded (by Mdaniels5757; author: Mdaniels5757):

[mediawiki/extensions/Echo@master] [WIP] add mention success notifications for mentions in an edit summary

https://gerrit.wikimedia.org/r/1062775

Ran into this issue again. I'll have a go at this.

Test wiki created on Patch demo by Mdaniels5757 using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/21e7d3bd09/w

Test wiki on Patch demo by Mdaniels5757 using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/21e7d3bd09/w/