Page MenuHomePhabricator
Create Task
Maniphest T195868

CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

On several Gerrit changes, @WMDE-leszek, @Ladsgroup and @Lucas_Werkmeister_WMDE have gotten errors like the following:

14:51:14 11) Wikibase\Client\Tests\Usage\SiteLinkUsageLookupTest::testGetPagesUsing
14:51:14 Error: Undefined constant 'Wikibase\Client\Store\NS_MAIN'
14:51:14 
14:51:14 /home/jenkins/workspace/mediawiki-extensions-php70-jessie/src/extensions/Wikibase/client/includes/Usage/SiteLinkUsageLookup.php:129
14:51:14 /home/jenkins/workspace/mediawiki-extensions-php70-jessie/src/extensions/Wikibase/client/includes/Usage/SiteLinkUsageLookup.php:148
14:51:14 /home/jenkins/workspace/mediawiki-extensions-php70-jessie/src/extensions/Wikibase/client/includes/Usage/SiteLinkUsageLookup.php:94
14:51:14 /home/jenkins/workspace/mediawiki-extensions-php70-jessie/src/extensions/Wikibase/client/tests/phpunit/includes/Usage/SiteLinkUsageLookupTest.php:126
14:51:14 /home/jenkins/workspace/mediawiki-extensions-php70-jessie/src/tests/phpunit/MediaWikiTestCase.php:423
14:51:14 /home/jenkins/workspace/mediawiki-extensions-php70-jessie/src/maintenance/doMaintenance.php:94

Example job: console

This only happens in the mediawiki-extensions-php70-jessie job, which is only part of the “gate-and-submit” and “php5” queues, so these errors typically don’t become visible until merge.

Any ideas what might cause this?

Details

SubjectRepoBranchLines +/-
Fully qualify NS_MAIN when used as function default argumentmediawiki/extensions/Wikibasemaster+3 -3
Fully qualify NS_MAIN when used as function default argumentmediawiki/extensions/Wikibasewmf/1.32.0-wmf.5+3 -3
Don’t use NS_MAIN as default function argumentmediawiki/extensions/Wikibasewmf/1.32.0-wmf.5+3 -3
Don’t use NS_MAIN as default function argumentmediawiki/extensions/Wikibasemaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 29 2018, 3:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2018, 3:32 PM
gerritbot subscribed.May 29 2018, 3:33 PM

Change 436035 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Don’t use NS_MAIN as default function argument

https://gerrit.wikimedia.org/r/436035

gerritbot added a project: Patch-For-Review.May 29 2018, 3:33 PM
daniel added subscribers: Smalyshev, daniel.May 29 2018, 3:53 PM

@Smalyshev do you have an idea what's going on here? asking you as the token php guy ;)

gerritbot added a comment.May 29 2018, 3:56 PM

Change 436045 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fully qualify NS_MAIN when used as function default argument

https://gerrit.wikimedia.org/r/436045

gerritbot added a comment.May 29 2018, 4:07 PM

Change 436035 abandoned by Lucas Werkmeister (WMDE):
Don’t use NS_MAIN as default function argument

Reason:
superseded by Ia01bdaa465

https://gerrit.wikimedia.org/r/436035

Lucas_Werkmeister_WMDE added a subscriber: • Aleksey_WMDE.May 29 2018, 4:11 PM

According to @Aleksey_WMDE on IRC, this seems to be a bug in PHP 7.0.30 (can’t reproduce in 7.0.22 or 7.1.17) where constants must be fully qualified when used in a function default argument.

WMDE-leszek added a comment.May 29 2018, 4:25 PM

Also failing for me with PHP 7.0.27.

Jdforrester-WMF triaged this task as Unbreak Now! priority.May 29 2018, 4:33 PM
Jdforrester-WMF merged a task: T195883: Wikibase tests breaking merge in other repos due to "Undefined constant 'Wikibase\Client\Store\NS_MAIN".
Jdforrester-WMF added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).
Jdforrester-WMF added subscribers: Jdforrester-WMF, Krinkle, TerraCodes.
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 29 2018, 4:33 PM
gerritbot added a comment.May 29 2018, 4:50 PM

Change 436045 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fully qualify NS_MAIN when used as function default argument

https://gerrit.wikimedia.org/r/436045

Lucas_Werkmeister_WMDE added a comment.May 29 2018, 4:53 PM

Fix is merged, should work now after a recheck. (Since php70 is only in gate-and-submit, IIUC no rebase should be necessary.)

Lucas_Werkmeister_WMDE added a comment.May 29 2018, 4:56 PM

By the way, we have not yet been able to reproduce this bug in a smaller code sample (my attempt) :/

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 29 2018, 5:01 PM
gerritbot added a comment.May 29 2018, 5:10 PM

Change 436067 had a related patch set uploaded (by Jforrester; owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.5] Don’t use NS_MAIN as default function argument

https://gerrit.wikimedia.org/r/436067

Smalyshev added a comment.May 29 2018, 5:12 PM

Interestingly enough, it works for me (pre-patch) just fine on local Vagrant with PHP 7.0.27-0+deb9u1. I'll try to upgrade to 7.0.30 and see what's the diff.

Smalyshev added a comment.May 29 2018, 5:18 PM

Debian Stretch doesn't seem to have 7.0.30 package. CI is running 7.0.30-1+0~20180505045929.18+jessie~1.gbpcfecb9. I wonder where that package is coming from... It is possible in theory that some bug crept in between .27 and .30, though I do not see any substantial patches that could have caused it. But having the actual binary would probably help.

Legoktm subscribed.May 29 2018, 5:19 PM

The packages come from https://packages.sury.org/php/

gerritbot added a comment.May 29 2018, 5:25 PM

Change 436069 had a related patch set uploaded (by Jforrester; owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.5] Fully qualify NS_MAIN when used as function default argument

https://gerrit.wikimedia.org/r/436069

gerritbot added a comment.May 29 2018, 5:26 PM

Change 436067 abandoned by Jforrester:
Don’t use NS_MAIN as default function argument

Reason:
Wrong one.

https://gerrit.wikimedia.org/r/436067

Smalyshev added a comment.May 29 2018, 5:34 PM

OK, I updated local Vagrant to 7.0.30-1+0~20180505045735.18+stretch~1.gbpcfecb9 and it still works just fine. Now it's officially weird.

Legoktm added a comment.May 29 2018, 6:18 PM

The only major difference I can think of then is that the nodepool images are using Debian Jessie, not Stretch.

thcipriani added a parent task: T195514: Can't copy and paste a list on office.wiki page in the visual editor.May 29 2018, 7:13 PM
thcipriani added a subtask: T195906: Phan fails for Wikibase on wmf.x branches.
thcipriani subscribed.

Fix currently cannot be backported to wmf.5 due to T195906: Phan fails for Wikibase on wmf.x branches

Stashbot mentioned this in T195514: Can't copy and paste a list on office.wiki page in the visual editor.May 29 2018, 7:16 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-05-29T19:16:40Z] <thcipriani> cutting branch for wmf.6, will not deploy wmf.6 as wmf.5 is not currently on group2 as the train is blocked on T195514 which is blocked on T195868 which is blocked on T195906

Stashbot mentioned this in T195906: Phan fails for Wikibase on wmf.x branches.May 29 2018, 7:16 PM
Krinkle added a project: Wikidata.May 29 2018, 7:43 PM
Krinkle moved this task from Untriaged to In progress on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.
gerritbot added a comment.May 29 2018, 8:12 PM

Change 436069 merged by Thcipriani:
[mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.5] Fully qualify NS_MAIN when used as function default argument

https://gerrit.wikimedia.org/r/436069

thcipriani removed a subtask: T195906: Phan fails for Wikibase on wmf.x branches.May 29 2018, 8:15 PM
Jdforrester-WMF lowered the priority of this task from Unbreak Now! to High.May 29 2018, 8:51 PM

No longer blocking merges, AFAICT.

thcipriani removed a parent task: T195514: Can't copy and paste a list on office.wiki page in the visual editor.May 29 2018, 9:08 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)); removed MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 30 2018, 5:02 PM
Krinkle moved this task from In progress to Resolved on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.May 30 2018, 9:05 PM
Krinkle unsubscribed.
Ladsgroup closed this task as Resolved.Jun 2 2018, 6:08 PM
Ladsgroup assigned this task to Lucas_Werkmeister_WMDE.

This is done and it's not happening anymore.

Liuxinyu970226 unsubscribed.Jun 3 2018, 6:24 AM
• Vvjjkkii renamed this task from CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN' to j2baaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Lucas_Werkmeister_WMDE as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
JJMC89 merged a task: T195883: Wikibase tests breaking merge in other repos due to "Undefined constant 'Wikibase\Client\Store\NS_MAIN".Jul 1 2018, 2:10 AM
JJMC89 added subscribers: Aklapper, Krinkle.
thcipriani renamed this task from j2baaaaaaa to CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'.Jul 1 2018, 7:34 PM
thcipriani closed this task as Resolved.
thcipriani assigned this task to Lucas_Werkmeister_WMDE.
thcipriani updated the task description. (Show Details)
thcipriani removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, CheckUser.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits