Page MenuHomePhabricator
Create Task
Maniphest T197450

test.wp is using test2.wp's message cache
Closed, ResolvedPublic
Actions

Description

Not sure where this problem comes from, could be config or software, but I just noticed that on test.wikipedia.org, I see the gadgets from test2.wikipedia.org

Definition for test.wp: https://test.wikipedia.org/wiki/MediaWiki:Gadgets-definition

Does not match with the gadgets actually shown on test.wp
https://test.wikipedia.org/wiki/Special:Gadgets
https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-gadgets

which instead reflects what seems to be https://test2.wikipedia.org/wiki/MediaWiki:Gadgets-definition

This seems concerning that one wiki shows content from another wiki all of a sudden. Check with MediaWiki-extensions-GlobalPreferences team and they don't think it's something that they are triggering. Not sure where else to look.

Details

SubjectRepoBranchLines +/-
Make sure that mcrouter BagOStuff goes through ObjectCache::newFromParams()operations/mediawiki-configmaster+13 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheDJ created this task.Jun 15 2018, 9:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2018, 9:26 AM
TheDJ mentioned this in T189806: Deploy GlobalPrefs on production.Jun 15 2018, 9:26 AM
IKhitron subscribed.Jun 15 2018, 9:29 AM
Nirmos subscribed.Jun 15 2018, 9:32 AM
Legoktm subscribed.Jun 15 2018, 11:29 AM

I'm randomly guessing that this could be related to the MCR stuff? https://lists.wikimedia.org/pipermail/wikitech-l/2018-June/090206.html

For this to happen somehow the test2 message contents would need to get into the test.wp message cache.

Addshore subscribed.Jun 15 2018, 11:29 AM
Legoktm renamed this task from test.wp shows the gadgets from test2.wp to test.wp is using test2.wp's message cache.Jun 15 2018, 11:37 AM
Legoktm edited projects, added MediaWiki-libs-BagOStuff; removed MediaWiki-extensions-Gadgets.

I did a bit of debugging with eval.php, and this appears to affect all overridden system messages on test.wp - they're using the test2.wp version.

Tgr subscribed.Jun 15 2018, 12:08 PM
Krinkle added projects: MediaWiki-extensions-Gadgets, Performance-Team.Jun 15 2018, 12:30 PM
Krinkle added a subscriber: aaron.
Legoktm claimed this task.Jun 15 2018, 12:42 PM

Scratch that. It seems more likely that this was caused by the mcrouter deployment...

gerritbot subscribed.Jun 15 2018, 12:45 PM

Change 440526 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[operations/mediawiki-config@master] Make sure that mcrouter BagOStuff goes through ObjectCache::newFromParams()

https://gerrit.wikimedia.org/r/440526

gerritbot added a project: Patch-For-Review.Jun 15 2018, 12:45 PM
gerritbot added a comment.Jun 15 2018, 12:52 PM

Change 440526 merged by jenkins-bot:
[operations/mediawiki-config@master] Make sure that mcrouter BagOStuff goes through ObjectCache::newFromParams()

https://gerrit.wikimedia.org/r/440526

Stashbot subscribed.Jun 15 2018, 12:56 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-15T12:56:23Z] <legoktm@deploy1001> Synchronized wmf-config/mc.php: Make sure that mcrouter BagOStuff goes through ObjectCache::newFromParams() - T197450 (duration: 00m 57s)

Legoktm closed this task as Resolved.Jun 15 2018, 1:09 PM

OK, so this is fixed, but some of the core messages are missing - if someone wants to do a full scap (I don't have time), it should restore the missing messages.

Jdforrester-WMF subscribed.Jun 21 2018, 12:29 AM
In T197450#4291900, @Legoktm wrote:

OK, so this is fixed, but some of the core messages are missing - if someone wants to do a full scap (I don't have time), it should restore the missing messages.

Hmm, l10nupdate has now run a few times and it's still missing messages…

Legoktm added a comment.Jun 22 2018, 10:36 AM

Has someone tried running a full scap? I'm not sure if l10nupdate is enough (but I don't understand exactly what the difference is)

Jdforrester-WMF added a comment.Jun 22 2018, 2:53 PM
In T197450#4307317, @Legoktm wrote:

Has someone tried running a full scap? I'm not sure if l10nupdate is enough (but I don't understand exactly what the difference is)

No, we're in a no-deploy week. I'll run one on Monday if it's still broken.

Jdforrester-WMF reopened this task as Open.Jun 27 2018, 1:37 AM

Still broken after today's train run and SWAT deploys. :-(

Niharika mentioned this in T198494: New Pages Feed: Disable page curation toolbar in draft namespace (1.6).Jun 29 2018, 5:44 PM
Niharika subscribed.Jun 29 2018, 5:55 PM
Reedy triaged this task as High priority.Jun 29 2018, 5:59 PM
Reedy removed a project: Patch-For-Review.
• Vvjjkkii renamed this task from test.wp is using test2.wp's message cache to luaaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii removed Legoktm as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from luaaaaaaaa to test.wp is using test2.wp's message cache.Jul 2 2018, 5:04 AM
CommunityTechBot assigned this task to Legoktm.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Krinkle added a parent task: T198239: Rollout use of mcrouter for MediaWiki in production.Jul 2 2018, 8:27 PM
• Imarlier moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Jul 2 2018, 8:29 PM
Framawiki subscribed.Jul 2 2018, 8:34 PM
aaron added a comment.EditedJul 2 2018, 8:46 PM

Testing around, I see that https://test2.wikipedia.org/wiki/MediaWiki_talk:Msg-override doesn't use the {{msg-override}} message from test.wkipedia.org. Is this task still named appropriately?

If core messages are missing, then I don't see how it can be MessageCache or something mcrouter related. In that case, I'll just keep this on my radar.

aaron mentioned this in T198239: Rollout use of mcrouter for MediaWiki in production.Jul 3 2018, 3:13 PM
Legoktm added a comment.Jul 3 2018, 4:30 PM

Something is still wrong, unclear if it's related to mcrouter or not. e.g. on https://test.wikipedia.org/wiki/Special:Gadgets a bunch of messages are missing, even though they're defined in the MW namespace.

Krinkle subscribed.Jul 3 2018, 6:37 PM

@Legoktm Can you provide an example of a missing message? I just looked at two examples and they seemed fine.

  1. ⧼right-hidden⧽ - expected as this message doesn't exist at https://test.wikipedia.org/wiki/MediaWiki:Right-hidden (It's an old hack)
  2. "Gadget-MobileCategories" - expected as https://test.wikipedia.org/wiki/MediaWiki:Gadget-MobileCategories doesn't exist. I created it as example just now, and its label ("Categories on mobile") shows up on https://test.wikipedia.org/wiki/Special:Gadgets.
Legoktm closed this task as Resolved.Jul 27 2018, 12:11 AM
In T197450#4395486, @Krinkle wrote:

@Legoktm Can you provide an example of a missing message? I just looked at two examples and they seemed fine.

  1. ⧼right-hidden⧽ - expected as this message doesn't exist at https://test.wikipedia.org/wiki/MediaWiki:Right-hidden (It's an old hack)
  2. "Gadget-MobileCategories" - expected as https://test.wikipedia.org/wiki/MediaWiki:Gadget-MobileCategories doesn't exist. I created it as example just now, and its label ("Categories on mobile") shows up on https://test.wikipedia.org/wiki/Special:Gadgets.

Yeah, I didn't look closely enough. LGTM now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL