Page MenuHomePhabricator

Help panel: Dropdown menu on settings cog
Closed, ResolvedPublic

Description

In T206716, we discussed how users can turn the help panel off and on. Here is what we have decided to build:

  • A "cog" in the help panel.
  • The cog opens a short menu with a few links, where the top one is a link to Preferences, anchored as closely as possible to the preference for turning the feature on/off.
  • The cog also contains a link called "More about the help panel", which will link to the page created in T210906.
  • All links should open in a new tab.

Here is a current mockup:

@RHo may need to add more concrete mockups of the feature on desktop and mobile, or incorporate the feature into the interactive prototype.

Event Timeline

Liuxinyu970226 added a subscriber: Liuxinyu970226.

Oh please, no more addition of projects in subscribers field.

Oh please, no more addition of projects in subscribers field.

Thank you for fixing it.

kostajh renamed this task from Help panel: ability to turn off the feature to Help panel: Dropdown menu on settings cog.Dec 13 2018, 6:56 PM

Change 479854 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Make settings cog open popup panel

https://gerrit.wikimedia.org/r/479854

@SBisson "Hack" appears three times in the patch for this one. Let me know if you have ideas for how to better implement the popup, and to get its positioning correct.

I still need to add the background color styling and remove the outline from the settings cog when it's pressed.

Change 479854 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Make settings cog open popup panel

https://gerrit.wikimedia.org/r/479854

@SBisson "Hack" appears three times in the patch for this one. Let me know if you have ideas for how to better implement the popup, and to get its positioning correct.

I saw it when reviewing but hacking is business as usual with ooui so I didn't think much of it. Roan may know off-hand what's the trick here if you really mind.

I still need to add the background color styling and remove the outline from the settings cog when it's pressed.

The border around a selected element is an accessibility feature and shouldn't be disabled.

@Etonkovidova I'll add an addition to T211633: Help panel: design tweaks for some of the styling that still needs to be done, but the functionality of this can be reviewed now.

Change 480142 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Help panel: Remove handling for 'settings' action

https://gerrit.wikimedia.org/r/480142

Change 480142 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: Remove handling for 'settings' action

https://gerrit.wikimedia.org/r/480142

Etonkovidova closed this task as Resolved.Dec 20 2018, 6:08 PM

Checked in testwiki (wmf.9)

Etonkovidova added a comment.EditedDec 20 2018, 6:13 PM

@MMiller_WMF
(1) Will be there additional customized links on Czech and Korean wikis? If such links would be added, they need to be checked for UI and functionality. Probably there should a specific post-deployment QA task for Czech and Korean wikis.

(2) There is no Help panel on Structured Discussion topics/comments - is it ok?

@Etonkovidova -- good idea. I created a post-deployment QA task here: T212481

And yes, it is okay for the help panel to be missing on Structured Discussion pages. That's a good thing for us to remember for the future, and I added that issue on this task: T212433