Page MenuHomePhabricator
Create Task
Maniphest T211400

Help panel: Dropdown menu on settings cog
Closed, ResolvedPublic
Actions

Assigned To
kostajh
Authored By
MMiller_WMF
Dec 7 2018, 1:09 AM
Tags
Referenced Files
F27688618: Screen Shot 2018-12-20 at 10.06.19 AM.png
Dec 20 2018, 6:08 PM
F27561199: image.png
Dec 14 2018, 10:15 PM
F27402308: image.png
Dec 7 2018, 1:09 AM
Subscribers
Aklapper
Bencemac
• Catrope
Etonkovidova
gerritbot
JTannerWMF
kaldari
View All 14 Subscribers

Description

In T206716, we discussed how users can turn the help panel off and on. Here is what we have decided to build:

  • A "cog" in the help panel.
  • The cog opens a short menu with a few links, where the top one is a link to Preferences, anchored as closely as possible to the preference for turning the feature on/off.
  • The cog also contains a link called "More about the help panel", which will link to the page created in T210906.
  • All links should open in a new tab.

Here is a current mockup:

image.png (432×754 px, 47 KB)

@RHo may need to add more concrete mockups of the feature on desktop and mobile, or incorporate the feature into the interactive prototype.

Details

SubjectRepoBranchLines +/-
Help panel: Remove handling for 'settings' actionmediawiki/extensions/GrowthExperimentsmaster+0 -3
Help Panel: Make settings cog open popup panelmediawiki/extensions/GrowthExperimentsmaster+38 -11
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedMMiller_WMFT206711 [EPIC] Growth: help panel
 ResolvedkostajhT211400 Help panel: Dropdown menu on settings cog

Event Timeline

MMiller_WMF created this task.Dec 7 2018, 1:09 AM
MMiller_WMF updated the task description. (Show Details)
MMiller_WMF mentioned this in T206716: Help panel: business rules on displaying the feature.
MMiller_WMF updated the task description. (Show Details)
Liuxinyu970226 removed a subscriber: Growth-Team.Dec 7 2018, 7:00 AM
Liuxinyu970226 subscribed.

Oh please, no more addition of projects in subscribers field.

Trizek-WMF added a comment.Dec 7 2018, 2:51 PM
In T211400#4805216, @Liuxinyu970226 wrote:

Oh please, no more addition of projects in subscribers field.

Thank you for fixing it.

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments; removed Growth-Team.Dec 7 2018, 9:51 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh mentioned this in T209982: Help panel: Develop Schema .Dec 7 2018, 11:25 PM
kostajh renamed this task from Help panel: ability to turn off the feature to Help panel: Dropdown menu on settings cog.Dec 13 2018, 6:56 PM
kostajh claimed this task.Dec 14 2018, 5:38 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot subscribed.Dec 14 2018, 10:08 PM

Change 479854 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Make settings cog open popup panel

https://gerrit.wikimedia.org/r/479854

gerritbot added a project: Patch-For-Review.Dec 14 2018, 10:08 PM
kostajh mentioned this in rEGREff7cac7b56f5: Help Panel: Make settings cog open popup panel.Dec 14 2018, 10:11 PM
kostajh mentioned this in rEGRE54ccd4770b71: Help Panel: Make settings cog open popup panel.
kostajh added a comment.Dec 14 2018, 10:15 PM

image.png (264×940 px, 36 KB)

@SBisson "Hack" appears three times in the patch for this one. Let me know if you have ideas for how to better implement the popup, and to get its positioning correct.

I still need to add the background color styling and remove the outline from the settings cog when it's pressed.

gerritbot added a comment.Dec 15 2018, 5:12 PM

Change 479854 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Make settings cog open popup panel

https://gerrit.wikimedia.org/r/479854

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 15 2018, 6:00 PM
SBisson added a comment.Dec 15 2018, 7:39 PM
In T211400#4824999, @kostajh wrote:

image.png (264×940 px, 36 KB)

@SBisson "Hack" appears three times in the patch for this one. Let me know if you have ideas for how to better implement the popup, and to get its positioning correct.

I saw it when reviewing but hacking is business as usual with ooui so I didn't think much of it. Roan may know off-hand what's the trick here if you really mind.

I still need to add the background color styling and remove the outline from the settings cog when it's pressed.

The border around a selected element is an accessibility feature and shouldn't be disabled.

kostajh moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 15 2018, 8:49 PM

@Etonkovidova I'll add an addition to T211633: Help panel: design tweaks for some of the styling that still needs to be done, but the functionality of this can be reviewed now.

gerritbot added a comment.Dec 17 2018, 6:40 PM

Change 480142 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Help panel: Remove handling for 'settings' action

https://gerrit.wikimedia.org/r/480142

SBisson mentioned this in rEGRE5dbead262703: Help panel: Remove handling for 'settings' action.Dec 17 2018, 6:41 PM
gerritbot added a comment.Dec 17 2018, 6:55 PM

Change 480142 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: Remove handling for 'settings' action

https://gerrit.wikimedia.org/r/480142

Etonkovidova closed this task as Resolved.Dec 20 2018, 6:08 PM

Checked in testwiki (wmf.9)

Screen Shot 2018-12-20 at 10.06.19 AM.png (448×333 px, 46 KB)

Etonkovidova moved this task from QA to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 20 2018, 6:08 PM
Etonkovidova added a comment.EditedDec 20 2018, 6:13 PM

@MMiller_WMF
(1) Will be there additional customized links on Czech and Korean wikis? If such links would be added, they need to be checked for UI and functionality. Probably there should a specific post-deployment QA task for Czech and Korean wikis.

(2) There is no Help panel on Structured Discussion topics/comments - is it ok?

MMiller_WMF added a comment.Dec 21 2018, 2:12 AM

@Etonkovidova -- good idea. I created a post-deployment QA task here: T212481

And yes, it is okay for the help panel to be missing on Structured Discussion pages. That's a good thing for us to remember for the future, and I added that issue on this task: T212433

Liuxinyu970226 unsubscribed.Dec 31 2018, 12:44 AM
Urbanecm edited subscribers, added: Urbanecm_WMF; removed: Urbanecm.Aug 26 2020, 2:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits