Page MenuHomePhabricator
Create Task
Maniphest T214603

"thumbtime", "page" is lost when roundtripping in gallery
Closed, ResolvedPublic
Actions

Description

The example from "nlwiki/ICE 3" is

<gallery>
Bestand:ICE3_Schllenberg.ogg|thumbtime=14|ICE 3 door een tunnel
</gallery>

Part of that is fixed by,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/463125/19/lib/ext/Gallery/modes.js

But more work is needed, as mentioned in,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/463125/19/lib/ext/Gallery/index.js

Somewhat related to T211895 / T151367

Details

SubjectRepoBranchLines +/-
Set alt in data-mw for non-img mediamediawiki/extensions/VisualEditormaster+49 -13
Bump wikimedia/parsoid to 0.19.0-a4mediawiki/vendormaster+196 -253
Reuse LinkHandlerUtils::figureHandler in gallerymediawiki/services/parsoidmaster+85 -184
Customize query in gerrit

Related Objects
Search...

Event Timeline

Arlolra created this task.Jan 24 2019, 4:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2019, 4:57 PM
• ssastry triaged this task as Medium priority.Jun 10 2019, 8:41 PM
• ssastry edited projects, added Parsoid-Edit-Support; removed Parsoid.
matmarex renamed this task from "thumbtime" is lost when roundtripping in gallery to "thumbtime", "page" is lost when roundtripping in gallery.Dec 30 2019, 10:09 PM
matmarex merged a task: T239646: VE/Parsoid normalising media links (page=… disappears) inside a <gallery>?.
matmarex added a project: VisualEditor.
matmarex moved this task from To Triage to FY 19-20 on the VisualEditor board.
matmarex added subscribers: Jdforrester-WMF, JTannerWMF, matmarex.
Aklapper edited projects, added Parsoid; removed Parsoid-Edit-Support.Feb 29 2020, 5:15 PM
Arlolra moved this task from Needs Triage to Backlog on the Parsoid board.Mar 2 2020, 4:26 PM
LGoto assigned this task to Arlolra.May 8 2020, 4:29 PM
LGoto moved this task from Backlog to Needs Investigation on the Parsoid board.
Arlolra removed Arlolra as the assignee of this task.May 8 2020, 8:23 PM
Arlolra moved this task from Needs Investigation to Bugs & Crashers on the Parsoid board.
Arlolra added a parent task: T252246: Borrow functionality from the LinkHandlerUtils::figureHandler for serializing media in gallery.May 8 2020, 8:36 PM
Conny subscribed.May 19 2021, 3:13 PM
Arlolra mentioned this in T333907: Address semantic differences from enabling nativeGalleryEnabled.Apr 17 2023, 11:48 PM
Arlolra added a parent task: T333907: Address semantic differences from enabling nativeGalleryEnabled.Oct 12 2023, 10:29 PM
DLynch mentioned this in T348703: Visual Editor removes alt text from video in gallery.Oct 16 2023, 7:30 PM
Arlolra claimed this task.Oct 20 2023, 9:49 PM
Arlolra added projects: Content-Transform-Team-WIP, Essential-Work.
Arlolra moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.
gerritbot added a comment.Oct 20 2023, 9:53 PM

Change 967323 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Reuse LinkHandlerUtils::figureHandler in gallery

https://gerrit.wikimedia.org/r/967323

gerritbot added a project: Patch-For-Review.Oct 20 2023, 9:53 PM
gerritbot added a comment.Oct 23 2023, 9:59 PM

Change 967323 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Reuse LinkHandlerUtils::figureHandler in gallery

https://gerrit.wikimedia.org/r/967323

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2023, 10:11 PM
Arlolra moved this task from In Progress to To Deploy on the Content-Transform-Team-WIP board.Oct 24 2023, 9:15 PM
gerritbot added a comment.Oct 25 2023, 3:18 PM

Change 968376 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/VisualEditor@master] [WIP] Set alt in data-mw for non-img media

https://gerrit.wikimedia.org/r/968376

gerritbot added a project: Patch-For-Review.Oct 25 2023, 3:18 PM
gerritbot added a comment.Oct 30 2023, 9:57 AM

Change 969688 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a4

https://gerrit.wikimedia.org/r/969688

gerritbot added a comment.Oct 30 2023, 3:58 PM

Change 969688 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a4

https://gerrit.wikimedia.org/r/969688

gerritbot added a comment.Nov 2 2023, 9:39 PM

Change 968376 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Set alt in data-mw for non-img media

https://gerrit.wikimedia.org/r/968376

matmarex added a project: Editing-team (Kanban Board).Nov 2 2023, 9:54 PM
matmarex removed a project: Patch-For-Review.
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Nov 2 2023, 10:00 PM
MSantos moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Nov 13 2023, 4:21 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 27 2023, 11:43 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
VPuffetMichel closed this task as Resolved.Dec 4 2023, 6:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL