MVP for User Talk pages: As an app editor I need to be able to see my User Talk page to get feedback on my edits and communicate with other editors
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• JMinor
	Feb 12 2019, 5:15 PM

Description

Why are we doing this?

As we encourage more users to edit and create accounts to edit from within the iOS app, we need a way for users to be able to view their User Talk pages in order to receive feedback from and communicate with other editors

User story

As an app editor I need to be able to see my User Talk page to get feedback on my edits and communicate with other editors

Design doc and audit of existing

https://docs.google.com/presentation/d/1E5xrCbX5eTfXY2K0i_uHU5cS8s42aci15sGkEok_wMA/edit?usp=sharing

Suggested features

Build off of the ‘Default’ talk pages on mobile web instead of building something completely new
Tabbed views for easy navigation between article and talk views
No auto signing so that users can choose when and how to sign their posts
Support ability to access Wiki view either through a web link or a separate view

User Flows

Viewing your own Talk page

Viewing your own talk page.pdf35 KBDownload

Viewing another user's Talk page

Viewing another user's talk page.pdf36 KBDownload

Designs

InVision prototype

https://wikimedia.invisionapp.com/share/F3RHFZT7U48

Navigating to User Talk from Settings

Settings	Settings > Account	Settings > Account > User talk

https://zpl.io/beAw4dm	https://zpl.io/bA7mv98	https://zpl.io/2EgdWPn

Discussions and replies

Discussion	Discussion scrolled	Reply	Reply - complete	Reply published

https://zpl.io/V4eEzQN	https://zpl.io/2yq1WOJ	https://zpl.io/a310Rel	https://zpl.io/aRxmG1z	https://zpl.io/VQvMQBn

Creating a new discussion on another user's Talk page

Viewing another user's talk page	New discussion	New discussion keyboard up	New discussion - Complete	New discussion published	Viewing new discussion

https://zpl.io/adzRNpe	https://zpl.io/Vx0nwLE	https://zpl.io/aNmEzPN	https://zpl.io/bPxrgPy	https://zpl.io/aBRwWBe	https://zpl.io/bWNQdNK

Searching for a Talk page

Search for talk page	Talk page from search

https://zpl.io/2yq1WqJ	https://zpl.io/awJyOJJ

User Talk toolbar

Save	Share	Appearance settings

https://zpl.io/2yq0gWG	https://zpl.io/beAj9kp	https://zpl.io/Vkpo4eq

Questions

Could we support a way to reply directly to a specific comment?
Could we support a way to show when there is new activity on a discussion?

Related Objects
Search...

Status	Assigned	Task
Resolved	• JMinor	T215928 MVP for User Talk pages: As an app editor I need to be able to see my User Talk page to get feedback on my edits and communicate with other editors
Declined	cmadeo	T220546 As an app editor I would like to be able to access User pages
Resolved	• NHarateh_WMF	T220549 As an app editor I would like to be able to set specific signature preferences from within the app
Declined	None	T221130 I want to be able to reply at a specific indent level on a talk page
Resolved	• JMinor	T221148 Talkpage endpoint
Resolved	MSantos	T225733 Expose new talk endpoint via RESTBase
Declined	• Pchelolo	T226669 Add change prop rule for new talk endpoint
Resolved	• Mholloway	T227481 Talk endpoint returns wrong etag
Declined	Tsevener	T222279 [Talk Pages Dev] Talk Page Offline Support
Resolved	Tsevener	T222719 [Talk Pages Dev] Post new discussion/reply
Declined	None	T222721 [Talk Pages Dev] Save html in file rather than core data
Resolved	Tsevener	T222722 [Talk Pages Dev] Diffing using SHA
Declined	• JMinor	T222723 Talk Pages - Add to watchlist / reading list
Declined	• JMinor	T223160 Community input on watchlists
Declined	None	T222724 [Talk Pages Dev] Add reading themes preferences in discussion list toolbar
Resolved	• NHarateh_WMF	T222725 Talk Pages: Handle error / loading / empty states
Resolved	Tsevener	T222726 [Talk Pages Dev] Unread indicator
Resolved	Tsevener	T222727 [Talk Pages Dev] Multi-language support
Declined	None	T225551 [Talk Pages Dev] Build script to populate user talk canonicalName in languages.json
Resolved	Tsevener	T222728 [Talk Pages Dev] Handle additional paths when tapping links in talk pages
Resolved	Tsevener	T222729 [Talk Pages Dev] Finish cell UI
Resolved	• NHarateh_WMF	T222760 [Talk Pages Dev] Support list items in html-to-attributed string code
Resolved	Tsevener	T222730 Make Talk Pages Accessible
Resolved	Tsevener	T224054 Talk page MVP priority fixes fo user testing
Resolved	• NHarateh_WMF	T224632 [Talk Pages Dev] add Share functionality

Event Timeline

• JMinor created this task.Feb 12 2019, 5:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2019, 5:15 PM

• JMinor added a project: Wikipedia-iOS-App-Backlog.Feb 12 2019, 5:15 PM

• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Feb 12 2019, 6:09 PM

• JMinor added a project: iOS-app-v6.3-Lobster-On-A-Motorcycle.Feb 20 2019, 11:41 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Design on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Feb 26 2019, 5:22 PM

• JMinor triaged this task as Medium priority.Feb 26 2019, 5:29 PM

cmadeo renamed this task from As an app editor I need to be able to see my user talk page to get feedback on my edits and communicate with other editors to MVP for User Talk pages: As an app editor I need to be able to see my User Talk page to get feedback on my edits and communicate with other editors.Mar 11 2019, 3:16 PM

cmadeo claimed this task.

cmadeo updated the task description. (Show Details)

cmadeo moved this task from Needs Design to Design Doing on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.

cmadeo subscribed.

cmadeo updated the task description. (Show Details)Mar 13 2019, 5:37 PM

cmadeo updated the task description. (Show Details)Mar 25 2019, 3:43 PM

cmadeo updated the task description. (Show Details)

MediaWiki has flow on for user:talk, does that mean we need to support flow? Ideally not, but then what do we on these pages?

@JMinor could we still show a web view for these?

cmadeo updated the task description. (Show Details)Apr 10 2019, 8:39 PM

Moved into blocked or waiting as I will be reviewing these v1 designs tomorrow at design review

cmadeo updated the task description. (Show Details)Apr 11 2019, 3:47 PM

cmadeo moved this task from Blocked or Waiting to Needs Acceptance Criteria on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Apr 11 2019, 8:06 PM

• JMinor moved this task from Needs Acceptance Criteria to Needs Engineering Sync on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Apr 15 2019, 7:44 PM

LGoto removed cmadeo as the assignee of this task.Apr 16 2019, 6:39 PM

LGoto moved this task from Needs Engineering Sync to Ready for Development on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Apr 16 2019, 6:43 PM

Mhurd added a subtask: T221148: Talkpage endpoint.Apr 16 2019, 9:24 PM

Tsevener claimed this task.Apr 17 2019, 4:15 PM

Tsevener moved this task from Ready for Development to Doing on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.

cmadeo updated the task description. (Show Details)Apr 30 2019, 8:07 PM

Per our sync meeting, when the user taps on 'View in Safari' we'll probably want to show them the 'View as Wikipage' view rather than the 'mobile web default user talk' view. Additionally as @Tsevener pointed out, we'll want to refresh the page after they return back to Talk in the app, just in case they made a change while in Safari

Tsevener moved this task from Doing to Blocked or Waiting on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.May 9 2019, 8:14 PM

Hi @Tsevener! Thanks for all of the amazing work so far on User Talk, this is so exciting!
So far here are a few tweaks and updates I've collected for this ongoing work:

Location	Zeplin Screen	Details	Suggested update
Settings > Account	https://zpl.io/bA7mv98	Partial HR missing from between elements, realizing that this is missing from all of our Settings list items 🙀 so I can also just file a new ticket for this if necessary	Update cell items that have icons (eg. settings cell items) to have a partial HR
Settings > Account	https://zpl.io/bA7mv98	When you tap on a cell item and then go back (eg. abort logging out) the cell item appears to be in a selected state	Do not maintain state for cell items
User Talk	https://zpl.io/awJyOJJ	New discussion icon `+` is greyed out even when action can be taken	Set icon to active (blue) when action can be taken
User Talk	https://zpl.io/awJyOJJ	HR appearing under nav bar	remove HR (similar to the header in Reading lists)
User Talk	https://zpl.io/awJyOJJ	Header spacing	We can reuse the header spacing from Reading list view, although we might want to make some very small height tweaks to both later to add some breathing room
Discussion	https://zpl.io/V4eEzQN	HR appearing under nav bar	remove HR (similar to the header in Reading lists)
Discussion	https://zpl.io/V4eEzQN	Discussion title	After update of the title on the User Talk page, the Discussion titles should also be updated
Discussion Reply	https://zpl.io/a310Rel	Publish button looks inactive after entering text	Update publish button to blue when active
Discussion Reply	https://zpl.io/a310Rel	Divs appear to be expanding vs. scrolling to reveal	Would it be possible to have everything except for the keyboard and the 'be kind' reminder sit on the same level similar to the 'Save changes' page in the editing flow? This way users can scroll through vs. having areas expand as they move up and down? This might not be the best solution, but just curious to see how this would feel instead if this isn't crazy to implement. This is def. not a priority or a blocker!
New reply published	https://zpl.io/VQvMQBn	The new reply takes a long time to load and the confirmation appears before the new reply	Hoping that the loading states will help with this, but we'll still want to hold off on showing the confirmation before we show the new reply
New reply published	https://zpl.io/VQvMQBn	Confirmation appears to be floating above the bottom of the screen	Ensure that the confirmation appears flush to the bottom of the screen
New Discussion	https://zpl.io/aBRwWBe	New discussions don't appear to post to new user talk pages	Can we both post and 'create' the talk page? If not we'll need to rethink the empty state and set the 'new discussion' button to inactive.

@cmadeo

Partial HR missing from between elements, realizing that this is missing from all of our Settings list items 🙀 so I can also just file a new ticket for this if necessary

Got it, yeah I think a separate ticket would be better for this, then hopefully that fix will cleanly propagate to the Account screen. Thanks!

After update of the title on the User Talk page, the Discussion titles should also be updated

Just curious were you updating this via the web? Yeah once we have the share option in I'll add a refresh when they return, hopefully that'll get that part sorted out.

Would it be possible to have everything except for the keyboard and the 'be kind' reminder sit on the same level similar to the 'Save changes' page in the editing flow?

Yeah, agreed, I would like to fix the way it's working now, I had trouble with it because the text view is so large. Oftentimes it would scroll out of view when accounting for the keyboard offset so what I have now is it attempting to resize to the visible area (but it causes a lot of UI quirks seems like). The "Save changes" example will be helpful for reference, thanks!

Can we both post and 'create' the talk page?

Good question, I'll look into this.

In T215928#5201603, @Tsevener wrote:

@cmadeo

Partial HR missing from between elements, realizing that this is missing from all of our Settings list items 🙀 so I can also just file a new ticket for this if necessary

Got it, yeah I think a separate ticket would be better for this, then hopefully that fix will cleanly propagate to the Account screen. Thanks!

Can do!

After update of the title on the User Talk page, the Discussion titles should also be updated

Just curious were you updating this via the web? Yeah once we have the share option in I'll add a refresh when they return, hopefully that'll get that part sorted out.

Ah, sorry this was just a note that this should be consistent and both will need to be larger. They're consistent right now. My apologies for the confusion.

Would it be possible to have everything except for the keyboard and the 'be kind' reminder sit on the same level similar to the 'Save changes' page in the editing flow?

Yeah, agreed, I would like to fix the way it's working now, I had trouble with it because the text view is so large. Oftentimes it would scroll out of view when accounting for the keyboard offset so what I have now is it attempting to resize to the visible area (but it causes a lot of UI quirks seems like). The "Save changes" example will be helpful for reference, thanks!

Cool, also this is really just a curiosity / nice to have but not necessary.

Can we both post and 'create' the talk page?

Good question, I'll look into this.

Hey @Tsevener and @cmadeo per our meeting I am splitting out the priority items from this list as a separate subtask for easier priority/tracking.

Additional note - we also need the discussion title to become the title in the navigation bar as you scroll down on the reply list screen and same for the username on the discussion list screen.

Tsevener closed subtask T222719: [Talk Pages Dev] Post new discussion/reply as Resolved.May 29 2019, 5:37 PM

Tsevener closed subtask T222726: [Talk Pages Dev] Unread indicator as Resolved.May 29 2019, 9:43 PM

Tsevener closed subtask T222729: [Talk Pages Dev] Finish cell UI as Resolved.May 31 2019, 5:13 PM

talk page alignment screenshots.zip1 MBDownload

@JMinor here's some screenshots of RTL handling on talk pages, let me know if this looks right to you. Currently if it is an RTL talk page language I am aligning text to the right but keeping navigation elements (i.e. topic cell arrow positioning, unread indicator positioning) based on device settings. Topic and reply compose elements are only based on device settings.

Tsevener closed subtask T222727: [Talk Pages Dev] Multi-language support as Resolved.Jun 11 2019, 6:29 PM

Tsevener closed subtask T224632: [Talk Pages Dev] add Share functionality as Resolved.Jun 13 2019, 8:34 PM

Tsevener closed subtask T222728: [Talk Pages Dev] Handle additional paths when tapping links in talk pages as Resolved.

Tsevener moved this task from Blocked or Waiting to Waiting for Build on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.

• JMinor moved this task from Waiting for Build to Needs QA on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Jun 13 2019, 8:50 PM

• JMinor moved this task from Needs QA to Needs Design Review on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.

Thanks @Tsevener for all of the amazing work on this! I'm so excited for this feature!
I know things are still in progress, but I had some design tweaks and feedback. Let me know if you want any of these broken out into its own ticket.

I'm also still noticing that replies are being attached to the message above the intended message when auto signing is turned off and for messages for an account after auto signing has been toggled off and then on again.

Screenshot	Tweak or bug	Additional information
	Background color not full bleed on 'Please be kind' toast on iPhone X	Would it be possible to extend the background color of the 'Please be kind' message to the bottom of the screen on iPhone X when the keyboard is down?
	Back disappears from back button on header after scrolling on longer messages	It looks like once the 'Back' text is replaced with the message title text, the 'back' text disappears when the title text is dismissed
	Navigating to a user talk page from history opens in the article mode
	Unable to scroll on messages with very long titles	On messages that have titles that are longer than the screen height it is not possible to scroll down to see the rest of the title or the message itself
	Scroll issue on iPhone X when a user has 11 messages	When a user has 11 messages on their talk page, it is not possible to fully scroll down to the bottom of the list on an iPhone X, works fine when they have 12+ or fewer than 10

cmadeo moved this task from Needs Design Review to Ready for Development on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Jun 18 2019, 9:38 PM

Tsevener moved this task from Ready for Development to Doing on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Jun 24 2019, 2:19 PM

Tsevener moved this task from Doing to Needs Code Review on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Jun 26 2019, 3:44 PM

Back disappears from back button on header after scrolling on longer messages

Discussed with @cmadeo and decided not to fix this one. System navigation bar handles it this way by default and I don't think it'll be possible to fix without some custom work. Also this is reproducible with long reading list titles in the reading list detail screen.

https://github.com/wikimedia/wikipedia-ios/pull/3150

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Jun 26 2019, 5:51 PM

Tsevener moved this task from Waiting for Build to Needs QA on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Jun 27 2019, 2:32 PM

• JMinor closed subtask T224054: Talk page MVP priority fixes fo user testing as Resolved.Jun 28 2019, 4:38 PM

• JMinor closed subtask T222725: Talk Pages: Handle error / loading / empty states as Resolved.Jun 28 2019, 4:42 PM

• JMinor closed subtask T220549: As an app editor I would like to be able to set specific signature preferences from within the app as Resolved.