Fix render of depicts statements without qualifiers
Closed, ResolvedPublic
Actions

Description

There's a little (CSS) line that gets added between depicts statements and their qualifiers.
However, there's a 5px (or so) leftover & 25px high node (.wbmi-item-content) that shouldn't be there (or rather: not visible) when there are no qualifiers.

Details

	Subject	Repo	Branch	Lines +/-
	Fix render of depicts statements without qualifiers	mediawiki/extensions/WikibaseMediaInfo	master	+27 -21

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Resolved		• Ramsey-WMF	T199352 Deploy Structured Data on Commons with arbitrary Statements
Resolved		Cparle	T204264 "Depicts crawling": Add displaying/editing statements to File page
Resolved		matthiasmullie	T216161 Fix render of depicts statements without qualifiers

Event Timeline

matthiasmullie triaged this task as High priority.Feb 14 2019, 5:44 PM

matthiasmullie created this task.

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Feb 14 2019, 7:05 PM

matthiasmullie claimed this task.Feb 15 2019, 1:05 PM

matthiasmullie edited parent tasks, added: T204264: "Depicts crawling": Add displaying/editing statements to File page; removed: T216130: Speed up initialization of JS depicts widget.

Change 490844 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix render of depicts statements without qualifiers

https://gerrit.wikimedia.org/r/490844

gerritbot added a project: Patch-For-Review.Feb 15 2019, 1:06 PM

matthiasmullie mentioned this in rEWBI40a418ed9f75: Fix render of depicts statements without qualifiers.Feb 15 2019, 1:11 PM

matthiasmullie moved this task from To Do to Verify on Production on the Structured Data Engineering board.Feb 15 2019, 1:35 PM

Change 490844 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix render of depicts statements without qualifiers

https://gerrit.wikimedia.org/r/490844

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.18; 2019-02-19).Feb 15 2019, 5:00 PM

MarkTraceur edited projects, added Structured Data Engineering (Depicts-Crawling); removed Structured Data Engineering.Feb 19 2019, 8:28 PM

MarkTraceur moved this task from To Do to Sign off on the Structured Data Engineering (Depicts-Crawling) board.

Cparle closed this task as Resolved.Feb 21 2019, 11:09 AM

• Phabricator_maintenance added a project: SDC-Statements (Depicts-Crawling).Mar 7 2019, 12:35 AM

greg added a project: Structured-Data-Team-Current-Work.Mar 7 2019, 10:59 PM