Page MenuHomePhabricator

AMC: add "In other projects" action to page actions overflow menu
Open, NormalPublic

Description

Description

When viewing a Wikipedia article, in the side navigation under “Tools” you’ll usually find a link to “Wikidata item”. Further down, under “In other projects”, you’ll find links to any other Wikimedia projects that have a matching page for the respective article:


We’d like to provide access to the “In other projects” experience in AMC. Since these links are page-specific, it makes sense to add these to the page actions menu, rather than the main navigation.

Design

  • tapping "Other projects" will lead to a sub-menu
  • tapping "Back" at the top of the sub-menu will lead back to the more menu
  • the order of the items in the "Other projects" sub-menu should follow the order they appear in on wikipedia.com
  • to reduce complexity for now I've created T224311 to deal with adding icons (it doesn't seem like we currently have SVG icons for all Wikimedia projects so there's a bit of work there)

Developer notes

@Jdlrobson you had written some notes about this but I can't find them. If you could add whenever you have time that'd be great, thanks.

Event Timeline

alexhollender renamed this task from Add "In other projects" menu action to AMC: add "In other projects" action to page actions overflow menu.
Jdlrobson moved this task from Inbox to Next up on the User-Jdlrobson board.Mar 27 2019, 10:54 PM
alexhollender added a subscriber: Jdlrobson.

Armchair designer here:
Since the "In other projects" menu link behaves differently than the other menu links, could we differentiate its bit more?
My suggestion would be to add an ">" forward arrow after the text, so it reads "[icon] In other projects [>]" .
Has that already been considered?

p.s.
I'm also not sure if from a technical perspective, this variation would add undo complexity to the menu system.

Armchair designer here:
Since the "In other projects" menu link behaves differently than the other menu links, could we differentiate its bit more?
My suggestion would be to add an ">" forward arrow after the text, so it reads "[icon] In other projects [>]" .
Has that already been considered?

Yea, I did sketch that out. I think you're right, especially given the sub-menu direction here. This is what I had sketched out:

Thoughts?

alexhollender updated the task description. (Show Details)Wed, Jun 5, 5:14 PM

@pmiazga, do you think your menu system can show a sub-submenu?

@Niedzielski yes, it's possible, and I thought about that use case when I was working on the Menu system. It's not available right now (because of YAGNI) but we can implement the support for submenus. On the backend we have sth like that:

Group::insertItem( IMenuElement $element)

We can insert anything to the Menu entry, only if implements the IMenuElement. We can make SubGroup that extends Group and implements IMenuEntry`, or just modify the Group to implement IMenuEntry.