Page MenuHomePhabricator

Avoid inserting echo_event rows when not needed
Open, Needs TriagePublic

Description

Right now an echo_event row is inserted every time a notification is sent. However, if "web" delivery is disabled for the recipients (or for the entire notification type), we correctly skip inserting an echo_notification row, but we still insert an echo_event row. We do still need this row if one of the recipients uses batched emails (because the echo_email_batch table needs an event_id to refer to), but if none of the recipients use batching, we should not insert an echo_event row.

Related Objects

Event Timeline

Catrope created this task.Apr 17 2019, 4:33 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 17 2019, 4:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript