Page MenuHomePhabricator

Add CC0 License overlay popup on termbox editing
Open, NormalPublic5 Story Points

Description

Given I am editing Termbox content
When I click the Publish button
I will to be informed what license will my contributions be under
so that I can participate in the open data movement with confidence

Mock:

Acceptance Criteria

  • When a user clicks the save button when being in editing mode, they are confronted with an overlay as seen in the mock (exception: "Remember decision for future edits" - checkbox is not part of this ticket)
  • The text above the checkbox should reflect the first part of the text shown in the current License Popup in the V1 Desktop Termbox: By clicking "publish", you agree to the <a href="/w/index.php?title=Wikidata:Copyrights&amp;action=edit&amp;redlink=1" class="new" title="Wikidata:Copyrights (page does not exist)">terms of use</a>, and you irrevocably agree to release your contribution under the <a rel="nofollow" class="external text" href="https://creativecommons.org/publicdomain/zero/1.0/">Creative Commons CC0 License</a>.
  • The terms of use and CC0 licence links open in new tabs. They should direct to the same pages the desktop version links to.
  • have a layer effect on the editable page (i.e. transparent white overlay --> 50% white)
  • When clicking cancel, the user goes back to edit mode. this allows e.g. to review or at least copy all edits already made
  • when clicking save the user agrees to the licensing for once --> the pop up will be shown again next time editing as long as the user avoids clicking the checkbox mentioned in T221836

Remarks:

  • license pop up cannot be "clicked away" without making a decision
  • this story only concerns the mobile termbox. For the desktop behaviour refer to T221779.

Notes from Task Breakdown
There is a similar message key wikibase-shortcopyrightwarning which could be reused or we could create a new one
There is a global in php which links to the license link $wgRightsUrl
We are happy to only inject the message etc into the client. It doesn't also need to make it to the SSR.
There exists window.mw.config.get('wbCopyright') which includes the totally assembled message using the message form wikibase not the new text/copy from the mock-up
We could use this with the config mixin: https://gerrit.wikimedia.org/r/plugins/gitiles/wikibase/termbox/+/master/src/client-entry.ts#22
We could also "improve" the MessageRepo to build something similar and add it as an additional message

Event Timeline

WMDE-leszek updated the task description. (Show Details)

Note to myself and you: What happens, if users do not check the accept line? Will the pop up be shown over and over again?
I believe that's what is currently happening on desktop, right?

Lea_WMDE triaged this task as Normal priority.May 8 2019, 10:58 AM
Lea_WMDE updated the task description. (Show Details)
Lea_WMDE updated the task description. (Show Details)
WMDE-leszek updated the task description. (Show Details)May 8 2019, 2:18 PM
WMDE-leszek updated the task description. (Show Details)May 8 2019, 2:21 PM
WMDE-leszek set the point value for this task to 5.May 8 2019, 2:23 PM
Tarrow updated the task description. (Show Details)Tue, May 28, 3:06 PM
Tarrow updated the task description. (Show Details)Tue, May 28, 3:19 PM

@Lea_WMDE Just a heads up that in general this message is configurable on mediawiki.

See for example: https://www.mediawiki.org/wiki/Manual:$wgRightsUrl. We assume that we should take this into account. The most consistent way for us to do this is to use the same message that is constructed in Wikibase however this contains a slight textual difference: It reads

By clicking "publish", you agree to the <a href="/w/index.php?title=Wikidata:Copyrights&amp;action=edit&amp;redlink=1" class="new" title="Wikidata:Copyrights (page does not exist)">terms of use</a>, and you irrevocably agree to release your contribution under the <a rel="nofollow" class="external text" href="https://creativecommons.org/publicdomain/zero/1.0/">Creative Commons CC0 License</a>.

This is very similar but not the same. note: publish vs save. Is making this change an acceptable change to the copy? In task breakdown this seemed the best way forwards to us devs.

@Tarrow yes, sorry, there was even still a TODO to rephrase for publish. Updating the task description now.

Lea_WMDE updated the task description. (Show Details)Tue, May 28, 7:00 PM
Lea_WMDE updated the task description. (Show Details)Mon, Jun 3, 10:12 AM

@Lea_WMDE @Hanna_Petruschat_WMDE I believe it does not explicitly mention it - is the focus/tab order to be in line with what we did for the IP warning? T223542

Change 517406 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Update Termbox

https://gerrit.wikimedia.org/r/517406

@Hanna_Petruschat_WMDE This story is almost complete from the dev side. While testing it in integration locally I noticed that the license link looks funny, because Minverva tries to mark external links with a special icon.
Screenshot:

Do we want to have the icon too, or should it be removed? Either way is fine, but it obviously cannot stay the way it is.